Date: Tue, 21 Apr 2020 11:45:53 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Amit Langote <amitlangote09@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables
Message-ID: <20200421154553.GA21155@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200420230406.GA27302@alvherre.pgsql>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Apr-20, Alvaro Herrera wrote:

> +	while (HeapTupleIsValid(trigtup = systable_getnext(scan)))
> +	{
> +		Form_pg_trigger pg_trigger = (Form_pg_trigger) GETSTRUCT(trigtup);
> +		ObjectAddress trig;
> +
> +		/* Ignore triggers that weren't cloned */
> +		if (!OidIsValid(pg_trigger->tgparentid) ||
> +			!pg_trigger->tgisinternal ||
> +			!TRIGGER_FOR_ROW(pg_trigger->tgtype))
> +			continue;

Actually, shouldn't we be checking just "!OidIsValid(pg_trigger->tgparentid)"
here?  Surely the other two conditions should already not matter either
way if tgparentid is set.  I can't see us starting to clone
for-statement triggers, but I'm not sure I trust the internal marking to
remain one way or the other.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services