Date: Tue, 21 Apr 2020 11:45:10 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Langote <amitlangote09@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables
Message-ID: <20200421164510.GJ3890@telsasoft.com>
References: <20200421154553.GA21155@alvherre.pgsql>
 <20200421162038.GA18628@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200421162038.GA18628@alvherre.pgsql>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Apr 21, 2020 at 12:20:38PM -0400, Alvaro Herrera wrote:
> diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
> index 7595e609b5..233905552c 100644
> --- a/doc/src/sgml/ref/alter_table.sgml
> +++ b/doc/src/sgml/ref/alter_table.sgml
> @@ -941,13 +943,14 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
>      <term><literal>DETACH PARTITION</literal> <replaceable class="parameter">partition_name</replaceable></term>
>      <listitem>
>       <para>
>        This form detaches specified partition of the target table.  The detached
>        partition continues to exist as a standalone table, but no longer has any
>        ties to the table from which it was detached.  Any indexes that were
> -      attached to the target table's indexes are detached.
> +      attached to the target table's indexes are detached.  Any triggers that
> +      were created to mirror those in the target table are removed.

Can you say "cloned" here instead of mirror ?
> +      attached to the target table's indexes are detached.  Any triggers that
> +      were created as clones of triggers in the target table are removed.

Also, I see in the surrounding context a missing word? 
This form detaches THE specified partition of the target table.

-- 
Justin