Date: Sun, 26 Apr 2020 11:13:24 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org,
	Alexander Korotkov <a.korotkov@postgrespro.ru>
Subject: Re: doc review for v13
Message-ID: <20200426161324.GS28974@telsasoft.com>
References: <20200408165653.GF2228@telsasoft.com>
 <20200410022746.GT1606@paquier.xyz>
 <20200410030150.GZ2228@telsasoft.com>
 <20200410062902.GX1606@paquier.xyz>
 <20200412213545.GO2228@telsasoft.com>
 <20200414054754.GH1492@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="DiL7RhKs8rK9YGuF"
Content-Disposition: inline
In-Reply-To: <20200414054754.GH1492@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk


--DiL7RhKs8rK9YGuF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 14, 2020 at 02:47:54PM +0900, Michael Paquier wrote:
> On Sun, Apr 12, 2020 at 04:35:45PM -0500, Justin Pryzby wrote:
> > Added a few more.
> > And rebased on top of dbc60c5593f26dc777a3be032bff4fb4eab1ddd1
> 
> Thanks for the patch set, I have applied the most obvious parts (more
> or less 1/3) to reduce the load.  Here is a review of the rest.

Thanks - attached are the remaining undisputed portions..

> > +++ b/doc/src/sgml/ref/alter_table.sgml
> > @@ -889,7 +889,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
> >        from the parent table will be created in the partition, if they don't
> >        already exist.
> >        If any of the <literal>CHECK</literal> constraints of the table being
> > -      attached is marked <literal>NO INHERIT</literal>, the command will fail;
> > +      attached are marked <literal>NO INHERIT</literal>, the command will fail;
> >        such constraints must be recreated without the
> >        <literal>NO INHERIT</literal> clause.
> >       </para>
>
> It seems to me that both are actually correct here.

I think my text is correct.  This would *also* be correct:

|       If any <literal>CHECK</literal> constraint on the table being
|       attached is marked <literal>NO INHERIT</literal>, the command will fail;

But not the hybrid: "If any OF THE .. is .."

-- 
Justin

--DiL7RhKs8rK9YGuF
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="v4-0001-doc-percent-encoding.patch"