Date: Thu, 30 Apr 2020 20:19:01 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	"tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: SLRU statistics
Message-ID: <20200430181901.24tlriahmafi4sfn@development>
References: <20200229122441.ow7gnnqgesmojyc3@development>
 <20200229144426.GA32500@alvherre.pgsql>
 <20200229205518.xrxo535zgd7cl6no@development>
 <20200327004111.md4suoi6u5suv2qe@development>
 <20200328002630.2nz5y3dvymqnvxtv@development>
 <20200402004136.wodwftan45mcwggm@development>
 <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <f02fd0ec-a240-b5bf-9992-5faf582738f1@oss.nttdata.com>
Precedence: bulk

On Fri, May 01, 2020 at 03:02:59AM +0900, Fujii Masao wrote:
>
>
>On 2020/04/02 9:41, Tomas Vondra wrote:
>>Hi,
>>
>>I've pushed this after some minor cleanup and improvements.
>
>+static char *slru_names[] = {"async", "clog", "commit_timestamp",
>+							  "multixact_offset", "multixact_member",
>+							  "oldserxid", "pg_xact", "subtrans",
>+							  "other" /* has to be last */};
>
>When I tried pg_stat_slru, I found that it returns a row for "pg_xact".
>But since there is no "pg_xact" slru ("clog" slru exists instead),
>"pg_xact" should be removed? Patch attached.
>

Yeah, I think I got confused and accidentally added both "clog" and
"pg_xact". I'll get "pg_xact" removed.

>Regards,
>
>-- 
>Fujii Masao
>Advanced Computing Technology Center
>Research and Development Headquarters
>NTT DATA CORPORATION

>diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
>index 6562cc400b..ba6d8d2123 100644
>--- a/doc/src/sgml/monitoring.sgml
>+++ b/doc/src/sgml/monitoring.sgml
>@@ -3483,7 +3483,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
>        predefined list (<literal>async</literal>, <literal>clog</literal>,
>        <literal>commit_timestamp</literal>, <literal>multixact_offset</literal>,
>        <literal>multixact_member</literal>, <literal>oldserxid</literal>,
>-       <literal>pg_xact</literal>, <literal>subtrans</literal> and
>+       <literal>subtrans</literal> and
>        <literal>other</literal>) resets counters for only that entry.
>        Names not included in this list are treated as <literal>other</literal>.
>       </entry>
>diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
>index 50eea2e8a8..2ba3858d31 100644
>--- a/src/backend/postmaster/pgstat.c
>+++ b/src/backend/postmaster/pgstat.c
>@@ -152,7 +152,7 @@ PgStat_MsgBgWriter BgWriterStats;
>  */
> static char *slru_names[] = {"async", "clog", "commit_timestamp",
> 							  "multixact_offset", "multixact_member",
>-							  "oldserxid", "pg_xact", "subtrans",
>+							  "oldserxid", "subtrans",
> 							  "other" /* has to be last */};
>
> /* number of elemenents of slru_name array */


-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services