Date: Thu, 7 May 2020 21:22:02 -0700
From: Noah Misch <noah@leadboat.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
Message-ID: <20200508042202.GA563018@rfd.leadboat.com>
References: <20200505031600.GB21752@momjian.us>
 <20200506063910.GA515983@rfd.leadboat.com>
 <20200506234025.GC3649@momjian.us>
 <20200507052057.GB541283@rfd.leadboat.com>
 <20200507133834.GJ3649@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200507133834.GJ3649@momjian.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Thu, May 07, 2020 at 09:38:34AM -0400, Bruce Momjian wrote:
> On Wed, May  6, 2020 at 10:20:57PM -0700, Noah Misch wrote:
> > On Wed, May 06, 2020 at 07:40:25PM -0400, Bruce Momjian wrote:
> > > On Tue, May  5, 2020 at 11:39:10PM -0700, Noah Misch wrote:
> > > > On Mon, May 04, 2020 at 11:16:00PM -0400, Bruce Momjian wrote:
> > > > > Allow skipping of WAL for new tables and indexes if wal_level is 'minimal' (Noah Misch)
> > > > 
> > > > Kyotaro Horiguchi authored that one.  (I committed it.)  The commit message
> > > > noted characteristics, some of which may deserve mention in the notes:
> > > 
> > > Fixed.
> > 
> > I don't see that change pushed (but it's not urgent).
> 
> I got stuck on Amit's partition items and my head couldn't process any
> more, so I went to bed, and just committed it now.  I was afraid to have
> pending stuff uncommitted, but I am also hesitant to do a commit for
> each change.

Got it, +1 for batching such changes.

> > > > - Crash recovery was losing tuples written via COPY TO.  This fixes the bug.
> > > 
> > > This was not backpatched?
> > 
> > Right.
> 
> Oh.  So you are saying we could lose COPY data on a crash, even after a
> commit.  That seems bad.  Can you show me the commit info?  I can't find
> it.

commit c6b9204
Author:     Noah Misch <noah@leadboat.com>
AuthorDate: Sat Apr 4 12:25:34 2020 -0700
Commit:     Noah Misch <noah@leadboat.com>
CommitDate: Sat Apr 4 12:25:34 2020 -0700

    Skip WAL for new relfilenodes, under wal_level=minimal.
    
    Until now, only selected bulk operations (e.g. COPY) did this.  If a
    given relfilenode received both a WAL-skipping COPY and a WAL-logged
    operation (e.g. INSERT), recovery could lose tuples from the COPY.  See
    src/backend/access/transam/README section "Skipping WAL for New
    RelFileNode" for the new coding rules.  Maintainers of table access
    methods should examine that section.
    
    To maintain data durability, just before commit, we choose between an
    fsync of the relfilenode and copying its contents to WAL.  A new GUC,
    wal_skip_threshold, guides that choice.  If this change slows a workload
    that creates small, permanent relfilenodes under wal_level=minimal, try
    adjusting wal_skip_threshold.  Users setting a timeout on COMMIT may
    need to adjust that timeout, and log_min_duration_statement analysis
    will reflect time consumption moving to COMMIT from commands like COPY.
    
    Internally, this requires a reliable determination of whether
    RollbackAndReleaseCurrentSubTransaction() would unlink a relation's
    current relfilenode.  Introduce rd_firstRelfilenodeSubid.  Amend the
    specification of rd_createSubid such that the field is zero when a new
    rel has an old rd_node.  Make relcache.c retain entries for certain
    dropped relations until end of transaction.
    
    Bump XLOG_PAGE_MAGIC, since this introduces XLOG_GIST_ASSIGN_LSN.
    Future servers accept older WAL, so this bump is discretionary.
    
    Kyotaro Horiguchi, reviewed (in earlier, similar versions) by Robert
    Haas.  Heikki Linnakangas and Michael Paquier implemented earlier
    designs that materially clarified the problem.  Reviewed, in earlier
    designs, by Andrew Dunstan, Andres Freund, Alvaro Herrera, Tom Lane,
    Fujii Masao, and Simon Riggs.  Reported by Martijn van Oosterhout.
    
    Discussion: https://postgr.es/m/20150702220524.GA9392@svana.org