Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXav4-0005rM-0U for pgsql-hackers@arkaria.postgresql.org; Sun, 10 May 2020 01:38:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jXav1-0006Ia-Lz for pgsql-hackers@arkaria.postgresql.org; Sun, 10 May 2020 01:38:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXauz-0006HP-Uh for pgsql-hackers@lists.postgresql.org; Sun, 10 May 2020 01:38:15 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXaus-0001yJ-U8 for pgsql-hackers@postgresql.org; Sun, 10 May 2020 01:38:12 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DCEA85C00BE; Sat, 9 May 2020 21:38:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 09 May 2020 21:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=BPFuOJy4ogrIH5BvCmQH7KEsOQp NFubU6B1z7c4udRA=; b=jZlENVdYS24KnLXlFulxW6gQCP09lhjY3LXM7t6e4vH 4J/nTHm3x10qCOdLWVFaJIm1Q3p4p1GZ28iLCfTyJWacdVNDtQ9WFaneouvY6Pu4 KxYZ8grmy+hBqGZggAzCF1j6190fuI+dAo+G3ccuAm+5O1fhwlEfMwlAQmgx8Nvs HlUSF3ctEbIPQCKvLvnIJ0rdLXjUTtcZ3L29svxQSJDtHOVhiRa58/vA8FvQTAH/ mn7uYzfjp3OmpeSpp/L/f2D7iJsyY2TEC3tVTgXHmnk9wTWLC0UqXLTw/JlY/jtT BRqBEt2gOF5Tm/QcN4Ib9WH589CEMKWJPub/0yUkpFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BPFuOJ y4ogrIH5BvCmQH7KEsOQpNFubU6B1z7c4udRA=; b=XEY9W681zCtP7k7xmXGKI8 lMwBQSoAShoJLQQfdT1DZvLK80mYCm1dLSXZtT3gxV2dH/nkE3c/AR6SLwTLq96i ZN+iSUQ6gADuUinRV2RgZUxVM/jLmpJAD1EZMs5iZzApi3iFPM9Rh7WeFzhifRyG ZOQ1AUinpeQQAFHJ+mh1fupiwqUfhO3yCSsj0XmImKmyqT6fd3lfYRe86U0jFK2S CGRvaIO4G1P3/22Fkzc2jc8rUVCn3sO0E9MAUmkFB0pogU0zAGISdNmOqmsxHEvO Ejd5gE9jcb/6gbZJKAww5zcKMJvAI7Udz9+L5AbRLnBA6SZkIXWCQ+8RZRWFDHpg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkeeigdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecukfhppeduuddurddutddvrddukedtrd dukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 597C5306623E; Sat, 9 May 2020 21:38:03 -0400 (EDT) Date: Sun, 10 May 2020 10:37:59 +0900 From: Michael Paquier To: Tom Lane Cc: Andres Freund , pgsql-hackers@postgresql.org Subject: Re: Add -Wold-style-definition to CFLAGS? Message-ID: <20200510013759.GA2004@paquier.xyz> References: <20200509174820.g4bwftmz7blz35ph@alap3.anarazel.de> <4838.1589048101@sss.pgh.pa.us> <20200509184354.hpkxuvip64nlnqve@alap3.anarazel.de> <19295.1589065916@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <19295.1589065916@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, May 09, 2020 at 07:11:56PM -0400, Tom Lane wrote: > I'd be OK with pushing it now, but I dunno about other people. Sounds like a good idea to me to apply this part now. > If we do want to push this sort of thing now, the nearby changes > to enable fallthrough warnings should go in too. If we do that, merging this second part before beta1 is out looks like a good compromise to me. -- Michael --gKMricLos+KVdGMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl63WvcACgkQnvQgOdby QH0qbg//Xpt6kARn9dmcz8niQH8ftFMH42VqD4fYiR0aVS8QxEAq9QJGxqLmIEaa qcz9fr3yI0FVRJayaYbHkxQTXgRRZoIkI2JkPQw3QWUKqhvJtSCAIfmiOHOI+ori ebgKfd5iBUfAnOuYjyNbnMd12oZaXNuiy/TMHlUJO1rT/Hnf9D9e2qPLOBxH/0cF l0ErxGmyZI1lyVeyEE6qgDtgP4gt+goBS/TVKU/E12P7mCpIufGMuRmNaoTzVMFc t7btZSgkc8IK3DRWSTZdpzS1R2ylrAOpE69bLI7nB4pAWEpfg8lrHhMOh4nYFFlJ +GuRm4tm2DGsBtxRIn16xF1JDeolduXMmHEvNwGN2D+WTkn4g24PlzX875vr9R5q n4nqGlrB8LnorUCEDZnv/HbwzC0ZWla9i3/ycLmPoYNcNz4GQ6ZrkqU7OZNlGWz0 W9SjcnebpRmZr8SpY4TGKsHbP4KCdxTF4jkgnr+jPmIden8uKLUTWtNkLhMnb8sI HKZxeLYbJiQZkFCfrLdy7x74uLBo7/hL+fx/OrXuvcXjApGsdh9+cO0hnED1Wz+I b9+l2dDhwf4eBh9ikoYl47SJxQAdx0AhWXhBf6WScGc1rPg9eHA85Y+0+S/j8z1O vsyopTy7MCSaLE+OpD1AboVNPedBL4lNiFXNSUkc8C3l4xrugP4= =TYbg -----END PGP SIGNATURE----- --gKMricLos+KVdGMg--