Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jXzOC-0006AS-63
	for pgsql-hackers@arkaria.postgresql.org; Mon, 11 May 2020 03:46:00 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jXzOB-0003P7-2j
	for pgsql-hackers@arkaria.postgresql.org; Mon, 11 May 2020 03:45:59 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1jXzOA-0003P0-SB
	for pgsql-hackers@lists.postgresql.org; Mon, 11 May 2020 03:45:58 +0000
Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1jXzO8-0007ES-LA
	for pgsql-hackers@postgresql.org; Mon, 11 May 2020 03:45:57 +0000
Received: by mail-qt1-x841.google.com with SMTP id x8so6791120qtr.2
        for <pgsql-hackers@postgresql.org>;
 Sun, 10 May 2020 20:45:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=gFgbXvMAmy9ZJLbB1nz/vpEnw8ehhb4JUagBug1qVlQ=;
        b=mDMh0WGxXjBO2HyGsAyMd4EK5bGhkmZdpZAl/SCvR3H+YnbH1HR0JnfGajab6BDPay
         b+8nLqQB6pqmE9iC7nI2B4cItiGG/m/e7DNOjnmjiYcfi0M2UvKZ4xuQuGl9I40ekeji
         SHuxloFlsVDH4huFKeUUHoRsPHezSkerIhawas6NL5chOIhvXfjELHF8WyH0R+QKDWT/
         Monw5mURZ7e0DAC1dBHwkdvP08bM6asSy8dU/STZKExnEMBwFmMMkTqvBYndAtgnGaHw
         CV23wow0PAp/mCaYLXxdenkGtQ4ilzAFPJ4bqs7HK6UkEAPWo+GMbvtjb6V8RuqEMBib
         /7VQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=gFgbXvMAmy9ZJLbB1nz/vpEnw8ehhb4JUagBug1qVlQ=;
        b=URKs2NTGgHzvy6z01zdGIzi4VuQwSqYho/8wsfwD1vF5QvFFI9RmPaHUWFsEitxMCq
         5ePgyQnBz31xR36+vhz60RNMuiTEXP+7a3cftWqx4qjKdoG9MBJpaR9JUuaoBuUhzrhy
         IF0ZaLH2W8Ho+rlJ+hF/+YNkkLErdVYobgN64XiM2xWGRXTcTYmu719TwEaYFdrXxcy4
         VDjqUfT8LfXOWJ8dls6T/dnaTroL50SobFAeLiDgg1TZ8i6yDxyUPYSD6K2TRIUxo4Cy
         TXy48uHtKu3obLHGvovema3BsgNnWVz6yQzDEjck/qb5ZYBa9qbgw9vskx2GgBVD02zg
         DGuQ==
X-Gm-Message-State: AGi0PuZMtFEbUT+O+YWpaEJPtoSpQOFA7XdhMnh689PjnBHTwtYZsszC
	ZOlQkCGeVA1G8+5XbVWcX017NZK9G7pP9A==
X-Google-Smtp-Source: 
 APiQypLjSiJQ5TpN9bhR4f8EdGF0yQUdoUaciXmJ173l99IRrP8Awsk1pVc95WoI/+CP1QW2A4UqnA==
X-Received: by 2002:ac8:2bfd:: with SMTP id
 n58mr14343979qtn.296.1589168755074;
        Sun, 10 May 2020 20:45:55 -0700 (PDT)
Received: from nimloth.alvh.no-ip.org ([190.95.18.252])
        by smtp.gmail.com with ESMTPSA id
 o14sm7120542qkj.27.2020.05.10.20.45.54
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Sun, 10 May 2020 20:45:54 -0700 (PDT)
Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000)
	id 9C8AB30081B; Sun, 10 May 2020 23:45:52 -0400 (-04)
Date: Sun, 10 May 2020 23:45:52 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Subject: Re: Add -Wold-style-definition to CFLAGS?
Message-ID: <20200511034552.GA6769@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <19295.1589065916@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2020-May-09, Tom Lane wrote:

> If we do want to push this sort of thing now, the nearby changes
> to enable fallthrough warnings should go in too.

I'll get that sorted out tomorrow.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services