Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jZBlS-00026M-BT
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 May 2020 11:10:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jZBlQ-0002Do-T8
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 May 2020 11:10:56 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <cb@df7cb.de>)
	id 1jZBlQ-0002DE-MG
	for pgsql-hackers@lists.postgresql.org; Thu, 14 May 2020 11:10:56 +0000
Received: from feynman.df7cb.de ([195.49.152.168])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <cb@df7cb.de>)
	id 1jZBlJ-00063M-B3
	for pgsql-hackers@postgresql.org; Thu, 14 May 2020 11:10:56 +0000
Received: from msg.df7cb.de (unknown
 [IPv6:2a02:908:1474:3de0:76e5:bff:fef3:7e00])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)
 server-digest SHA256)
	(Client did not present a certificate)
	by feynman.df7cb.de (Postfix) with ESMTPSA id 49N83X26rDz3DwZ;
	Thu, 14 May 2020 13:10:48 +0200 (CEST)
Date: Thu, 14 May 2020 13:10:47 +0200
From: Christoph Berg <myon@debian.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: ldap tls test fails in some environments
Message-ID: <20200514111047.GA445283@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <20200508191644.GA165095@msg.df7cb.de>
 <11682.1588966471@sss.pgh.pa.us>
 <20200508194533.GB165095@msg.df7cb.de>
 <20200513160544.GC373033@msg.df7cb.de>
 <CA+hUKG+_n-zt1EAZaZfojjXh9StROu+880pRrXVvtQTWEC_UMg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKG+_n-zt1EAZaZfojjXh9StROu+880pRrXVvtQTWEC_UMg@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Re: Thomas Munro
> > 17:28:59 Data directory: /<<PKGBUILDDIR>>/build/src/test/ldap/tmp_check/t_001_auth_node_data/pgdata
> 
> I know nothing about Debian package building so I could be missing
> something about how this works, but I wonder if our script variable
> handling is hygienic enough for paths like that.

That's from the sbuild log filter, the special chars are not the
problem:

17:06:41 I: NOTICE: Log filtering will replace 'build/postgresql-13-fdfISX/postgresql-13-13~~devel~20200513.1505' with '<<PKGBUILDDIR>>'
17:06:41 I: NOTICE: Log filtering will replace 'build/postgresql-13-fdfISX' with '<<BUILDDIR>>'

> > It consistently fails on the build server, but works on my notebook.
> > Maybe that simply means slapd is crashing, but there's no slapd
> > output. Would it be possible to start slapd with "-d 255", even if
> > that means it doesn't background itself?
> 
> That'd require more scripting to put it in the background...

Maybe adding "&" is enough, provided it still writes the pid file for
shutting down...

> This leads me to suspect that something in your build server's
> environment that comes later in that list is overridding the
> TLS_REQCERT setting.  If that's the explanation, perhaps we should do
> this, which seems to work OK on my system, since it comes last in the
> list:

It's not messing with environment variables in that area.

I'll see if I can catch a shell in the environment where it fails.

Christoph