Date: Thu, 14 May 2020 16:56:54 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org,
	Isaac Morland <isaac.morland@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: Our naming of wait events is a disaster.
Message-ID: <20200514205654.GA24219@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1261.1589488034@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-May-14, Tom Lane wrote:

> A case could be made for doing s/async/notify/ more widely in async.c;
> for instance it's odd that the struct protected by NotifyQueueLock
> didn't get renamed to NotifyQueueControl.  But that seems a bit out
> of scope for the immediate problem, and anyway I'm not sure how far to
> take it.  I don't really want to rename async.c's externally-visible
> functions, for instance.  For the moment I just renamed symbols used
> in the SimpleLruInit() call.

That approach seems fine -- we'd only rename those things if and when we
modified them for other reasons; and the file itself, probably not at all.
Much like our renaming of XLOG to WAL, we changed the user-visible term
all at once, but the code kept the original names until changed.


Maybe in N years, when the SCM tooling is much better (so that it
doesn't get confused by us having renamed the file in the newer branches
and back-patching to an older branch), we can rename xlog.c to wal.c and
async.c to notify.c.  Or maybe not.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services