Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jb4Kt-0004vj-AR for pgsql-hackers@arkaria.postgresql.org; Tue, 19 May 2020 15:39:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jb4Kq-0006aq-Gx for pgsql-hackers@arkaria.postgresql.org; Tue, 19 May 2020 15:39:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jb4Kq-0006aj-A8 for pgsql-hackers@lists.postgresql.org; Tue, 19 May 2020 15:39:16 +0000 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jb4Kn-0005kT-Om for pgsql-hackers@lists.postgresql.org; Tue, 19 May 2020 15:39:15 +0000 Received: by mail-qv1-xf44.google.com with SMTP id r3so6719725qve.1 for ; Tue, 19 May 2020 08:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=e/kk8nHtLXE2NThL0/c+hR3K6bAHdOXJa0gMWSszbkg=; b=fVPsJiKESFCE+AA+5iVIyNkxcoGOKDTBc/4GVklMb9Hb9pVtEZXBLv1fZ9pySaQlQM hQkH2T5BKbstI+sgke5v31ebyGIU9htGUNO0aCkNkvCN66ju2obokD2AqjxUyWir146b Ztj8q2v0tAca36uJEvAKw1ACD+bfGfc2DClrMDsfNTHN9KsFqsd2++B8tvLvStVmcBrc P90pE23UweBFrwYqLxAQaO2QYvGzUOTMH0FoTfxWhZ+jnl21+bkbPEt0U0+RysR/cFPe lkMwrqnZNT0oOA4mRU2rqFXhnrXww90sasdAtaQFDapQRLNQ2a2dngvKltlIvJmGrXY/ ywxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=e/kk8nHtLXE2NThL0/c+hR3K6bAHdOXJa0gMWSszbkg=; b=sat/o5pOrS8ZpdpWN6x1kv9Bnp97Al6GaNRpsP0o+7vjXuNj0v+IpG2oNELs9iD9Hk xq1jphGfR0Z2UTTIHAojbW+9M12DY71aPmsQaOYbRcrQR8sGKEwMZnmyw/Zkf2mYHyMY BjLsUJl1j7vJgVWkDdCkLkeaFRKRT/f9A3oubaD9Qd+e78kWabO7obBZVMD762eGYmj8 K8OLIRvgVAu1eGLYTd0czi8k1qFmJhuYgefzgXx3PUIxS5z9LOnCTnKXrjwI5J9BvYRN 0OfTCn51A9Mo/E8V3Ei2ds1/PT4dYWkRYOf/pSELHe/PXDHbN2UhFx6qXi2Q1njGpQA9 70iw== X-Gm-Message-State: AOAM530YoNj6T+syMxUI6CmlKuZ44prNxWNNYV7akYcZjmJxLphIVe9m iuj232YLvnPQg0nLeWl3FNqZVEyr2XW8oZFximqH26I5A1CSAhe+QhN88hh8h7JWrja++PbMpDY bglgMcmVB866CT5jIhJ/K2va+/P7y2UdVBNAxozUFHs/6dBIK4EiqSzRK+ZnDtahifLqsoG+OIT vwpCZiHWP5g0Ggcf6o X-Google-Smtp-Source: ABdhPJwrfHzHJ16dK0Sl0Pan1JNg1WCxp4vAxXK6ctSynt1P2sY4WC86fK9DdZpqbiNzAmBJ3Srzhw== X-Received: by 2002:a05:6214:1c2:: with SMTP id c2mr116014qvt.185.1589902751054; Tue, 19 May 2020 08:39:11 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.95.18.252]) by smtp.gmail.com with ESMTPSA id z14sm7762133qki.83.2020.05.19.08.39.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 08:39:10 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 75A423007EE; Tue, 19 May 2020 11:39:08 -0400 (-04) Date: Tue, 19 May 2020 11:39:08 -0400 From: Alvaro Herrera To: Tom Lane Cc: Michael Paquier , Vik Fearing , PostgreSQL Hackers Subject: Re: Missing grammar production for WITH TIES Message-ID: <20200519153908.GA17489@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <26190.1589894392@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-May-19, Tom Lane wrote: > Yeah, that would have been better per project protocol: if a tarball > re-wrap becomes necessary then it would be messy not to include this > change along with fixing whatever urgent bug there might be. > > However, I thought the case for delaying this fix till post-wrap was kind > of thin anyway, so if that does happen I won't be too fussed about it. > Otherwise I would've said something earlier on this thread. In the end, it's a judgement call. In this case, my assessment was that the risk was small enough that I could push after I saw the tarballs announced. In other cases I've judged differently and waited for longer. If the fix had been even simpler, I would have pushed it right away, but my confidence with grammar changes is not as high as I would like. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services