Date: Fri, 29 May 2020 16:21:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: sitnikov.vladimir@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical ()
 at walsender.c:2762
Message-ID: <20200529072138.GG44192@paquier.xyz>
References: 
 <CAB=Je-GOWMj1PTPkeUhjqQp-4W3=nW-pXe2Hjax6rJFffB5_Aw@mail.gmail.com>
 <20200528.170436.1361384430172307883.horikyota.ntt@gmail.com>
 <CAB=Je-HnFcwPUeLq5CXUqBnC7G7WeTi7DdGKbnFe-EizvnBJmw@mail.gmail.com>
 <20200528.181139.1631626601933187948.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="G3juXO9GfR42w+sw"
Content-Disposition: inline
In-Reply-To: <20200528.181139.1631626601933187948.horikyota.ntt@gmail.com>
Precedence: bulk


--G3juXO9GfR42w+sw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 28, 2020 at 06:11:39PM +0900, Kyotaro Horiguchi wrote:
> Mmm. It is not the proper way to use physical replication and it's
> totally accidental that that worked (or even it might be a bug). The
> documentation is saying as the follows, as more-or-less the same for
> all versions since 9.4.
>=20
> https://www.postgresql.org/docs/13/protocol-replication.html

+       if (am_db_walsender)
+               ereport(ERROR,
+                       (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
+                                errmsg("cannot initiate physical
replication on a logical replication connection")));

I don't agree with this change.  The only restriction that we have in
place now in walsender.c regarding MyDatabaseId not being set is to
prevent the execution of SQL commands.  Note that it is possible to
start physical replication even if MyDatabaseId is set in a
replication connection, so you could break cases that have been valid
until now.

I think that we actually should be much more careful with the
initialization of the WAL reader used in the context of a WAL sender
before calling WALRead() and attempting to read a new WAL page.
--
Michael

--G3juXO9GfR42w+sw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl7QuAIACgkQnvQgOdby
QH3XAg//VidnyzYhlRtcjuiQGXEPvS91f0SZ0SzPDMmD5skHnk43lPtnBOOOUQlg
AtW/2upyCBm18yGJ5yS7aoXv6tDIzgJMbMnXaYfT3QqmuKJ+UFsNscxbuxqm5zCY
9mWsSuwpl/zYhQZ3TwLUSicf4b9y3eRl/W6eb2BxHv/kRvO9xbJgWj9kLJ4snK1u
CJI7P1gs8eEdid+kZ92AbijOqpArA7tuAJ6+b3BDgzMBAu6UjdZaZGkZsTezj6nH
iSS4fqForofrCPGrCAZ1yOdn982kgBaiUpXRRvqwLtK9BhgTLQhNCFLPI9Hnc098
nVjzjmoAwk0nXkcnCFTqkGa2DXHanaumGxu3V7SYZrWLeYpQ+JnybS2hnNZP1k0r
nLXP8QYKhVgCHx4kmVlj4eMU4ri3ICaBj8vcZD1kWIKiXRJvsihTKx3Jd+GXjqUv
F/OfPMLatI3qcLe+PPHdXwEW5dVBCkRcwbv2GozDnPcwU2djxy+Up2BL4v6OsSoK
OPBW+ubpyzLOaG2grwFlWahmsTE0yHVFegjz3tej+Y8g/8Gg9Oo47jgXJPaafvLa
1muyuvpq6mhNEuDBMSd+pldQPquhGRfrBQS6lCnhAWEX6JAlRet4lehIpQjiCAn0
HXLpBR/f5m88ryMExk6iT8Wc4TKU+99cPEEGi5iZiJD41GceuuM=
=/mwk
-----END PGP SIGNATURE-----

--G3juXO9GfR42w+sw--