Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjO0m-0004m8-Fe for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jun 2020 14:16:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jjO0l-0007Tu-Av for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jun 2020 14:16:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjO0l-0007Tm-39 for pgsql-hackers@lists.postgresql.org; Thu, 11 Jun 2020 14:16:55 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jjO0i-00033U-UG for pgsql-hackers@postgresql.org; Thu, 11 Jun 2020 14:16:53 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id D11045F79E; Thu, 11 Jun 2020 10:16:50 -0400 (EDT) Date: Thu, 11 Jun 2020 10:16:50 -0400 From: Stephen Frost To: Michael Paquier Cc: Alexey Kondratov , Alexander Korotkov , Peter Eisentraut , Alvaro Herrera , Kuntal Ghosh , Liudmila Mantrova , Thomas Munro , Andrey Borodin , David Steele , Andres Freund , PostgreSQL-development , Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru Subject: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line Message-ID: <20200611141650.GI6680@tamriel.snowman.net> References: <20200326224729.GB1836@paquier.xyz> <20200330015648.GA43995@paquier.xyz> <750ea0322cd68c0973d9ff248909811d@postgrespro.ru> <20200331064821.GA1549@paquier.xyz> <20200608061452.GB2589@paquier.xyz> <7f1f33d96eba3a6b4d83133895bef25d@postgrespro.ru> <20200610042337.GI38342@paquier.xyz> <20200611065045.GA365021@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yM67Jke3vYveALNI" Content-Disposition: inline In-Reply-To: <20200611065045.GA365021@paquier.xyz> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --yM67Jke3vYveALNI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Michael Paquier (michael@paquier.xyz) wrote: > On Wed, Jun 10, 2020 at 01:23:37PM +0900, Michael Paquier wrote: > > Okay. After sleeping on it, it looks like would be better to move > > this new fe_archive.c to src/fe_utils/. I'll try to do that tomorrow, > > and added an open item so as we don't forget about it. >=20 > Applied this part now as of a3b2bf1. Uh, doesn't this pull these functions out of libpgcommon, where they might have been being used by utilities outside of our client tools? Thanks, Stephen --yM67Jke3vYveALNI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJe4jzSAAoJEO1sijiDR2RVttUP/1T/5bZpSc68yUfxOf76hk9F LFKVjBkgbfzVSxIUV02SVyflEkvJ4aQsXmg9EtbWkyh7OgTCPUud6yOCwVwW7b8m 0SpISqWzuH3qqcHAhADFe8xKSSXYNQvkfqUtUN1+gH/AmUroUYYFVYSMiNgspiIL +/acwCr5Rg14/hGGY9/zPVXTO726dttBRdBRAtE7MVJp6BHuz0YibnACeAO0Mqil mMcw/tZ2ZRxIXQdGPhl4gXPmSEGCCTBT0MH5Lu+6lUx3lNA6npVDkixv0hHbXk2q I9KyNL3MshXWorAHTBkmME31v32neuuz4drETr3La2JBDk+BeMCmTQuZitn22CXV UEYDAX2DiFV9x+ZpC9EvlsQ6MQjZXkxEhA8svZFXZ+XTH82x0sDJ31VKc/EfMGqJ 6TtgHe1thp3a9JKI4EYR+Jc+YIZ0EQsZDZIaUM6hZpH2g3PxdCPaxvC2+fMK8YGc ihr6Ks1ArTen6HAarRfgOWtGSpchfYhAeypoZSlr8GxZWMaS1HQdvFTjKPPzaFOa 5oYCrmoFGgVmpZyLo154BXLEGuWQFoJcoAOhpaen8DN0mS2gzr9M3HPN/MYNgA3i rqJHnq8LL9hARtnaZkW/K2IWWwQHUsgO0anUJdzok3mpbrFyAxktbptRsU+pZL2O SRqW2DUAXWhUGARwZVjj =CHKE -----END PGP SIGNATURE----- --yM67Jke3vYveALNI--