Date: Mon, 15 Jun 2020 21:37:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?utf-8?B?5p2O5p2wKOaFjui/vSk=?= <adger.lj@alibaba-inc.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	=?utf-8?B?5pu+5paH5peMKOS5ieS7jik=?= <wenjing.zwj@alibaba-inc.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: =?utf-8?B?5Zue5aSN77yaaG8=?= =?utf-8?Q?w?= to create index
 concurrently on partitioned table
Message-ID: <20200615123742.GL52676@paquier.xyz>
References: <3c2edeb5-e216-4411-9a74-f27fcc0f6793.adger.lj@alibaba-inc.com>
 <20200612072017.GE3362@paquier.xyz>
 <20200612181542.GJ14879@telsasoft.com>
 <55841c84-4ab6-4c79-9d1c-f67db2b229db.adger.lj@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VnOTrGv5LmZxna7m"
Content-Disposition: inline
In-Reply-To: <55841c84-4ab6-4c79-9d1c-f67db2b229db.adger.lj@alibaba-inc.com>
Precedence: bulk


--VnOTrGv5LmZxna7m
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 15, 2020 at 08:15:05PM +0800, =E6=9D=8E=E6=9D=B0(=E6=85=8E=E8=
=BF=BD) wrote:
> As shown above, an error occurred while creating an index in the second p=
artition.=20
> It can be clearly seen that the index of the partitioned table is invalid=
=20
> and the index of the first partition is normal, the second partition is i=
nvalid,=20
> and the Third Partition index does not exist at all.

That's a problem.  I really think that we should make the steps of the
concurrent operation consistent across all relations, meaning that all
the indexes should be created as invalid for all the parts of the
partition tree, including partitioned tables as well as their
partitions, in the same transaction.  Then a second new transaction
gets used for the index build, followed by a third one for the
validation that switches the indexes to become valid.
--
Michael

--VnOTrGv5LmZxna7m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl7na5YACgkQnvQgOdby
QH19sw/+I404N/6a/3lTxoDnE8iG+cgHnPKIIt7QsFI9Rk2aXVsOdcGoHuy2xbgi
g+uHs5/hZs9v2ym/4qinq6ozS4ELORh6sMnT6nABA9f+Snz4/DASGQuli5IX3SON
/KnRUg+z/J5Ccx+pEdvS83VRndzVJAuyxw3mY0vmmTBlAan5XC0d5TYKG8UCg7Gx
T79pFO0Eq1EH/McG029x3bvtny9NkWUm5/zTR4IpcgImEkki5mDqTrRGwOxQTk5V
IOeBWuPs087/tLTRdLGt33oFGxeeF0EPs1qYcvgRflkonHxXaGEN9UizHu9tt1it
czgFJVis+r/8l2x6Uz7O24Cd+MTSlBU5Ml8BfIXibNb/qjnuZC67420D0EOUtUVG
ehVQI4nwKsy4ratowp7TKCKsCkHlwkFdQNH94LtpbXMVCS4EqHYyN2XghFIJPlC2
IViCpnGVI/W4DD+i7tmdE4Xvz2q6eVar5qKxCPLyG65hIhZAtbvW1/ntxieWxhIZ
UFUG3hc/yrcmkfPJdqvjWBDD+icvp9UxozhTH/e3cEQo6exE25vWeZr2jArUxWnS
BSQbv8f7X7vhcL3nhszuGiERSrh4mkDHbzPB90OwIeNh28mP+cZLOED/lNJD8UbK
vHiE+g44rIRjx/idww7r7wKnW/wMqINr7nW3QxrwxXyJM3MIynk=
=S7eI
-----END PGP SIGNATURE-----

--VnOTrGv5LmZxna7m--