Date: Thu, 18 Jun 2020 10:42:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_regress cleans up tablespace twice.
Message-ID: <20200618014200.GD118592@paquier.xyz>
References: <20200515025855.GE2462@paquier.xyz>
 <20200515.172508.1423943947298901347.horikyota.ntt@gmail.com>
 <20200617070804.GC2361@paquier.xyz>
 <20200617.170231.2041463748911808790.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="aPdhxNJGSeOG9wFI"
Content-Disposition: inline
In-Reply-To: <20200617.170231.2041463748911808790.horikyota.ntt@gmail.com>
Precedence: bulk


--aPdhxNJGSeOG9wFI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 17, 2020 at 05:02:31PM +0900, Kyotaro Horiguchi wrote:
> It look good to me as the Windows part. I agree that vcregress.pl
> don't need to parse EXTRA_REGRESS_OPTS by allowing a bit more tight
> bond between the caller sites of pg_regress and pg_regress.

Thanks, applied this part to HEAD then after more testing.

> Chaining to TAP sounds nice as a goal.

I submitted a patch for that, but we had no clear agreements about how
to handle major upgrades, as this involves a somewhat large
refactoring of PostgresNode.pm so as you register a path to the
binaries used by a given node registered.

> As the next step we need to amend GNUmakefile not to cleanup
> tablespace for the four test items. Then somehow treat tablespaces at
> non-default place?

Ah, you mean to not reset testtablespace where that's not necessary in
the tests by reworking the rules?  Yeah, perhaps we could do something
like that.  Not sure yet how to shape that in term of code but if you
have a clear idea, please feel free to submit it.  I think that this
may be better if discussed on a different thread though.
--
Michael

--aPdhxNJGSeOG9wFI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl7qxmgACgkQnvQgOdby
QH1zQxAAoPiq97YMVuUSutRr3kjVK7RPo/6S1DelZ3spF3zYy0nnrAyyxiQX7xna
Vdlie0mHNNy6OL7o8VrPOND6UTO5zRJe+Y7Lf1zugxU5ReDE8sUf+6NdC1j+gCdq
hm3dmvKLGklpCyulncmE2Bih11PDRn6RkloErqqMCVpAaO/AXA3ZX0p7Lsg5DzVG
jSrT+vWtziPGCsYbhltrHdHKsKrTh45KAmeGABHQ2yoSkr/d4omulEPO1L6b1scs
FmhMHGE529/BIpKw+4KkzIF8P3MebCe6WdPre6RlD5Ybdcdis/9asZN2Wu7kSI0d
B4xdn+oEqz6DwzAVwPQnFpmPdXlw2hg4PBtf36pxrfOgSaXQ4wEN3+HdD66orFz8
caW18jC/XNzl3Eespnp27POWxL99yylXiM37MMNNiC8sdAH7UaAwFh0S5t3swyvb
flPXYTQ5V0oSpeX7bYlmpfQklyxoMwhd/xPXOBbt+AdBQ0hLTZQXmE09swEMW3eI
wt6qhy6oBM4qABsEJz83TZAaffe8ovi3rqwLv7/l/+vn/lf8pf0dErZYUnxeZbUA
SgODUGgPBe4TCfsVB/TonC9E04cvt8E013GAYqmbo6Ua7N1BAO0Z4+/SCOeOdnRO
zJq20x6u2zKOS5YKaCOhDvbLiVlUkfr/suT/stp4DGcF8O13qyc=
=SIZ7
-----END PGP SIGNATURE-----

--aPdhxNJGSeOG9wFI--