Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jowlr-0000Iq-Qx
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jun 2020 22:24:31 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jowlq-00073F-H2
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Jun 2020 22:24:30 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jowlq-000738-9p
	for pgsql-hackers@lists.postgresql.org; Fri, 26 Jun 2020 22:24:30 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jowll-0004Oz-DE
	for pgsql-hackers@postgresql.org; Fri, 26 Jun 2020 22:24:28 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1jowlj-0006JY-Hr; Fri, 26 Jun 2020 18:24:23 -0400
Date: Fri, 26 Jun 2020 18:24:23 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
Message-ID: <20200626222423.GC3337@momjian.us>
References: <20200626202036.GA5474@alvherre.pgsql>
 <20200626202326.GA5823@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="RnlQjJ0d97Da+TV1"
Content-Disposition: inline
In-Reply-To: <20200626202326.GA5823@alvherre.pgsql>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk


--RnlQjJ0d97Da+TV1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 26, 2020 at 04:23:26PM -0400, Alvaro Herrera wrote:
> Reading Luis Carril's other entry in the relnotes,
> 
>  Allow pg_dump --include-foreign-data to dump data from foreign servers (Luis Carril)
> 
> It seems to suggest that --include-foreign-data existed previously,
> which is not true. I would have worded it as "Add --include-foreign-data
> option to pg_dump to allow dumping data from foreign servers".

OK, pg_dump item about FOREIGN keyword removed from PG 13 release notes,
and the above item clarified.   Patch attached and applied to PG 13.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee


--RnlQjJ0d97Da+TV1
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="foreign.diff"

diff --git a/doc/src/sgml/release-13.sgml b/doc/src/sgml/release-13.sgml
new file mode 100644
index 401c557..45d8f0b
*** a/doc/src/sgml/release-13.sgml
--- b/doc/src/sgml/release-13.sgml
*************** Author: Peter Eisentraut <peter@eisentra
*** 1534,1555 ****
        </para>
       </listitem>
  
-      <listitem>
- <!--
- Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
- 2020-03-20 [4e6209134] pg_dump: Add FOREIGN to ALTER statements, if appropriate
- -->
- 
-       <para>
-        Add <literal>FOREIGN</literal> to <command>ALTER</command> statements,
-        if appropriate (Luis Carril)
-       </para>
- 
-       <para>
-        WHAT IS THIS ABOUT?
-       </para>
-      </listitem>
- 
      </itemizedlist>
  
     </sect3>
--- 1534,1539 ----
*************** Author: Alvaro Herrera <alvherre@alvh.no
*** 2414,2423 ****
  -->
  
        <para>
!        Allow <link
         linkend="app-pgdump"><application>pg_dump</application></link>
!        <option>--include-foreign-data</option> to dump data from foreign
!        servers (Luis Carril)
        </para>
       </listitem>
  
--- 2398,2407 ----
  -->
  
        <para>
!        Add <link
         linkend="app-pgdump"><application>pg_dump</application></link>
!        option <option>--include-foreign-data</option> to dump data from
!        foreign servers (Luis Carril)
        </para>
       </listitem>
  

--RnlQjJ0d97Da+TV1--