Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jsBIO-0007ct-2g for pgsql-hackers@arkaria.postgresql.org; Sun, 05 Jul 2020 20:31:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jsBIM-0000vj-R1 for pgsql-hackers@arkaria.postgresql.org; Sun, 05 Jul 2020 20:31:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jsBIM-0000vS-Fw for pgsql-hackers@lists.postgresql.org; Sun, 05 Jul 2020 20:31:26 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jsBII-0005gF-Aa for pgsql-hackers@postgresql.org; Sun, 05 Jul 2020 20:31:25 +0000 Received: by mail-il1-x136.google.com with SMTP id t4so18082324iln.1 for ; Sun, 05 Jul 2020 13:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ot219IbzNGQD+Gj/R3tZy6Wdsh4luIAHAAJdwo+52gc=; b=rfLSpllskuElFLiVu2LYfMW8iT19eV67q+jZuakm2DTv2RifjtKHz/huGDybfExW0s x4f4QC1ADJcb2eiKH1hCnxri2J5Lg1i8+GHCwd1CIYt0ZFx008GwNC+dZEddj2HwdufT /ewYzodL1/XG2f8s5YjMaNAIKiMZ5mFrknbJXVBgmYX5Y2sp9OqBa6ou7btN23I7maDo 3HN0JUBJsAJ5GC7eSPHvMF/LnHXU9fGk5PII+BQyRHM+FyYoCRFfAxHaml2v9XY3QRrv 3cBSdc3Q+mPYymCcOYn+wKz8MM/fYsciBw1WvMLUPD+aXDG3Q0dJ9iQyhnFMkFtIxGJ3 lknw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ot219IbzNGQD+Gj/R3tZy6Wdsh4luIAHAAJdwo+52gc=; b=Op/fs2Z1We52fT7M+wgxV5wChBOQIUMGC+Z1Qn3KKv+opnxVWrww4nMkBT6ZYo2L3h pnP6JdwpHsgb7GqXyWZQR9KdbemL++PONwApH6XODAbpBROtPX+xPJxwMOoCiy7kSzns yw2BLrjJqD5GduxGIiW9TEran7xD8fGwDveLUW4fdrkOgwneXhfe+y1aoOKtdLqsqF6c xJKw1e3S5fRDq9ULe6aRu/osHn/2vlt0p6O0119AjBj/wNXlnoVvB+kTvGj3pGyiZHch ZhfJ3WR4JrhPJcUi8FCTacBdiRyA8fmKA1J4HMzrPOE/NlNcEYi7FMwXvSYdDrezhhWZ kxLQ== X-Gm-Message-State: AOAM532bHNAa7ClnlRVF5mNGhUHh8nn+G1VtSKC7DFhmJQH2A7XV1MF4 71yJeXc1Y9lok47QIb2EMdGyFQ== X-Google-Smtp-Source: ABdhPJz6HtD1MKMTsGzuvVQPqj7v7Y3jnkAN11bHuclr4ye8k1Mojaf3XPRzyjM3SmZiIFKKWzEXTA== X-Received: by 2002:a92:cb03:: with SMTP id s3mr27811464ilo.1.1593981081429; Sun, 05 Jul 2020 13:31:21 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id q2sm10045294ilp.82.2020.07.05.13.31.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Jul 2020 13:31:20 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 86FAC80015C; Sun, 5 Jul 2020 15:31:19 -0500 (CDT) Date: Sun, 5 Jul 2020 15:31:19 -0500 From: Justin Pryzby To: Pavel Stehule Cc: pgsql-hackers@postgresql.org Subject: Re: proposal: possibility to read dumped table's name from file Message-ID: <20200705203119.GT4107@telsasoft.com> References: <20200529182514.GL17850@telsasoft.com> <20200608212957.GB22473@telsasoft.com> <20200609223042.GF26811@telsasoft.com> <20200701212452.GF4107@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701212452.GF4107@telsasoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Jul 01, 2020 at 04:24:52PM -0500, Justin Pryzby wrote: > On Thu, Jun 11, 2020 at 09:36:18AM +0200, Pavel Stehule wrote: > > st 10. 6. 2020 v 0:30 odesílatel Justin Pryzby napsal: > > > > + /* ignore empty rows */ > > > > + if (*line != '\0') > > > > > > Maybe: if line=='\0': continue > > > We should also support comments. > > Comment support is still missing but easily added :) Still missing from the latest patch. With some added documentation, I think this can be RfC. -- Justin