Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtZSb-0007ts-0G for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2020 16:31:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jtZSZ-0003vJ-G1 for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2020 16:31:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtZSZ-0003tL-8X for pgsql-hackers@lists.postgresql.org; Thu, 09 Jul 2020 16:31:43 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jtZSX-0004tf-7f for pgsql-hackers@postgresql.org; Thu, 09 Jul 2020 16:31:42 +0000 Received: by mail-qk1-x744.google.com with SMTP id 80so2368177qko.7 for ; Thu, 09 Jul 2020 09:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=D1/dyo5D154Hmyz1FZYuIz48uulJXqSeQ79SSp81hIk=; b=uASHotkH/ervRhLB7MFEV5j00GbaAO06flQhJuivosY1tHGU5uvesSkKPThmTHGmqS h6PsyYfhMEP45KnZfeHKWdtxG/7gHClCTH2w1xNW/L9xyC9hy+6W6iVEIwI6kmuJBJR5 JnEa3ip+PI8FUwYDK4hJS91c5zQ2k/EUZ4SUdJcm7oaJYuqukx3Tv1gAplHTlCUWlS6j zLVIpqQ+xbasZ20LBsIklHIBmm56hQyEFSOc9lYlEXzRYSfxQWjm8YGMak5jRjuhB8PM CKAHuYTEE55H/Z7z9Uw6PL3onBr13it2JLxWz9gp30Do2QWB6M38akE53QqSzcExrkbS t+tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=D1/dyo5D154Hmyz1FZYuIz48uulJXqSeQ79SSp81hIk=; b=Nm3wXZPNpdNYxdH29hS0CaOzw+AjTsH7FOBoPI+6H9ws2kGoTlD1Aa0yb+Gk+8ttWM lT+04k96BTDF3YfqgtzrchqYQKN4Ao0KtyHf+iiMvSBgJd172FhskPqKnVcd2LFQQpdb YCGHacidnLVCNq5OW1v1nqCgYsbdRdfpuwiEOvGE1caocdMtuBUUYLtpY/cPBDTbvKEU 5dZvmv2nXq9T3D5T92kgOwdrcpMj/wsLJbhPotJJuymusBWQUJB2THgf3wG9QX6wlBsv J4MnkvS8lX0GkoFmD1eeKeo8RJMz7GTZtsqCnclTbFC65kz8GYFpIhFMSDsa6IqqJLg1 k7SQ== X-Gm-Message-State: AOAM530eQkBd5otjG48YM7QkA/n5m8KlbP8fTIxrWwkTJ4WQis3sc0O4 rVcFvt+ZYaCIRhlU+69/GjPspA== X-Google-Smtp-Source: ABdhPJyvACJxcK3YRSAS6MJjUXHnicq2xiPGgWhRbAWRmTfK8nLTcbm/d6b4B5f4E7NzFBUwYCHbGQ== X-Received: by 2002:a05:620a:2155:: with SMTP id m21mr52911287qkm.14.1594312300512; Thu, 09 Jul 2020 09:31:40 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.18.252]) by smtp.gmail.com with ESMTPSA id b196sm4162010qkg.11.2020.07.09.09.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 09:31:40 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 847F82A21F0; Thu, 9 Jul 2020 12:31:38 -0400 (-04) Date: Thu, 9 Jul 2020 12:31:38 -0400 From: Alvaro Herrera To: Daniel Gustafsson Cc: Peter Eisentraut , pgsql-hackers Subject: Re: Log the location field before any backtrace Message-ID: <20200709163138.GA23549@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jul-09, Daniel Gustafsson wrote: > > On 9 Jul 2020, at 11:17, Peter Eisentraut wrote: > > > > In PG13, we added the ability to add backtraces to the log output. After some practical experience with it, I think the order in which the BACKTRACE and the LOCATION fields are printed is wrong. I propose we put the LOCATION field before the BACKTRACE field, not after. This makes more sense because the location is effectively at the lowest level of the backtrace. > > Makes sense, +1 Likewise -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services