Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtZqg-00006k-7g for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2020 16:56:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jtZqd-0004lP-31 for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jul 2020 16:56:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtZqc-0004lC-S3 for pgsql-hackers@lists.postgresql.org; Thu, 09 Jul 2020 16:56:34 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jtZqZ-0006CM-On for pgsql-hackers@postgresql.org; Thu, 09 Jul 2020 16:56:34 +0000 Received: by mail-qk1-x744.google.com with SMTP id b4so2434045qkn.11 for ; Thu, 09 Jul 2020 09:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=U6dtpdhyDPbXkybAgC85l8g3TyV2LlqcnQgUKko1N3M=; b=UNTcd2eGU3SR7GTpYa43PxbgnBDMQ8GtDji1QgAX1jVQMIIcxbdHLWtJi1rc0Ka5Ou xph9Znioq8b7y1/gR0LGTOcG38xlMtCSsuXkdekMaiJ7IgxUBCxVu+ullymq4N/aREUS YFkP/23aCERJUtt1QjliSKuJJ1x1qoJDqmxHGUnQeIh+oUj1jIBQcGrR6tt/U1W6pxhK MxM+/11Ooba7AmgYQQy52vPakGSmNJidirXFU+FtgsWPOvRI9GcYcT1L7xJSvVfRrGCS /jGud8Op3h8UtXGo0hkBKkuIqt/kVj+dIncfdCwr8uAaVytnaheUpkrfs5U8Rpv2fEkZ xf1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=U6dtpdhyDPbXkybAgC85l8g3TyV2LlqcnQgUKko1N3M=; b=GL7BJWbPfnN+bZWczfvCHz4ZfpoDMkhP4WiDtiZj5b+zOnk4MYq+v0H6yFbq84Irvu B4WsLP6hc7y411Mdud1GIJJq3v3KocZu+muWeod1rMNQS5le5WwBVVWbcayfTZQNbpap aO7KROPIadP0NHVFMGIGHJPpwwhhqDkwxCGbd/WaP3IOCdfx3E0Q64VC4VZrT2/WVQMm Vm5q1hzeyumGWyF3Mv1gHMlgQbn9yPFUNyEsFxVN2WEK3t4BB5a1uDVHLiKk2JFSf6y1 qG/IqujoBK6jMcMFm7w1t5vcJt/ek+BiUWXvnEimbFnQJ8pewa8/Sxy1gGgG9JE8tQlB 3YLQ== X-Gm-Message-State: AOAM531tgB5n/U1woUesqU1myPFmctYe5xFRAONHH0XUsev4Qh8DBUWI 5csHyM6PT1WjXU6iLT7jQI9Gm1OVblo= X-Google-Smtp-Source: ABdhPJw+8LG5g5A5hMdhUaKy2dUY0b95EhfKkK8p568j5xayrPcuwy1OyYF1YJb/lgsbA+DVPcXjEA== X-Received: by 2002:a05:620a:1301:: with SMTP id o1mr66146485qkj.223.1594313790064; Thu, 09 Jul 2020 09:56:30 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.18.252]) by smtp.gmail.com with ESMTPSA id b7sm4205801qkl.18.2020.07.09.09.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 09:56:29 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id EFF6A2A21F0; Thu, 9 Jul 2020 12:56:27 -0400 (-04) Date: Thu, 9 Jul 2020 12:56:27 -0400 From: Alvaro Herrera To: Peter Eisentraut Cc: Fabien COELHO , pgsql-hackers Subject: Re: some more pg_dump refactoring Message-ID: <20200709165627.GA24091@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <68f63a2e-3576-9b65-ffb3-1235d5bec28a@2ndquadrant.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jul-09, Peter Eisentraut wrote: > On 2020-07-08 06:42, Fabien COELHO wrote: > > > What do you think about this patch to reorganize the existing code from that > > > old commit? > > > > I think it is a definite further improvement. > > > > Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to > > me. > > Thanks. I have committed that, and attached is my original patch adjusted > to this newer style. Thanks, I too prefer the style where queries are split in lines instead of a single very long one, at least when looking at log_statement=all lines generated by pg_dump runs. It's not a *huge* usability improvement, but I see no reason to make things worse. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services