Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtgnt-0005fO-KX for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Jul 2020 00:22:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jtgns-0007Tk-7e for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Jul 2020 00:22:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtgns-0007Tc-0m for pgsql-hackers@lists.postgresql.org; Fri, 10 Jul 2020 00:22:12 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jtgno-0000uU-0m for pgsql-hackers@lists.postgresql.org; Fri, 10 Jul 2020 00:22:10 +0000 Received: by mail-qt1-x843.google.com with SMTP id e12so3148428qtr.9 for ; Thu, 09 Jul 2020 17:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Hu6+Xi4r+Xz1QBzJN94PajT/6KKBYevAwee4D5d9PbY=; b=Thr2/4RBilJfT4GC1a8rUZdsSyFXYdUedLg5MeA9vawzheXnaBXRX3omKddl0e518F lccRxhTNC3SKwQkGGUMEO0s2JgMjOCyq20eEc3ZLRFBS7DsmaZyTsuUlOifTKgIRaFoX t/IsTIblLIGSLoXYbPda6kETwD64mwwyk48Z08mgxuzJNvUQKXSVN7Q7iq66VRTSZ38c Wg6LIbPlNN/Uuo+P0LsoqCJvmC0tPTYZR5SqAKtYJexmaLOKNCR0QzfhBn3Y1L04zTrD 1n8H8vgqrPSBxBT1g9GOuxK9VJwPvFp4dv0XzBl1gCuAXLr0HaQ87Ziuvwj1zh4iRor2 Lpdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Hu6+Xi4r+Xz1QBzJN94PajT/6KKBYevAwee4D5d9PbY=; b=Pht/sdGrMQ14v8F7ASEdSHXuhJKki+IjIg9ktx/uczCT5nwEHYE8I5LBAd4fzx8QQl HvI0yLTqZ138jE8jK5RpptQYog+yns56lHF2MwnI+XoxawEbUbem4lSm7DVSGErLBVYp v8+sLxN1kPTRgnwSJ0YNyzImVHJnl+gEnCA4xJq9UY+m3JbQurRUwC/QmRODbon18sxQ UvX37bmnb2y9krjQrpewJrNIO/BwP85QpLQvYk6lUTjhQJE9d0rT/405dKttwd6yg61V 2V1KWzSbbB4Oo1e3hMrl/D0daMewuELdHywRJYDkw9ST+Dz8JTurcCFUsA0zYI8NbV20 Dfxw== X-Gm-Message-State: AOAM531zH0mdoUZv/nwBQA9iwGYcMRJEc82l58+HQJVqwjYR4ilte+T+ W8IV0MqjkUTRg8pwBlReknYv20rtgw4QnpUqVvMHjxRvmeqy+6ml4ZiEcjsCL2ywkZvZrvVn8BH kQ/acbNyp7VJzaR7dOub8iIClbAIRVIQv1dtO9p6p0TJVB5vcya8k9oExZapH6lUiwy2g378pH8 +SoCxbCDgwpQuOpw== X-Google-Smtp-Source: ABdhPJwxps4wfx2NiiSa3bnDAWpVp6IY0xahFjfZFoPINME8pV+yvU4sSkE2J22yOijmqDh0JxpfXg== X-Received: by 2002:ac8:47c8:: with SMTP id d8mr24049879qtr.32.1594340526995; Thu, 09 Jul 2020 17:22:06 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.18.252]) by smtp.gmail.com with ESMTPSA id a68sm5310171qkc.110.2020.07.09.17.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 17:22:06 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id D8FFD2A1E9D; Thu, 9 Jul 2020 20:22:04 -0400 (-04) Date: Thu, 9 Jul 2020 20:22:04 -0400 From: Alvaro Herrera To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Intermittent BRIN failures on hyrax and lousyjack Message-ID: <20200710002204.GA29790@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200709225548.GA21677@alvherre.pgsql> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jul-09, Alvaro Herrera wrote: > I have a moment now, let me have a go at it. I agree with deleting the > message. I think I'll keep the comment, slightly reworded: > > /* > * Placeholder tuples only appear during unfinished summarization, and we > * hold SUE lock, so this function cannot run concurrently with > * that. Any placeholder tuples that exist must be leftovers from a > * crashed or aborted summarization; remove them silently. > */ Pushed to all branches. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services