Date: Fri, 10 Jul 2020 18:39:09 +0200
From: Julien Rouhaud <rjuju123@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@postgresql.org
Subject: Re: expose parallel leader in CSV and log_line_prefix
Message-ID: <20200710163909.sj2cbbovupzlesou@nol>
References: <20200315111831.GA21492@telsasoft.com>
 <20200315114933.udjdx5wcgwkjnw45@nol>
 <20200318212511.GN26184@telsasoft.com>
 <8EC64544-2EAA-48B1-8B69-85158CA3EAE9@yesql.se>
 <CAOBaU_a4=GXdqtXsU-2_o3oekEx3fsbCu-8ZB21oJm+CtfxNkA@mail.gmail.com>
 <20200710020940.GJ11153@paquier.xyz>
 <20200710022023.GE26220@telsasoft.com>
 <20200710151326.fics6czbbvloplsk@nol>
 <20200710161115.GK26220@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200710161115.GK26220@telsasoft.com>
Precedence: bulk

On Fri, Jul 10, 2020 at 11:11:15AM -0500, Justin Pryzby wrote:
> On Fri, Jul 10, 2020 at 05:13:26PM +0200, Julien Rouhaud wrote:
> > There's a thinko in the padding handling.  It should be dones whether MyProc
> > and/or lockGroupLeader is NULL or not, and only if padding was asked, like it's
> > done for case 'd' for instance.
> > 
> > Also, the '%k' escape sounds a bit random.  Is there any reason why we don't
> > use any uppercase character for log_line_prefix?  %P could be a better
> > alternative, otherwise maybe %g, as GroupLeader/Gather?
> 
> Thanks for looking.  %P is a good idea - it's consistent with ps and pkill and
> probably other %commands.  I also amended the docs.

Thanks!

So for the leader == NULL case, the AppendStringInfoSpace is a no-op if no
padding was asked, so it's probably not worth adding extra code to make it any
more obvious.

It all looks good to me, I'm marking the patch a ready for committer!