Date: Fri, 10 Jul 2020 17:52:02 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>, Jeff Davis <pgsql@j-davis.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>,
	Bruce Momjian <bruce@momjian.us>,
	Robert Haas <robertmhaas@gmail.com>,
	David Rowley <dgrowleyml@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Melanie Plageman <melanieplageman@gmail.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Default setting for enable_hashagg_disk
Message-ID: <20200710215201.GO12375@tamriel.snowman.net>
References: <20200709225840.GE12375@tamriel.snowman.net>
 <CAH2-WzmbycnZnxFTYnwkSkCPTVQbRoLiuEvo8gkZCKiQTL8GAQ@mail.gmail.com>
 <20200710000842.GF12375@tamriel.snowman.net>
 <CAH2-Wz=9f-gxPmqL9Lak0xddPmH0bgfAEioK+2BwTkuzyrtZEQ@mail.gmail.com>
 <20200710141714.GI12375@tamriel.snowman.net>
 <CAH2-Wzkd7cWK-mMPMb63JXxj2QFMan6hw+cQjdJKvdtCOpR7Ng@mail.gmail.com>
 <2107841.1594403217@sss.pgh.pa.us>
 <29847045df67838cd72dc2dfe830a11642fb7153.camel@j-davis.com>
 <CAH2-WzmG8PmY3Qs2L=OxdFJ3ZJvOiks7NB1VNe0dVSiP2L0Okw@mail.gmail.com>
 <2164168.1594416641@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iEWWOZ/QYGWEaBRW"
Content-Disposition: inline
In-Reply-To: <2164168.1594416641@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--iEWWOZ/QYGWEaBRW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Peter Geoghegan <pg@bowt.ie> writes:
> > It now seems likely that the hash_mem/hash_mem_multiplier proposal has
> > the support it needs to get into Postgres 13. Assuming that the
> > proposal doesn't lose momentum, then it's about time to return to the
> > original question you posed at the start of the thread:
>=20
> > What should we do with the hashagg_avoid_disk_plan GUC (formerly known
> > as the enable_hashagg_disk GUC), if anything?
>=20
> > I myself think that there is a case to be made for removing it
> > entirely.
>=20
> +0.5 or so for removing it.  It seems too confusing and dubiously
> useful.

I agree that it shouldn't exist.

Thanks,

Stephen

--iEWWOZ/QYGWEaBRW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJfCOMBAAoJEO1sijiDR2RVgGMQAI7zvqEHELQKOutJaxW1axJj
/hnMr7w0opKbP7LVmGAHL43Qk5WEaR7eD8zsYEIQsLnIvdDIL3NV2PReczpV9fpS
LFc87WPk9+0t8wEf9LxHNCdzrZjLXhXSeknMlqBUUnGuG4JZ7Fnic+vRlQDV3j1C
SbkbtkeUNQb3eTUOuHXzEbaMbbdHZElCBGC9S/rqtYNeG9L1D+W8LHvuti3GV9dX
En2UCDQe15LBBoaVqg1eeegwbUN0mePGbXa7Pf5rdqvpCAFd0lavOoCJmJTha9ip
KXLluITHhb5S5fLX8pBPXS1hNduZaP8Vl+KTmd00ARnENvJh87KOQo7m0tnNfbjC
/mDVrwnsShNM4+P63D3rod5JOJJDQiszm8RYCazkw9LGRqICBlOFroScsVzoqhV4
tPxIk3SOBSTkvRVmW0/uL9aQK2MWrtAh7/fLeqtQnJRaBcFAftP6QP8iW+A/dw5z
5tZg8dEABhRVYn1NnFk6fNnvcB8ruJEdIBVBe8ZEAIoogq3XLAkvO6W8VCDAnTia
46nK3YvCZrLduBaxXDobkZ+9arw9nC9JY8YCD2D6/LSX+DFgDIAS42uOFjufVobg
OHIFgk0ujuHEjKHhzi1Azr5W4l5pojYbHuYZY0xzO1tdskh2KaCRhSETjTJZXlMD
3iEEspe91xQHa7LsOHf0
=27G0
-----END PGP SIGNATURE-----

--iEWWOZ/QYGWEaBRW--