Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvsm2-0004dL-QI for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jul 2020 01:33:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jvsm0-0004Wd-I5 for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jul 2020 01:33:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvsm0-0004WV-6U for pgsql-hackers@lists.postgresql.org; Thu, 16 Jul 2020 01:33:20 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jvslq-0003mc-Lk for pgsql-hackers@postgresql.org; Thu, 16 Jul 2020 01:33:19 +0000 Received: by mail-qk1-x741.google.com with SMTP id r22so3988696qke.13 for ; Wed, 15 Jul 2020 18:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=YZ/obsp6yCdC+rHEzs4tFGow+NAl3DM3nibBpldYQIY=; b=euXGrSL3mZoQKlgz81Omd5kLm3XI01AR9yoDTj04AGpFNt+334oy/CoNd3oiBgS0lv fFqTQjqbCKvDG3ev2jGg4QRoMZProfO2rq9XBRcE6MpKQQAb+TUTNOfhmSzmxS0IupY3 sl7hS/K6Bkhff+rumI7XZCwqS9dljARCmbapsxxXoVCH5FL+tQ1a81isPbf6hyJP5Fja nF3lPYYJ72hOcO+pwHbSlP/2poT4W/xavrQhB1fgXGedXD75/lNK0me7OTX3mWDEmgJp prZHR6tFZ1Q+VxgbFssY4oD5P1TLF5FWg+Fgm/rYi7kgY5HXm+zhkmP8s8l+xS1Levww Xn/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YZ/obsp6yCdC+rHEzs4tFGow+NAl3DM3nibBpldYQIY=; b=SHAssrtTH1VjrxF81wngxFXZI/io4WtSX670ta3wUI2pqqEDU1pmiiAT3Z5U7BekXs C1u8to2U6+LJ/fDZ4e3ui7DWE6j74/9hIkmpCyRxMchz9TE7V0upc7ciZTCSgh5tWY0A VYaqASrW7CdRzu7I5B//hY5AeeetvlDeLmjdHxRSzKdN3uTJoNolU2Kz1t7bgoZCEKC0 YntjLjda0FNTqv5gXBzfljgQj2JJ3HOiEHwcp1kBP8Xl9/J0yCNCOBt5YsGijHcM3iY9 3HBNchSDeDHZZm1ncRn0J49y1qpkiGm8a5lAc4aGbFjIx2nvN3dw5wBz9+doeoql7FPf pbyg== X-Gm-Message-State: AOAM53364xI5z3OZ0WpxxJez81DoHNjnQSY0u0I8O/sp9Uihyw0drCEE F+mWWTXcmt+yF5t06LjnMSlaTA== X-Google-Smtp-Source: ABdhPJwkG7v48YWtrFhYVEdwktSSwjB9pobwmqWUbrsyvXrJwViRKh+XVDovi5LbZg4mN17V5m4pUQ== X-Received: by 2002:a37:27d6:: with SMTP id n205mr1800926qkn.379.1594863189146; Wed, 15 Jul 2020 18:33:09 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.19.47]) by smtp.gmail.com with ESMTPSA id z60sm5466988qtc.30.2020.07.15.18.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 18:33:08 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id CC2DF2A04C1; Wed, 15 Jul 2020 21:33:06 -0400 (-04) Date: Wed, 15 Jul 2020 21:33:06 -0400 From: Alvaro Herrera To: Andres Freund Cc: Daniel Gustafsson , Robert Haas , "Jonathan S. Katz" , Alexander Korotkov , PostgreSQL Hackers , Peter Geoghegan , Bruce Momjian , Thomas Munro , David Rowley Subject: Re: Improving connection scalability: GetSnapshotData() Message-ID: <20200716013306.GA13861@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200716012532.lfzpvg3w55d5rqrw@alap3.anarazel.de> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jul-15, Andres Freund wrote: > It could make sense to split the conversion of > VariableCacheData->latestCompletedXid to FullTransactionId out from 0001 > into is own commit. Not sure... +1, the commit is large enough and that change can be had in advance. Note you forward-declare struct GlobalVisState twice in heapam.h. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services