Date: Sat, 18 Jul 2020 15:15:32 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and
 pg_ls_*)
Message-ID: <20200718201532.GV23581@telsasoft.com>
References: <20200317031427.GU26184@telsasoft.com>
 <alpine.DEB.2.21.2003170828250.17584@pseudo>
 <20200317190401.GY26184@telsasoft.com>
 <20200331200812.GI14618@telsasoft.com>
 <alpine.DEB.2.21.2004121145190.5257@pseudo>
 <20200503024215.GJ28974@telsasoft.com>
 <20200526021003.GW4472@telsasoft.com>
 <alpine.DEB.2.22.394.2006070908120.32228@pseudo>
 <20200622015325.GG17995@telsasoft.com>
 <20200715030839.GX23581@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Tcb1KvpfnM4LxW2s"
Content-Disposition: inline
In-Reply-To: <20200715030839.GX23581@telsasoft.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk


--Tcb1KvpfnM4LxW2s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 14, 2020 at 10:08:39PM -0500, Justin Pryzby wrote:
> I'm still missing feedback from committers about the foundation of this
> approach.

Now rebased on top of fix for my own bug report (1d09fb1f).

I also changed argument handling for pg_ls_dir_recurse().

Passing '.' gave an initial path of . (of course) but then every other path
begins with './' which I didn't like, since it's ambiguous with empty path, or
.// or ././ ...  And one could pass './' which gives different output (like
././).  

So I specially handled the input of '.'.  Maybe the special value should be
NULL instead of ''.  But it looks no other system functions are currently
non-strict.

For pg_rewind testcase, getting the output path+filename uses a coalesce, since
the rest of the test does stuff like strcmp("pg_wal").

Still waiting for feedback from a committer.

-- 
Justin

--Tcb1KvpfnM4LxW2s
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v21-0001-Document-historic-behavior-of-links-to-directori.patch"