Date: Sat, 1 Aug 2020 08:49:10 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: pgsql-hackers@postgresql.org,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Subject: Re: display offset along with block number in vacuum errors
Message-ID: <20200801134909.GG20393@telsasoft.com>
References: 
 <CAKYtNApK488TDF4bMbw+1QH8HJf9cxdNDXquhU50TK5iv_FtCQ@mail.gmail.com>
 <20200727111352.GN4286@telsasoft.com>
 <CAKYtNApLJjAaRw0UEBBY6G1o0LRZKS7rA5n46BFh+NfwSOycdg@mail.gmail.com>
 <20200731215514.GC20393@telsasoft.com>
 <20200801061721.GF20393@telsasoft.com>
 <CAKYtNAo5O4v-cnUzgJ2x8NiR_Mp204dDi6xg-4ZT1oZZ1jFutw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAKYtNAo5O4v-cnUzgJ2x8NiR_Mp204dDi6xg-4ZT1oZZ1jFutw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sat, Aug 01, 2020 at 12:31:53PM +0530, Mahendra Singh Thalor wrote:
> Actually I was waiting for review comments from committer and other
> people also and was planning to send a patch after that. I already
> fixed your comments in my offline patch and was waiting for more
> comments. Anyway, thanks for delta patch.
> 
> Here, attaching v3 patch for review.

I wasn't being impatient but I spent enough time thinking about this that it
made sense to put it in patch form.  Your patch has a couple extaneous changes:

                case VACUUM_ERRCB_PHASE_VACUUM_HEAP:
                        if (BlockNumberIsValid(errinfo->blkno))
+                       {
                                errcontext("while vacuuming block %u of relation \"%s.%s\"",
                                                   errinfo->blkno, errinfo->relnamespace, errinfo->relname);
+                       }
                        break;
 
                case VACUUM_ERRCB_PHASE_VACUUM_INDEX:
@@ -3589,6 +3618,7 @@ vacuum_error_callback(void *arg)
                                           errinfo->indname, errinfo->relnamespace, errinfo->relname);
                        break;
 
+
                case VACUUM_ERRCB_PHASE_INDEX_CLEANUP:
                        errcontext("while cleaning up index \"%s\" of relation \"%s.%s\"",

I would get rid of these by doing like: git reset -p HEAD~1 (say "n" to most
hunks and "y" to reset just the two, above), then git commit --amend (without
-a and without pathnames), then git diff will show local changes (including
those no-longer-committed hunks), which you can git checkout -p (or similar).
I'd be interested to hear if there's a better way.

-- 
Justin