Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1k6gDq-0004IE-Mh
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Aug 2020 20:22:42 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1k6gDp-0000kX-Ju
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Aug 2020 20:22:41 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1k6gDp-0000kN-DF
	for pgsql-hackers@lists.postgresql.org; Fri, 14 Aug 2020 20:22:41 +0000
Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1k6gDm-0005rI-Ko
	for pgsql-hackers@postgresql.org; Fri, 14 Aug 2020 20:22:40 +0000
Received: by mail-qk1-x72f.google.com with SMTP id d14so9484268qke.13
        for <pgsql-hackers@postgresql.org>;
 Fri, 14 Aug 2020 13:22:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=ruM2MKLFi2oAKiIbuB1d3EtUvXgOS7YgS9M9nY4LGvk=;
        b=Yo4IE+usKez8o3pWFfdMxuerokphjAKgMyUHZdJBSxhkcjTfqjNaIL8pTaYf7AY6IU
         TL65A4G715vi9MM2LUblo1+2786FqX8etP4kHDVKv9joExdud3ZFv07CfXO17IDcVMho
         +98m0DxR2DTrTMlWE68V5BsxPNgGOhQIJ0FDzuBuImZpP8L9VyP9bqW13FOTprod3GME
         icX0FdHTmcNajl0ray/epzLn1mtDD4wWZJNXTPkGpVwmEB03EHxPbv8QKvQoSW4ZAlAn
         LlOfrq2WdeR+52mru521MEZPyMaNOzH5//OSquzur9pqxQz5BTA1xHj/KdpU9PU8K16j
         o52Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=ruM2MKLFi2oAKiIbuB1d3EtUvXgOS7YgS9M9nY4LGvk=;
        b=U5R4ZQUt8uhjzkI+WEG7gNVXuIgH8W3w2bW4XJn9M0OeIHCxpvZoOB3PbHsYbK8AUW
         WO3j+rJeKDRay9Pyo9X2ZWuszKeu8/DfepKH4iPrFJhqFt764axgbl8ANz1AZ1GQilvy
         xFCCRaF3Uu4WjLDO2ddJcpe4aoSA6xqqqerwDvdNmSDx/xvRYrO7lK7d4I8nWg3hmuV2
         Whp9YTh9qkRiLxi1EyyAuZs66VZ1PNoTj596RYHfkls26p7CWkdP1T7kvn8dS4aif/hG
         lVFt3jRVECZA1wUrRuer0SSsk8JX+vRlOeNXgzazZuTYetNYYNkB8hdeMjtUuySfqIaK
         ilCw==
X-Gm-Message-State: AOAM530KGVd39PjDAx699MRlHaOzr9HbUT6fejv5dY9KaXSpS1rZphPS
	HVltjSbIYhgoIdtEXVR49i2CJA==
X-Google-Smtp-Source: 
 ABdhPJwJuYgHcrpsOv7696G9xVswIIb7g6oF3e99pB+O8aBRME4+8mceh1EmqhTC0HSqWilf5+gGsQ==
X-Received: by 2002:a37:7ec4:: with SMTP id
 z187mr3569566qkc.204.1597436557411;
        Fri, 14 Aug 2020 13:22:37 -0700 (PDT)
Received: from perhan.alvh.no-ip.org ([190.95.19.47])
        by smtp.gmail.com with ESMTPSA id
 20sm11684150qtp.53.2020.08.14.13.22.36
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 14 Aug 2020 13:22:36 -0700 (PDT)
Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000)
	id 2A8D52A151C; Fri, 14 Aug 2020 16:22:35 -0400 (-04)
Date: Fri, 14 Aug 2020 16:22:35 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	Noah Misch <noah@leadboat.com>, Jesse Zhang <sbjesse@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Message-ID: <20200814202235.GA30890@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200813201628.GA29590@tamriel.snowman.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2020-Aug-13, Stephen Frost wrote:

> For my 2c, anyway, I like the idea of having folks update the typedefs
> themselves when they've got a patch that needs a new typedef to be
> indented correctly.

Well, let's for starters encourage committers to update typedefs.
Personally I've stayed away from it for each commit just because we've
historically not done it, but I can easily change that.  Plus, it cannot
harm.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services