Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7Z8B-000615-Jz for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Aug 2020 07:00:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k7Z8A-0005CD-II for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Aug 2020 07:00:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7Z8A-0005C4-BA for pgsql-hackers@lists.postgresql.org; Mon, 17 Aug 2020 07:00:30 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7Z86-0002SH-Q0 for pgsql-hackers@postgresql.org; Mon, 17 Aug 2020 07:00:29 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C82A45C00A2; Mon, 17 Aug 2020 03:00:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 17 Aug 2020 03:00:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=8g8TMihOz7oM6sVlnsz98U1IdWE iyt4ovi/2a7IYx40=; b=as+C4NuncBVW6jpvmSGUp2gLawjSRL5mLJo+ks1VnBo fLgKTrnPDauCMvMjLSPqhNnVUxfrKJGPt1FbQ4AyNduaj+koTJaasHi+TKy60RLY aBCen/2Oq+ZHAzmI6YAvX65rEW+VWf4ndJ9M9VrmeIrh0NW7ErG54aaVL7x0hM9Z 4Kjvvpn1UyKmcJ/EOOyg95x6NbaEwn134WyGUw1xld3z47kJ+IQ4l3Qwh1PzLbcm RgegKV1vA0KuC2XtQxP8IDOQlWMHHpmkpx6xtZ0esjRbgNBCmTET1wKQ9SXIiTIY U408DuUInHR5DxkvCNujU0+sqAv3BNUBYSCDA8oKiQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=8g8TMi hOz7oM6sVlnsz98U1IdWEiyt4ovi/2a7IYx40=; b=i1ly98LY/+CY1jYM8BbwGC TUK7rT2nbrIpu9k1kMlDTYGuYNebIswIRnjeYIbOS9FNujlwLgSw/KSXLx3y0lkR tq75TkafwQyPydaDEA/TNGTa+Ky4wIDZHbaTOgRD7S+XDuxwIwoME30uBdxvual2 JuT//7qBl8nAKKAyeNPzRiQXKayC+6drlOAZ6b2BvpyWY49Dwarr3CAuo5j1Mb5s NOI6NGM+dTo93ldkuIkIeeQ26qBrDMvqeTGtW1LnAPhYpzbRNiJygjLectzEkiBT ahOdzZjn8sX29KpaY8CcB8eZHIk4/7/opZinSEJRuLY9lJtYaeG9LcDyGm2/OLwA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddtvddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveej heehieevueeigeelteegleejleeiueeiheegvefhnecukfhppeduuddurddutddvrdduke dtrddukeehnecuufhprghmkfhppfgvthifohhrkhepudduuddruddtvddrudektddrudek heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmih gthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id A4CDF3280065; Mon, 17 Aug 2020 03:00:21 -0400 (EDT) Date: Mon, 17 Aug 2020 16:00:17 +0900 From: Michael Paquier To: Amit Kapila Cc: Heikki Linnakangas , pgsql-hackers Subject: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE Message-ID: <20200817070017.GE7787@paquier.xyz> References: <07b33e2c-46a6-86a1-5f9e-a7da73fddb95@iki.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GV0iVqYguTV4Q9ER" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --GV0iVqYguTV4Q9ER Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 15, 2020 at 11:05:43AM +0530, Amit Kapila wrote: > On Fri, Aug 14, 2020 at 2:17 PM Heikki Linnakangas wrot= e: >> It's always been like that, but I am not going backport, for fear of >> breaking existing applications. If a program reads the WAL, and would >> actually need to do something with commit records dropping relations, >> that seems like such a common scenario that the author should've thought >> about it and handled it even without the flag reminding about it. Fixing >> it in master ought to be enough. >=20 > +1 for doing it in master only. Even if someone comes up with such a > scenario for back-branches, we can revisit our decision to backport > this but like you, I also don't see any pressing need to do it now. +1. -- Michael --GV0iVqYguTV4Q9ER Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl86KwEACgkQnvQgOdby QH1bRw//ZcsD+KcrJyssR09fd/SFt8csjJBxdfvhZaHXadvftEf85nvVRvDoZWwA VFWuMZ1oTgQ2EIly46CRakv6QEzSO3WPkQPM78JTB2aFDEpBGjLtgXZlXLv656xN cKEA4tgvxZloRSAsZ7U0td2z3XZ4HmyQY1F8FGFWsI299UEKtEcBRML4c8zSHpv4 k+AKkTjukNL4gNsBAxatIm4BtvVEYflK+Yjl92FtObwp0FRoPVV2GzuLYOt0UhWa Rzdsg93JIHkrJDbyOne7j4oQ2IO37yd3hay++EuaU98eLAglSfgeFGyG4PfUGOMQ 7/uBUuM69pJlbPlxw1nVBd0/u+4SIhXOKvRUHT/E6O+inx4/BcvVcPdSYezsC22J OPiVUltX2kApaNWHBix1BhJHl7x1J6CmAWO6ku2A4MCPah5dba+zUZwPuYFtIqMC OY9z8NbkM3FdoEsqNMgISAJ+OgkX3dSoTWOB7mSu9aMiwqWMy7vdRMQccyC0oKmo RHSxZPIGrdRSm9mpd1CnPloGKjRPkZcqFBJCK5dU4DhtZMZCIFHBA9+2vN9+s+tu hDMEFCs/B+Uhf/Dfj+S+jnMo0wXh8eiLWKSYVrfF8xnU3dYL9xMt74/KD8iZkPKe c+E9EPx0CmuqbD+LBMQwxFogDQDxizA6XAFlQRFTzwqUjvaI6Ic= =mSNw -----END PGP SIGNATURE----- --GV0iVqYguTV4Q9ER--