Date: Thu, 20 Aug 2020 14:17:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: "ccold" left by reindex concurrently are droppable?
Message-ID: <20200820051713.GA3730@paquier.xyz>
References: <20200819211312.GA15497@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX"
Content-Disposition: inline
In-Reply-To: <20200819211312.GA15497@alvherre.pgsql>
Precedence: bulk


--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 19, 2020 at 05:13:12PM -0400, Alvaro Herrera wrote:
> In other words I propose to reword this paragraph as follows:
>=20
>    If the transient index created during the concurrent operation is
>    suffixed <literal>ccnew</literal>, the recommended recovery method
>    is to drop the invalid index using <literal>DROP INDEX</literal>,
>    and try to perform <command>REINDEX CONCURRENTLY</command> again.=20
>    If the transient index is instead suffixed <literal>ccold</literal>,
>    it corresponds to the original index which we failed to drop;
>    the recommended recovery method is to just drop said index, since the
>    rebuild proper has been successful.

Yes, that's an improvement.  It would be better to backpatch that.  So
+1 from me.

> (The original talks about "the concurrent index", which seems somewhat
> sloppy thinking.  I used the term "transient index" instead.)

Using transient to refer to an index aimed at being ephemeral sounds
fine to me in this context.
--
Michael

--huq684BweRXVnRxX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl8+B1kACgkQnvQgOdby
QH1ysxAAgZ2rrifaSQw43OecGLx93kNzTgtcprWpvmw4AsjgOQ4hPpDiaDL+pT1x
n83/RPY/Yd3MjdnTpjOsX9kATV12gz3l4JVg6EcNgfaPk95DGKjmXw2QHhNo/gjj
x1hFY9ih2Uq7BUTTJ7cQXjjVjGZ66UHXTfgchKfdAVLptdnnhTMhVWRCkT5P0UxG
b+6adp20nm+dLinVUDGYE0/skmLx703qC1BKVCU59x53oJ5jZ3BV8gYS8pwAMdfg
VaPZ6A3493VToH2HgS39czRIBoqxVlfGdnZw6Vcs3RW/TBwxxLFFGME1QPU5At+P
Erh1lKkGgedHz2hL9iPB3HvltsHEqzddtXKIf4mj09WradFKQOvBJB2lwZwyO9Ky
2aNL7kXZ+zlImyt30OvzAEvbh0V/pnlnWSjY5c5XI1eFwyNNThZc53ii2CFfd0Rk
nF5rkJObxzU887iz5se2i8+/rF8ecmEe2xtL4f4yfzOpiRajhr2ZCF4j+F8KCGmM
qSeDGOLtv/C5C9AoupejPoQM5p9urQF7JQiUgVPw5zBickflWVOFaK1iZuqCNdQD
C+HEiIhNLxS36wRt95JzftDp0FEuVkiBhJJ2TlWXcanuvBcjUDUKAVlGbJaZA6BY
aCCCWd1T0PyH7V4PEsYRGWLCOHpdR6SJ5lO4vWS4c5nM34Ky4o0=
=Xwp+
-----END PGP SIGNATURE-----

--huq684BweRXVnRxX--