Date: Mon, 31 Aug 2020 20:14:29 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: gkokolatos@pm.me
Cc: pgsql-hackers@postgresql.org,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Subject: Re: v13: show extended stats target in \d
Message-ID: <20200901011429.GZ5450@telsasoft.com>
References: <20200831050047.GG5450@telsasoft.com>
 <GYVcmqRBl6yC_0td0Kwve4B1Xz3WIurebAHFB-ZLm4MKSgv6mjx4jzXVommQlmyB3-MuQ056vEL9-xpC80Lc5miilIgLmQfeWV0CLA2qaZ0=@pm.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <GYVcmqRBl6yC_0td0Kwve4B1Xz3WIurebAHFB-ZLm4MKSgv6mjx4jzXVommQlmyB3-MuQ056vEL9-xpC80Lc5miilIgLmQfeWV0CLA2qaZ0=@pm.me>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Aug 31, 2020 at 07:47:35AM +0000, gkokolatos@pm.me wrote:
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Monday, 31 August 2020 08:00, Justin Pryzby <pryzby@telsasoft.com> wrote:
> 
> > The stats target can be set since commit d06215d03, but wasn't shown by psql.
> > ALTER STATISISTICS .. SET STATISTICS n.
> >
> > Normal (1-D) stats targets are shown in \d+ table.
> > Stats objects are shown in \d (no plus).
> > Arguably, this should be shown only in "verbose" mode (\d+).
> 
> This seems rather useful. May I suggest you add it to the commitfest?

I added at
https://commitfest.postgresql.org/29/2712/

+           appendPQExpBuffer(&buf, " STATISTICS %s",

Maybe it should have a comma, like ", STATISTICS %s"?
Similar to these:

        appendPQExpBuffer(&buf, ", ON TABLE %s",
|Triggers:
|    trg1 AFTER INSERT ON trigpart3 FOR EACH ROW EXECUTE FUNCTION trigger_nothing(), ON TABLE trigpart

and:
	appendPQExpBufferStr(&buf, ", PARTITIONED");
|part_ee_ff FOR VALUES IN ('ee', 'ff'), PARTITIONED,

Also, now I wonder if CREATE STATISTICS should support some syntax to set the
initial target.  Like:

|CREATE STATISTICS abstats ON a,b FROM child.abc_202006 WITH(STATISTICS 111);

-- 
Justin