Date: Fri, 4 Sep 2020 15:37:24 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: A micro-optimisation for walkdir()
Message-ID: <20200904193724.GA7401@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+hUKG+o2FXKJUw7iNwQ33S1sv2mT6V6K21sB8+CRWtfeSNCew@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Sep-04, Thomas Munro wrote:

> @@ -10,6 +10,7 @@ struct dirent
>  {
>  	long		d_ino;
>  	unsigned short d_reclen;
> +	unsigned char d_type;
>  	unsigned short d_namlen;
>  	char		d_name[MAX_PATH];
>  };
> @@ -20,4 +21,26 @@ DIR		   *opendir(const char *);
>  struct dirent *readdir(DIR *);
>  int			closedir(DIR *);
>  
> +/* File types for 'd_type'. */
> +enum
> +  {
> +	DT_UNKNOWN = 0,
> +# define DT_UNKNOWN		DT_UNKNOWN

Uhm ... what do these #defines do?  They look a bit funny.

Would it make sense to give this enum a name, and then use that name in
struct dirent's definition, instead of unsigned char?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services