Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEIYf-0001Wx-CS for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Sep 2020 20:43:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kEIYe-00054W-9W for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Sep 2020 20:43:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEIYe-00054P-2y for pgsql-hackers@lists.postgresql.org; Fri, 04 Sep 2020 20:43:40 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kEIYb-0007hu-95 for pgsql-hackers@postgresql.org; Fri, 04 Sep 2020 20:43:39 +0000 Received: by mail-qk1-x743.google.com with SMTP id d20so7681047qka.5 for ; Fri, 04 Sep 2020 13:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=p+y4t3KTBlbUeB/R+yndgmyKoWqn8PlWOD0Ggkl3nBA=; b=tiPnRpH+rE4I8WpEm6LHAbSwGsOXOh+LzPB3jIwqiXqlY0gcEqLnu/f/w7UR4lQ1a6 M3h6NHFDvvnFwOaMGjPsJsZTk/pELtWRk2lIU4Jj+7k/bpjjhe6RI6uzS4qGgANsYU8f VBGc12T5ZN9pEBvMOX8UucpWmIcH89/foWSkqBxzGRdI5sTEK6NE7AdFlIBOAnEfEya4 SfTanTgvF2Wfd4Ob4r79m30NAvQzTm7ozpNmjL6Y30BfHWjw6NRgSzmuhcRHOYnIEaRV 1yXjWxywLhiUM8yR7QAnveiVq+8ajmTYN8RlYc/yS/g0TfuDSsgFxqLbBHmL+uXjD82T wTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=p+y4t3KTBlbUeB/R+yndgmyKoWqn8PlWOD0Ggkl3nBA=; b=Le4MZpyZThwQmgCGL/JD0/BQQLzzVE0YO53NYh7WZFKDZSmqIMFbWjIgMVchcd6C3i 4BWXGGFymXzkoElsiYQG9Fhp4P73TPqZq8zotB2BO5Uw1ConaOAQwF445HfZZR9FkJq4 j6SiHQUOd+70Tj8n5mK2euzXjpRfZXzWf9Yh/XD3GkDoVYvAayX8z/Qh2/sAjjkntaOt R5+ykDPRJWN4bjPJK1L2hxVNxWtA84JP5Q2JOrW2zRu/6G+H79NK9DvnG15uKzZICJ/v wwqHpGgiS8i42C4NL/qmO88CWG3r746zDT8lR5zrIPGGi9G3aqXZrsuOoWrmOdo6/hJB z+mQ== X-Gm-Message-State: AOAM530KdOvKXxdy4y7geXvXr4DsN+A3fDEtay3VxL94wUZvN8KeeDGw ewCw6q3jKDkjoW4Uv+cHjBGhNw== X-Google-Smtp-Source: ABdhPJwWRvx18fI+gCVaj+OOBDM/fEp/Ml1si9X55ojGv5gOtJCUkl82Xb/UiEyvqHBcyVY28LE+iA== X-Received: by 2002:a05:620a:89e:: with SMTP id b30mr10163938qka.231.1599252215954; Fri, 04 Sep 2020 13:43:35 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.19.47]) by smtp.gmail.com with ESMTPSA id x6sm5349302qke.54.2020.09.04.13.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 13:43:35 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 20A3C2A1549; Fri, 4 Sep 2020 16:43:34 -0400 (-04) Date: Fri, 4 Sep 2020 16:43:34 -0400 From: Alvaro Herrera To: Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha Cc: Thomas Munro , Tom Lane , pgsql-hackers Subject: Re: A micro-optimisation for walkdir() Message-ID: <20200904204334.GA19161@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Sep-04, Juan José Santamaría Flecha wrote: > If will fail to detect that the patch makes the optimisation available for > WIN32: > > +#if defined(DT_UNKNOWN) && defined(DT_REG) && defined(DT_DIR) && > defined(DT_LNK) Oh, I see. I suggest that it'd be better to change this line instead. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services