public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Issue with cancel_before_shmem_exit while searching to remove a particular registered exit callbacks
Date: Mon, 7 Sep 2020 16:40:57 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobSwOUTonpKUKaVLiK2XGLw4OcVn+hyffJKBNbZcJpACw@mail.gmail.com>
References: <CA+TgmoY8hrNE-sO+B95M8AD6CL9VohSMik2VZkrnkbANRDS5gw@mail.gmail.com>
<[email protected]>
<CA+TgmoYgNMc7x814iih==wH-jN-4bO_FH_xWBdV5HEK=6e3kDQ@mail.gmail.com>
<[email protected]>
<CA+TgmobBH1SGmQY6G9x4nth03bJXyg2FXEbmNqs-_aRp1peAgQ@mail.gmail.com>
<[email protected]>
<CA+Tgmoaz=e0CEOVpFTMRtanXX+0P-1uRrYtKdWktQedLtGs6Qg@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmobSwOUTonpKUKaVLiK2XGLw4OcVn+hyffJKBNbZcJpACw@mail.gmail.com>
On Mon, Aug 10, 2020 at 10:10:08PM -0400, Robert Haas wrote:
> That split dates to the parallel query work, and there are some
> comments in shmem_exit() about it; see in particular the explanation
> in the middle where it says "Call dynamic shared memory callbacks." It
> seemed to me that I needed the re-entrancy behavior that is described
> there, but for a set of callbacks that needed to run before some of
> the existing callbacks and after others.
We still have a CF entry here:
https://commitfest.postgresql.org/29/2649/
Is there still something that needs to absolutely be done here knowing
that we have bab1500 that got rid of the root issue? Can the CF entry
be marked as committed?
(FWIW, I would move any discussion about improving more stuff related
to shared memory cleanup code at proc exit into a new thread, as that
looks like a new topic.)
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (28+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Issue with cancel_before_shmem_exit while searching to remove a particular registered exit callbacks
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox