Date: Wed, 9 Sep 2020 10:43:53 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>, Erik Rijkers <er@xs4all.nl>,
	Jeff Janes <jeff.janes@gmail.com>,
	Kuntal Ghosh <kuntalghosh.2007@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: logical_work_mem and logical streaming of large
 in-progress transactions
Message-ID: <20200909084353.pncuclpbwlr7vylh@development>
References: 
 <CAA4eK1JpDd8gxf4cB6nAHOq39N7kvC=O7-b-1ghALeuipb4Y3Q@mail.gmail.com>
 <CAA4eK1+do8Fdb2q8jDCdJPZCuEzkvsv2STc9LFNCBoFOKUd5HQ@mail.gmail.com>
 <CAFiTN-sfu1S3OaZiiUXXmK_Kz4ZuhwqTz-ULxiknzEdz_3S5iQ@mail.gmail.com>
 <CAA4eK1+Myjd35YRc8Swf4b+HzgU2p5N9OPAB4a7xCsmEiVjHGw@mail.gmail.com>
 <CAA4eK1L_336h=HNeBQVqxiDUvLm3L3bt5n4dtWXrC=wCc7uRZA@mail.gmail.com>
 <CAA4eK1L+O1iFRnFa269XonbZu=o259YvGQNDrVFejW6uZspaAA@mail.gmail.com>
 <CAFiTN-sqstN07dAd7bg66tx1OgbZJqmQT0uf7B33eEnX+Vj-zA@mail.gmail.com>
 <CAA4eK1LEEhtTEnDnrWcZryOGBdhi_6X4h2MJaFgbCo5+EhRBCQ@mail.gmail.com>
 <CAFiTN-s1Mn-c7d_JD0c11JuF-GDRSJTofKr5h6=+4Ob1oJb7zg@mail.gmail.com>
 <CAA4eK1LCFVPGP21AjEBzLhSpgVHzO7ZTmpAE+a46eCLAGRgesg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="vqdsnmjotud2qiqn"
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1LCFVPGP21AjEBzLhSpgVHzO7ZTmpAE+a46eCLAGRgesg@mail.gmail.com>
Precedence: bulk


--vqdsnmjotud2qiqn
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

Hi,

while looking at the streaming code I noticed two minor issues:

1) logicalrep_read_stream_stop is never defined/called, so the prototype
in logicalproto.h is unnecessary

2) minor typo in one of the comments

Patch attached.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services 

--vqdsnmjotud2qiqn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="streaming-fixes.patch"

diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c
index c29c088813..343f03129f 100644
--- a/src/backend/replication/pgoutput/pgoutput.c
+++ b/src/backend/replication/pgoutput/pgoutput.c
@@ -77,7 +77,7 @@ static void send_relation_and_attrs(Relation relation, TransactionId xid,
  * and with streamed transactions the commit order may be different from
  * the order the transactions are sent in. Also, the (sub) transactions
  * might get aborted so we need to send the schema for each (sub) transaction
- * so that we don't loose the schema information on abort. For handling this,
+ * so that we don't lose the schema information on abort. For handling this,
  * we maintain the list of xids (streamed_txns) for those we have already sent
  * the schema.
  *
diff --git a/src/include/replication/logicalproto.h b/src/include/replication/logicalproto.h
index 53905ee608..607a728508 100644
--- a/src/include/replication/logicalproto.h
+++ b/src/include/replication/logicalproto.h
@@ -133,7 +133,6 @@ extern void logicalrep_write_stream_start(StringInfo out, TransactionId xid,
 extern TransactionId logicalrep_read_stream_start(StringInfo in,
 												  bool *first_segment);
 extern void logicalrep_write_stream_stop(StringInfo out);
-extern TransactionId logicalrep_read_stream_stop(StringInfo in);
 extern void logicalrep_write_stream_commit(StringInfo out, ReorderBufferTXN *txn,
 										   XLogRecPtr commit_lsn);
 extern TransactionId logicalrep_read_stream_commit(StringInfo out,

--vqdsnmjotud2qiqn--