Date: Thu, 10 Sep 2020 13:37:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: k.jamison@fujitsu.com, pgsql-hackers@postgresql.org
Subject: Re: please update ps display for recovery checkpoint
Message-ID: <20200910043710.GD2743@paquier.xyz>
References: <20200818225238.GP17022@telsasoft.com>
 <OSBPR01MB2341D2D3141FB3E4C97A0B4DEF5D0@OSBPR01MB2341.jpnprd01.prod.outlook.com>
 <20200820080905.GA10353@paquier.xyz>
 <20200831065244.GB6555@paquier.xyz>
 <20200910020050.GB18552@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gE7i1rD7pdK0Ng3j"
Content-Disposition: inline
In-Reply-To: <20200910020050.GB18552@telsasoft.com>
Precedence: bulk


--gE7i1rD7pdK0Ng3j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 09, 2020 at 09:00:50PM -0500, Justin Pryzby wrote:
> What would you want the checkpointer's ps to say ?
>=20
> Normally it just says:
> postgres  3468  3151  0 Aug27 ?        00:20:57 postgres: checkpointer   =
                            =20

Note that CreateCheckPoint() can also be called from the startup
process if the bgwriter has not been launched once recovery finishes.

> Or do you mean do the same thing as now, but one layer lower, like:
>
> @@ -8728,6 +8725,9 @@ CreateCheckPoint(int flags)
> +       if (flags & CHECKPOINT_END_OF_RECOVERY)
> +               set_ps_display("recovery checkpoint");

For the use-case discussed here, that would be fine.  Now the
difficult point is how much information we can actually display
without bloating ps while still have something meaningful.  Showing
all the information from LogCheckpointStart() would bloat the output a
lot for example.  So, thinking about that, my take would be to have ps
display the following at the beginning of CreateCheckpoint() and
CreateRestartPoint():
- restartpoint or checkpoint
- shutdown
- end-of-recovery

The output also needs to be cleared once the routines finish or if
there is a skip, of course.
--
Michael

--gE7i1rD7pdK0Ng3j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl9ZrXYACgkQnvQgOdby
QH2Yfw/+MTkLtOXynwWMxbcHWIYwNpuhgSQXszEl8LAeKkZgStKF2tBEJdby1OMn
qbMrDXFH6ik+YgNANau1qjiQJt9n3RcCLNtr7ecgG02ul/p/H6T3tEDnI45hthuG
yBOOH7ODYg7tcSz4r6Km1sgrSrELbBaLfwmHfWwnvxCVn4C3dO5AIUs0Fs7vAw2y
oGdm5QioFJRN/w2iYkUClTVXRSh3PaAVwECR2z7AJFnsFr03LGCobSKgE2Uw1Ir0
AkAjcO6BwbbRP8czhoMjFCa9A4P0NvMmADjxx9O/5JgY9OwYdMagfzM6It/tvAk4
JPu9j3+VNM7W5jo9SrjlvJcJ2oeDFRQ1NgSCam1tiW/jB7nZunXTxJjcBPFw/Zr7
snchfGplSz+v0PLOQ75bGx/IJvYSIwqG0g5WmTjZpajlkCQYVWF8vQE0VUI9uhR9
3lfvdCdD1diotnNaLERd3TqMaj14ObFvNiyEhB+dIHEuEipVJQh/0gkFYIBSJG8p
Ylf5+IOc5kEy6iBxRvuJNKexQNOb6k8XPAh00tfjuswT64YNCQfOBtBTHMW7WxSB
9XSRX0aZIBdvIcINtnSeOj9ub1RfC3JFSiSt9xAux1ND32xE9QTnPLugfKGj/A/v
s4WFdoSobnMBwPIbZNp34FzaFnQKmX1PCaXNjKiJXflcBu6mPO8=
=igXy
-----END PGP SIGNATURE-----

--gE7i1rD7pdK0Ng3j--