Date: Wed, 16 Sep 2020 19:46:14 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Gripes about walsender command processing
Message-ID: <20200916224614.GA25522@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <39194.1600294868@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Sep-16, Tom Lane wrote:

> Yeah, that works for me.  It doesn't allow for having just one
> set_ps_display() call ahead of the switch, but that isn't that
> big a loss.  We cannot merge the EndReplicationCommand calls to
> after the switch, because some of the cases don't want one here;
> so that partial duplication is inescapable.

Right.

> Note that your changes need to be backpatched into v13,
> because AFAICS this code is violating the FE/BE protocol
> right now --- it's just luck that libpq isn't moaning
> about extra CommandComplete messages.  But I don't think
> we want to change the ps title behavior in v13 at this
> late date, so that part should be HEAD-only.

Ok, will do.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services