Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIhOo-0002b6-E4 for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 00:03:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kIhOn-0005ij-BB for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 00:03:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIhOn-0005hK-0T for pgsql-hackers@lists.postgresql.org; Thu, 17 Sep 2020 00:03:41 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kIhOk-0002tN-Nn for pgsql-hackers@postgresql.org; Thu, 17 Sep 2020 00:03:40 +0000 Received: by mail-qk1-x742.google.com with SMTP id w186so463999qkd.1 for ; Wed, 16 Sep 2020 17:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=oeHKzDZpukfeFUncXr0Z1n1TuI0kFpCQkRttBKzvF2o=; b=RpH/9MkCCe/kcs4LqWRB12BSp/QhnJgmCGlguLV0Qb4MEuayDCrMgSMfhQm1VaZ9P3 SwAafGmfHRpGQN0ZTcqlnw0u0lMPNcmOqQGyy+crKjKnhE8rx2Ti5uQWc5LC9sePsfiF vv0Nj6I/EtGHPH30tqP4VgGepGdaJG96QDSowq12rwWG64d80zzTXUc2w/P4sr04QZOP jhPzG0CrhMojJ11fuK27QUHaIxlEAzHFw/KXKjw9siFN2p2USky5NGTbjljoe8nH3ZFQ Jx8p+HSrp9Xot5QHpqWJD4INnk3ppyeoVo2BRkC30cR/fBu+XY/4hFBVtK1mNph/mglw hUUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oeHKzDZpukfeFUncXr0Z1n1TuI0kFpCQkRttBKzvF2o=; b=mP86CsmD15zfZyO4AKbEaKh42XfbjqPgyUwLhZMlfUWav8UuhlJJM7EYrNYzqr28RP qm9qqxhdX5Lij2LKmZiU6SlFWEwgnQLQKh45O9OnssOM19+U/mM4yBf7WQGnVtMVqIi+ QRAQKFUvp+hd1TCw6WkA9ez1xrO9KYSvUGToT34mfxVqs6QLpwXBfPvbQpgLBZ3UaGdC Js72MCDlf4Ss0YF3VEUqi6dixp+Jgh0n7bt0hBCcbNg6OOlYn2f/Gb00o0ywmqzq+NY+ T5JKpAWtxXMQBk9czPlQmBtI2G6/O8z0OP3BH6vdvxB48ISrfbVGZhxNF8oJ0A9vr0Rn wTWQ== X-Gm-Message-State: AOAM533bTDdPEs/IWyPSiWLoVzWwiDctCrM8BlS/iPpuWOi3/FlgwAcG Ig8ki6iVQTvQ8HSvtMLsuMRcpg== X-Google-Smtp-Source: ABdhPJzhwNIiJMHps2d3RmmjzNRdp7sPvcJkHVpLtLCt42tFxODake/QdT+t6ORCHc9C1tJJH9yV2w== X-Received: by 2002:ae9:e814:: with SMTP id a20mr25848048qkg.429.1600301016541; Wed, 16 Sep 2020 17:03:36 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.19.47]) by smtp.gmail.com with ESMTPSA id e24sm20251060qka.76.2020.09.16.17.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 17:03:36 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 095E32A1565; Wed, 16 Sep 2020 21:03:34 -0300 (-03) Date: Wed, 16 Sep 2020 21:03:34 -0300 From: Alvaro Herrera To: Tom Lane Cc: Daniel Gustafsson , Peter Eisentraut , pgsql-hackers Subject: Re: pgindent vs dtrace on macos Message-ID: <20200917000334.GA28142@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <43461.1600300517@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Sep-16, Tom Lane wrote: > Daniel Gustafsson writes: > > Not sure what pgindent is doing there, but it seems hard to address in the > > generator. > > I think the issue is that pgindent believes "numeric" and "chr" are > typedefs. (The regex code can be blamed for "chr", but I'm not quite > sure where "numeric" is coming from.) It's in src/interfaces/ecpg/include/pgtypes_numeric.h -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services