Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIheA-0003Iz-5D for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 00:19:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kIhe9-0006Ze-27 for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 00:19:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIhe8-0006ZV-RW for pgsql-hackers@lists.postgresql.org; Thu, 17 Sep 2020 00:19:32 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kIhe6-00031B-Ie for pgsql-hackers@lists.postgresql.org; Thu, 17 Sep 2020 00:19:31 +0000 Received: by mail-qk1-x729.google.com with SMTP id 16so480656qkf.4 for ; Wed, 16 Sep 2020 17:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=HaKOv2zMIbQcNwMJaKLLMa2WcSup5F5WILCLY9niunI=; b=yiClsmvPZr/Fx9jidx4x4/UAJH+aO5gNtTYDuj3sKIHGj069x2cFkCGL3FYub5BKPt wAKpBhyoOmJAf7MWw2G/hwWxeX/jPVBnl/46me3sTNDQjB+wwXmq0Kpxp4yBmK8KAI74 mVc5vz6LVlJ3yXW/iB+gBFJ63U/uE09jatlaZtZMQ8UHEYt838VeGq8q2Bx3l1F+OUTR PpXMiQWJEepChqtFucIK8GlfD/vOlGEytT1jb+QOJ0RxXf8GtP1TyRnPTiEnrup3ka+b KN/dhjnqx62nKI6fwOsLxrlJzgnuW2EsFSJJd0FAdFqzvGdcl6iN6iZRKmrFR442WIfI VM7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HaKOv2zMIbQcNwMJaKLLMa2WcSup5F5WILCLY9niunI=; b=Hd9tNHNiTcUj+tU7hMsbhHnqCQzgmuMdWeevHeif7xRb9LSlRVM+etY5aQXArOM9Mt lp+N9ImCo6rkUL8ZOz9nn2qsKsnaxYqTL3iBfB5hjtEHqP9beemVmsMN+Bk+YaS+4MrB MJ4JOHHkDzhGrbv7bDU09/P1A0s5wlg3XrRK5sPm9KFWnFFk7QmLduQhpGO3RdzViXcG Yzy8LyvaofWqdDJBYExdyQG6A7hCqrVaLWnbZsKtRiUzL3AGRoTW9Mr24T88JOSZ988e O8v635r3U8NId8wl2fisJasVgkF7LOBYWtjGOixajWEJjQM4IEBH488wXw1vukYSjOYt Z7rQ== X-Gm-Message-State: AOAM530L8ts7EcxxvzVilET9KabGzy7Gqi0u5M3krJFDHXuYFqJnHsZa baz6JftxBeal2Bv0VxNNZWwDrdDdTdnDAXgXImTkfO8biKQrMm4vjvEnk5XxPAgrlpzw1Wsxmlx 3KQmptdq9clKJtumnnBpclBFtagP3j5iRHV/XIYKxaKi+C6VFxnQeX+kOKssMyZ6v6xiE3375L5 u1lN+vXs7+9+Fbm9L9 X-Google-Smtp-Source: ABdhPJzlU9opodWJDpZUtpV0UNl1C0Dz3/2Ik1t9Sd84Qaeag21oL05bTfQUreIFt8K/HZtbPokvGQ== X-Received: by 2002:ae9:eb57:: with SMTP id b84mr26151765qkg.450.1600301969133; Wed, 16 Sep 2020 17:19:29 -0700 (PDT) Received: from perhan.alvh.no-ip.org ([190.95.19.47]) by smtp.gmail.com with ESMTPSA id f33sm20049397qtb.45.2020.09.16.17.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 17:19:28 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id C9FC42A1565; Wed, 16 Sep 2020 21:19:26 -0300 (-03) Date: Wed, 16 Sep 2020 21:19:26 -0300 From: Alvaro Herrera To: Tom Lane Cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: Gripes about walsender command processing Message-ID: <20200917001926.GA28698@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <39194.1600294868@sss.pgh.pa.us> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Sep-16, Tom Lane wrote: > Note that your changes need to be backpatched into v13, > because AFAICS this code is violating the FE/BE protocol > right now --- it's just luck that libpq isn't moaning > about extra CommandComplete messages. But I don't think > we want to change the ps title behavior in v13 at this > late date, so that part should be HEAD-only. I pushed to 13, but it's because of the removal of the command tag; the duplicate tags we've been sending since 9.3. ¯\_(ツ)_/¯ -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services