Date: Thu, 1 Oct 2020 12:50:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Message-ID: <20201001035039.GD8130@paquier.xyz>
References: 
 <CA+HiwqEJLdJkyxg4RP9YS3eBzxHJ9kzdUnmqrA=9tL19qM7wXg@mail.gmail.com>
 <20200923152321.GA26342@alvherre.pgsql>
 <CA+HiwqEo8wrQU6KOCE5xCph-B_=njuP0XMpdYiSfjYPByrtF3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="g7w8+K/95kPelPD2"
Content-Disposition: inline
In-Reply-To: 
 <CA+HiwqEo8wrQU6KOCE5xCph-B_=njuP0XMpdYiSfjYPByrtF3Q@mail.gmail.com>
Precedence: bulk


--g7w8+K/95kPelPD2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 24, 2020 at 12:51:52PM +0900, Amit Langote wrote:
> Also, I noticed that looking up a parent's partitions via
> RelationBuildPartitionDesc or directly will inspect inhdetached to
> include or exclude partitions, but checking if a child table is a
> partition of a given parent table via get_partition_parent doesn't.
> Now if you fix get_partition_parent() to also take into account
> inhdetached, for example, to return InvalidOid if true, then the
> callers would need to not consider the child table a valid partition.
> So, RelationGetPartitionQual() on a detached partition should actually
> return NIL, making my earlier claim about not needing the defensive
> CHECK constraint invalid.  But maybe that's fine if all places agree
> on a detached partition not being a valid partition anymore?

It would be good to get that answered, and while on it please note
that the patch needs a rebase.
--
Michael

--g7w8+K/95kPelPD2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl91Ug8ACgkQnvQgOdby
QH35ZQ/+KyWG25qzByy3wF411Xq/p7CkJm+4IWH3pPcPl1Vxn4dL4I2W1kOsuMUm
OKHwIwxRBEJ9aqHDZsEhHTJg7FRzmGTZZtkIiDEPNzY+vScnIHqPFtRmCCP8bbb6
UxpoN8I0SphC9g6vcqkHjZz4jDtwOzABPXZ7Yot0XU9oAoUrhhoejGvp8KaC74I6
d0S6IjVUc9JAGFtN8Ouz5YYyFOW5Ty74PlJ2UwDSLkPZ1hsRTFcb0A70d6uEqQKy
5pL7ahk1/HXqwNK+MZuIET41oO45L3yQiXVBUGXsFDAieQM50NdAcH44CuMDDCey
Nuz8F4JfGtsTPFbYZgmxnWV8679aU6KWKogAwXcv+Z92acCljx6YhmYyKQJGbSEn
VMFmKYIqesw2moEv5xuB1jBs3uj7mUCCjz4owuEtsfN0QTGXZegBUoED0VU8U1aD
ATpQfFm7yvRRqcvjAHnjuF8hm117LGDL1bLdkQdpeAQZnyxpb0NM1CV1997TagOt
3DODUaqAk3fjZNwwKeUVUFYssQhLmpbeWfAjIoQa+hIAfeJNomMM8kPiTbcDKtQB
+IVINgA6YFfiBCM88YIr/jh+C8YSueFzWymfhtdHbGv/WsGjyc6yPrZZwoGtlWWg
wAgKX6uJwjqbiicj4adGdWQRAzAXby0y5lBvzBq6lHWChibSgL0=
=KYIH
-----END PGP SIGNATURE-----

--g7w8+K/95kPelPD2--