Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP4jZ-0006Nk-Fw for pgsql-hackers@arkaria.postgresql.org; Sun, 04 Oct 2020 14:11:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kP4j0-0003J5-Nz for pgsql-hackers@arkaria.postgresql.org; Sun, 04 Oct 2020 14:10:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP4iz-0003Iy-Nt for pgsql-hackers@lists.postgresql.org; Sun, 04 Oct 2020 14:10:54 +0000 Received: from [64.147.123.19] (helo=wout3-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP4iv-0001Tl-Hg for pgsql-hackers@postgresql.org; Sun, 04 Oct 2020 14:10:52 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id F06D64F3; Sun, 4 Oct 2020 10:10:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 04 Oct 2020 10:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KZNDjOpIdHh+vszzw DWyoC07fxjYgF0j9UPGKDNafP4=; b=ggfQ9dhCU3G+8Veu4A7f91Sz8XbIrxcDG /OdfYe0Z2FQrxbUEja1pTkjGSp2u1OOpHyDRMzcTNtgqxLJ4ACfUU+O4naxr2be7 7adEFLBDdCyHP8PHY6RICo6adOHLXwxb30RwpZ3YY43Xn55Nqu5oOqQXdDs0mnrd LtM4g7k8X563FZgZdgoCL5ReQLKfBKGRpk/7hfAciCWvNeDrvIMYMsCisItPZwxn hVbuRxxBgOC+R4ZZz08kfTDolcUrH/E61bDdIPTsS3GkiMCR33R8dAzRY0GXR9QO /st8oiDrppB/uG1jtDEYniI3AEdHHwbOqEm+grE5fhjpmGjkvgN8w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgedtgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtuggjfgesthdtredttdervdenucfhrhhomheptehlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqne cuggftrfgrthhtvghrnhepvefgleevgeeujeeghfegteeghfegheeifeehheelteetiedu ieeihffggfehffetnecukfhppeduledtrdelhedrudelrddugeeknecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhv hhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.148]) by mail.messagingengine.com (Postfix) with ESMTPA id C7174306467D; Sun, 4 Oct 2020 10:10:36 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 703412A0BE7; Sun, 4 Oct 2020 11:10:34 -0300 (-03) Date: Sun, 4 Oct 2020 11:10:34 -0300 From: Alvaro Herrera To: "Drouvot, Bertrand" Cc: Masahiko Sawada , PostgreSQL-development Subject: Re: Add Information during standby recovery conflicts Message-ID: <20201004141034.GA6361@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29da248a-e21c-a3eb-a051-f1ec79b13d31@amazon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Host-Lookup-Failed: Reverse DNS lookup failed for 64.147.123.19 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > +extern const char *get_procsignal_reason_desc(ProcSignalReason reason) > + { > + const char *reasonDesc = "unknown reason"; > + > + switch (reason) > + { > + case PROCSIG_RECOVERY_CONFLICT_BUFFERPIN: > + reasonDesc = "buffer pin"; > + break; It doesn't work to construct sentences from pieces, for translatability reasons. Maybe you can return the whole errmsg sentence from this routine instead.