Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPfvL-000494-Ny for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Oct 2020 05:54:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kPfvK-00040L-Lw for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Oct 2020 05:54:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPfvI-00040E-SS for pgsql-hackers@lists.postgresql.org; Tue, 06 Oct 2020 05:54:06 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPfvG-0003Vo-8y for pgsql-hackers@postgresql.org; Tue, 06 Oct 2020 05:54:03 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 17B47D42; Tue, 6 Oct 2020 01:54:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Oct 2020 01:54:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=jdMBSv+elAYvntQdd28Y47niq5q TUJspxy4XGh3ASag=; b=mVorc00340TeZwvBuALnttU8ZZejU3EvGLz8D3Xnd15 aBhTLbAdfas9R89F8AZioGo0ylE2mXOFIIN5hI1kaNQb5FTPYG+O69OT9mIXUqlb wLVSHCPz2UtPtFHKsFHzkgS4g2PpF6YqaTXcGrroUjYmYhlxyOXc8MpS5auO2+9F FZ5tSJQvJuUmb/VyucVyFftdGRGK05ZVb8SOrwZtAhqzWD0kZKxgb7ZSXKnkQ+eW 1xaUFBJ6RHPXmg1WN+Qss5RxgFKfLu6CR+2JrQKRnMHMscOTvjOrrBs7ltRRFe9l bkmfwJdI+vcUKBcYv+VFHUDGWdgqyuOcNik28QZ3r3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jdMBSv +elAYvntQdd28Y47niq5qTUJspxy4XGh3ASag=; b=ia2yputCJUsV8efYHDHsiT 96teRWCPuBanSHucmrCGMEhDH7mlLQjHWg9D5ZzpVgL4MubZO/5cAHz5w7yjgHpe nu8xhqxkEv2sxYhGK4ZZpgfcIyAihHUsqi4ByfwM1x3YqhyxIwJROXjWpyl+GfnX hAdQ0dKxeOZYHmK7giO0Fbi+6jkLkhZ0x1QQRKaTe5mjsDqyRr1ATaBRB8gZzk4E CILvZpijKmEtW9BXhklfKHngYk1kBPKXgqkoZbGww3VHKNvpcoJVQ1HH0D33TXkx w04SRXBf1YoXNey7shQnmAWlLrQYBw97s0xa7jhmSBoVGfYUjbG8BEtsq2N3ZbnQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeefgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucfkphepuddukedrvdeguddrvdehud drvddttdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (mp76f1fbc8.ap.nuro.jp [118.241.251.200]) by mail.messagingengine.com (Postfix) with ESMTPA id F3322306467E; Tue, 6 Oct 2020 01:53:57 -0400 (EDT) Date: Tue, 6 Oct 2020 14:53:55 +0900 From: Michael Paquier To: Fujii Masao Cc: Bharath Rupireddy , PostgreSQL-development Subject: Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module Message-ID: <20201006055355.GB429@paquier.xyz> References: <13156732-5189-af54-3d28-e2ee2a8568e0@oss.nttdata.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K8nIJk4ghYZn606h" Content-Disposition: inline In-Reply-To: <13156732-5189-af54-3d28-e2ee2a8568e0@oss.nttdata.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 05, 2020 at 11:34:05PM +0900, Fujii Masao wrote: > ISTM that we can also replace StartupProcSigHupHandler() in startup.c > with SignalHandlerForConfigReload() by making the startup process use > the general shared latch instead of its own one. POC patch attached. > Thought? That looks good to me. Nice cleanup. > Probably we can also replace sigHupHandler() in syslogger.c with > SignalHandlerForConfigReload()? This would be separate patch, though. +1. -- Michael --K8nIJk4ghYZn606h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl98BnMACgkQnvQgOdby QH2wdQ//c6SF1LZs3EpdeWdenbmnpApdOCpgdF5nfX4FaBiD6SQrqwGUxGwbDs36 hdVmBmoliHXnLAYNEcyVbXNNI5EaIuQ5e3UDyZbWkUTy8U3tFG8mkK6QLS67kVoY l/XeSRiZCiUeiBpRGNRk4dHGfMDJkZ7z392ZoPbwQAkmn0SL1I6dp3QUqxCVdPI8 dwX1X0PAlnf7/UQqdLBXgfgjyuzpvJ6Exfb2mUT4hhWaznlYM77qCwStj5hiWV/u +uGxBYAjYyU7QeOMPCggsE9s6df2JIdZqSERWN9WeGf60JtXY84gK0yEyBSIzE9j aHxSbjwGYDC72BV9ZrG54AqqiJprPhiuGSNY7Y2ccwkpm7wH3PqiIaCf4wRZUo/+ Cql6baOj5LFus7/FIL9eNw0kPhcW9HpW5qREm2m5QVXC0TOjHsCthBzK3g99k7Ue drPvsxrt8Nm9Htan2pF9Yh10X4DzARNYNAxUS8ELHeupPqyuK+fJTOGYylR5kBVc mG4pG/XOkNkd7V7RpZzBR6n0JkRgZfUDwRG+WUVnnzhToU7D6Nq6j5boikZmvu+U YK51pRzxO7zpoH9PI8uQ/6e12Lem3WMzp/I99sclMsfDzWtSudNNtPLW0chH8Ls8 fhKg8GODfxCvvYPcNBTQZxhQKu0zK8QNYyFTQIREgNIFK9nchzE= =VqH3 -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--