Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQnGe-00016X-QA for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Oct 2020 07:56:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kQnGd-0004el-PY for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Oct 2020 07:56:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQl9v-0004IZ-4x for pgsql-hackers@lists.postgresql.org; Fri, 09 Oct 2020 05:41:39 +0000 Received: from sender4-op-o13.zoho.com ([136.143.188.13]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQl9p-00049J-Ud for pgsql-hackers@postgresql.org; Fri, 09 Oct 2020 05:41:38 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1602222090; cv=none; d=zohomail.com; s=zohoarc; b=cr3ZzXq9k17MB/CaokRAmWbTTRcEW/mvz9B8Tyg5p3Qi0I8q7g+1fi0wJKAcMhE0f8noN6ChsCDe20EHCl7KELmGfzkhYq3xoAN7FM1QB7AOaFc8TDEkud8vXG+2h49YkgNdByOIpZ5YoLAGLp+vnMKHJYrZIMOt3L5xfiWgJL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602222090; h=Content-Type:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=yy52MYjplKyfEnYcosSSGPTCcy/9Vrj0jzy7JzHh3pM=; b=PvU/GB7ZNIDgI5wikTFB8Ffrv73fydg4xP22CyVMjaR3s8a74yXlI0YBUWmsEYVX0J3qVOZpX520iwZuJJhv1dq9yOC/NVsE/3Qh0Cv/yvwQUwYqko2O0rVm8xCKgYTi9eIQmFrASAckMl/2zQ/x/pi8rmg4LJRHqw6OJd8bcHU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=highgo.ca; spf=pass smtp.mailfrom=movead.li@highgo.ca; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1602222090; s=zoho; d=highgo.ca; i=movead.li@highgo.ca; h=Date:From:To:Cc:Subject:Mime-Version:Message-ID:Content-Type; bh=yy52MYjplKyfEnYcosSSGPTCcy/9Vrj0jzy7JzHh3pM=; b=ADkUrNB6dVqdx6KLKE7/uiPXJjqyjtlDzq/0uVv9kC5tZhiwcE9uoo3zCpXhKzCA miVtkuJhZaNrXa0xdmCGkFQhDTD32d7ndJu08Pe/MEdEAjV2UgJfKn4mAtpD60HLj64 Muu5eRUdQW93tnCGZVjSyngkGEqTWAde+Ylq1adY= Received: from lchch (124.133.18.218 [124.133.18.218]) by mx.zohomail.com with SMTPS id 1602222087437574.9437607133137; Thu, 8 Oct 2020 22:41:27 -0700 (PDT) Date: Fri, 9 Oct 2020 13:41:25 +0800 From: "movead.li@highgo.ca" To: pgsql-hackers Cc: ahsan.hadi Subject: Wrong statistics for size of XLOG_SWITCH during pg_waldump. X-Priority: 3 X-GUID: B48848FB-4243-468E-98DF-915E4FCF8110 X-Has-Attach: yes X-Mailer: Foxmail 7.2.16.188[cn] Mime-Version: 1.0 Message-ID: <2020100913412132258847@highgo.ca> Content-Type: multipart/mixed; boundary="----=_001_NextPart871207167800_=----" X-Zoho-Virus-Status: 1 X-ZohoMailClient: External List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. ------=_001_NextPart871207167800_=---- Content-Type: multipart/alternative; boundary="----=_002_NextPart642424345134_=----" ------=_002_NextPart642424345134_=---- Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: base64 SGVsbG8gaGFja2VycywNCg0KV2Uga25vdyB0aGF0IHBnX3dhbGR1bXAgY2FuIHN0YXRpc3RpY3Mg c2l6ZSBmb3IgZXZlcnkga2luZCBvZiByZWNvcmRzLiBXaGVuIEkgdXNlDQp0aGUgZmVhdHVyZSBJ IGZpbmQgaXQgbWlzc2VzIHNvbWUgc2l6ZSBmb3IgWExPR19TV0lUQ0ggcmVjb3Jkcy4gV2hlbiBh IHVzZXIgZG9lcw0KYSBwZ193YWxfc3dpdGNoKCksIHRoZW4gcG9zdGdyZXMgd2lsbCBkaXNjYXJk IHRoZSByZW1haW5pbmcgc2l6ZSBpbiB0aGUgY3VycmVudCB3YWwNCnNlZ21lbnQsIGFuZCB0aGUg cGdfd2FsZHVtcCB0b29sIG1pc3NlcyB0aGUgZGlzY2FyZCBzaXplLg0KDQpJIHRoaW5rIGl0IHdp bGwgYmUgYmV0dGVyIGlmIHBnX3dhbGR1bXAgIGNhbiBzaG93IHRoZSBtYXR0ZXIsIHNvIEkgbWFr ZSBhIHBhdGNoDQp3aGljaCByZWdhcmRzIHRoZSBkaXNjYXJkIHNpemUgYXMgYSBwYXJ0IG9mIFhM T0dfU1dJVENIIHJlY29yZCwgaXQgd29ya3MgaWYgd2UNCndhbnQgdG8gZGlzcGxheSB0aGUgZGV0 YWlsIG9mIHdhbCByZWNvcmRzIG9yIHRoZSBzdGF0aXN0aWNzLCBhbmQgcGF0Y2ggYXR0YWNoZWQu DQoNCldoYXQncyB5b3VyIG9waW5pb24/DQoNCg0KDQpSZWdhcmRzLA0KSGlnaGdvIFNvZnR3YXJl IChDYW5hZGEvQ2hpbmEvUGFraXN0YW4pIA0KVVJMIDogd3d3LmhpZ2hnby5jYSANCkVNQUlMOiBt YWlsdG86bW92ZWFkKGRvdClsaShhdCloaWdoZ28oZG90KWNhDQo= ------=_002_NextPart642424345134_=---- Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable =0A
Hello hackers,

We know that pg_waldump can statistics size for every kind of= records. When I use
the feature I find it misses some size for = XLOG_SWITCH records. When a user does
a pg_wal_sw= itch(), then postgres will discard the remaining size in the current wal
segment, and the pg_waldump tool misses the discard size.
I think it will be better if pg_waldump  can sh= ow the matter, so I make a patch
which regards the discard size as a part of XLOG_SW= ITCH record, it works if we
want to display the detail of wal records or the = statistics, and patch attached.

What's you= r opinion?

=0A
Regards,
Highgo Software (Canada= /China/Pakistan)
<= span style=3D"color: rgb(13, 10, 11); font-family: monospace, monospace; f= ont-size: 10.7333px; font-variant-ligatures: normal; orphans: 2; white-spa= ce: pre-wrap; widows: 2;">URL : www.hig= hgo.ca
EMAIL: mailto:movead(dot)li= (at)highgo(dot)ca
=0A ------=_002_NextPart642424345134_=------ ------=_001_NextPart871207167800_=---- Content-Type: application/octet-stream; name="fix_waldump_size_for_wal_switch.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fix_waldump_size_for_wal_switch.patch" ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfd2FsZHVtcC9wZ193YWxkdW1wLmMgYi9zcmMvYmluL3Bn X3dhbGR1bXAvcGdfd2FsZHVtcC5jCmluZGV4IDMxZTk5YzJhNmQuLjAxMTYwNmVjZjIgMTAwNjQ0 Ci0tLSBhL3NyYy9iaW4vcGdfd2FsZHVtcC9wZ193YWxkdW1wLmMKKysrIGIvc3JjL2Jpbi9wZ193 YWxkdW1wL3BnX3dhbGR1bXAuYwpAQCAtMjQsNiArMjQsNyBAQAogI2luY2x1ZGUgImNvbW1vbi9s b2dnaW5nLmgiCiAjaW5jbHVkZSAiZ2V0b3B0X2xvbmcuaCIKICNpbmNsdWRlICJybWdyZGVzYy5o IgorI2luY2x1ZGUgImNhdGFsb2cvcGdfY29udHJvbC5oIgogCiBzdGF0aWMgY29uc3QgY2hhciAq cHJvZ25hbWU7CiAKQEAgLTM4MCw5ICszODEsMTEgQEAgV0FMRHVtcFJlYWRQYWdlKFhMb2dSZWFk ZXJTdGF0ZSAqc3RhdGUsIFhMb2dSZWNQdHIgdGFyZ2V0UGFnZVB0ciwgaW50IHJlcUxlbiwKICAq IENhbGN1bGF0ZSB0aGUgc2l6ZSBvZiBhIHJlY29yZCwgc3BsaXQgaW50byAhRlBJIGFuZCBGUEkg cGFydHMuCiAgKi8KIHN0YXRpYyB2b2lkCi1YTG9nRHVtcFJlY29yZExlbihYTG9nUmVhZGVyU3Rh dGUgKnJlY29yZCwgdWludDMyICpyZWNfbGVuLCB1aW50MzIgKmZwaV9sZW4pCitYTG9nRHVtcFJl Y29yZExlbihYTG9nUmVhZGVyU3RhdGUgKnJlY29yZCwgdWludDMyICpyZWNfbGVuLCB1aW50MzIg KmZwaV9sZW4sIHVpbnQzMiAqanVua19sZW4pCiB7CiAJaW50CQkJYmxvY2tfaWQ7CisJUm1ncklk CQlybWlkOworCXVpbnQ4CQlpbmZvOwogCiAJLyoKIAkgKiBDYWxjdWxhdGUgdGhlIGFtb3VudCBv ZiBGUEkgZGF0YSBpbiB0aGUgcmVjb3JkLgpAQCAtNDAzLDYgKzQwNiwzMSBAQCBYTG9nRHVtcFJl Y29yZExlbihYTG9nUmVhZGVyU3RhdGUgKnJlY29yZCwgdWludDMyICpyZWNfbGVuLCB1aW50MzIg KmZwaV9sZW4pCiAJICogYWxsIHRoZSBibG9jayBpbWFnZXMuCiAJICovCiAJKnJlY19sZW4gPSBY TG9nUmVjR2V0VG90YWxMZW4ocmVjb3JkKSAtICpmcGlfbGVuOworCisJcm1pZCA9IFhMb2dSZWNH ZXRSbWlkKHJlY29yZCk7CisJaW5mbyA9IFhMb2dSZWNHZXRJbmZvKHJlY29yZCkgJiB+WExSX0lO Rk9fTUFTSzsKKworCS8qCisJICogSWYgaXQncyBhIHdhbCBzd2l0Y2ggcmVjb3JkLCB3ZSBzaG91 bGQgY2FjdWxhdGUgdGhlIGp1bmsgc2l6ZSB3aGljaCBza2lwcGVkCisJICogYnkgdGhpcyByZWNv cmQuCisJICovCisJKmp1bmtfbGVuID0gMDsKKwlpZihSTV9YTE9HX0lEID09IHJtaWQgJiYgWExP R19TV0lUQ0ggPT0gaW5mbykKKwl7CisJCVhMb2dTZWdObwlzdGFydFNlZ05vOworCQlYTG9nU2Vn Tm8JZW5kU2VnTm87CisKKwkJWExCeXRlVG9TZWcocmVjb3JkLT5SZWFkUmVjUHRyLCBzdGFydFNl Z05vLCByZWNvcmQtPnNlZ2N4dC53c19zZWdzaXplKTsKKwkJWExCeXRlVG9TZWcocmVjb3JkLT5F bmRSZWNQdHIsIGVuZFNlZ05vLCByZWNvcmQtPnNlZ2N4dC53c19zZWdzaXplKTsKKworCQkqanVu a19sZW4gPSByZWNvcmQtPkVuZFJlY1B0ciAtIHJlY29yZC0+UmVhZFJlY1B0ciAtIFhMb2dSZWNH ZXRUb3RhbExlbihyZWNvcmQpOworCQkvKgorCQkgKiBJZiB0aGUgd2FsIHN3aXRjaCByZWNvcmQg c3ByZWFkIG9uIHR3byBzZWdtZW50cywgd2Ugc2hvdWxkIGV4dHJhIG1pbnVzIHRoZQorCQkgKiBs b25nIHBhZ2UgaGVhZC4KKwkJICovCisJCWlmKHN0YXJ0U2VnTm8gIT0gZW5kU2VnTm8pCisJCQkq anVua19sZW4gLT0gU2l6ZU9mWExvZ0xvbmdQSEQ7CisJfQogfQogCiAvKgpAQCAtNDE2LDEyICs0 NDQsMTQgQEAgWExvZ0R1bXBDb3VudFJlY29yZChYTG9nRHVtcENvbmZpZyAqY29uZmlnLCBYTG9n RHVtcFN0YXRzICpzdGF0cywKIAl1aW50OAkJcmVjaWQ7CiAJdWludDMyCQlyZWNfbGVuOwogCXVp bnQzMgkJZnBpX2xlbjsKKwl1aW50MzIJCWp1bmtfbGVuOwogCiAJc3RhdHMtPmNvdW50Kys7CiAK IAlybWlkID0gWExvZ1JlY0dldFJtaWQocmVjb3JkKTsKIAotCVhMb2dEdW1wUmVjb3JkTGVuKHJl Y29yZCwgJnJlY19sZW4sICZmcGlfbGVuKTsKKwlYTG9nRHVtcFJlY29yZExlbihyZWNvcmQsICZy ZWNfbGVuLCAmZnBpX2xlbiwgJmp1bmtfbGVuKTsKKwlyZWNfbGVuICs9IGp1bmtfbGVuOwogCiAJ LyogVXBkYXRlIHBlci1ybWdyIHN0YXRpc3RpY3MgKi8KIApAQCAtNDM1LDkgKzQ2NSw3IEBAIFhM b2dEdW1wQ291bnRSZWNvcmQoWExvZ0R1bXBDb25maWcgKmNvbmZpZywgWExvZ0R1bXBTdGF0cyAq c3RhdHMsCiAJICogYXJlIHRoZSBybWdyJ3MgZG9tYWluIChyZXN1bHRpbmcgaW4gc2l4dGVlbiBw b3NzaWJsZSBlbnRyaWVzIHBlcgogCSAqIFJtZ3JJZCkuCiAJICovCi0KIAlyZWNpZCA9IFhMb2dS ZWNHZXRJbmZvKHJlY29yZCkgPj4gNDsKLQogCXN0YXRzLT5yZWNvcmRfc3RhdHNbcm1pZF1bcmVj aWRdLmNvdW50Kys7CiAJc3RhdHMtPnJlY29yZF9zdGF0c1tybWlkXVtyZWNpZF0ucmVjX2xlbiAr PSByZWNfbGVuOwogCXN0YXRzLT5yZWNvcmRfc3RhdHNbcm1pZF1bcmVjaWRdLmZwaV9sZW4gKz0g ZnBpX2xlbjsKQEAgLTQ1Myw2ICs0ODEsNyBAQCBYTG9nRHVtcERpc3BsYXlSZWNvcmQoWExvZ0R1 bXBDb25maWcgKmNvbmZpZywgWExvZ1JlYWRlclN0YXRlICpyZWNvcmQpCiAJY29uc3QgUm1nckRl c2NEYXRhICpkZXNjID0gJlJtZ3JEZXNjVGFibGVbWExvZ1JlY0dldFJtaWQocmVjb3JkKV07CiAJ dWludDMyCQlyZWNfbGVuOwogCXVpbnQzMgkJZnBpX2xlbjsKKwl1aW50MzIJCWp1bmtfbGVuOwog CVJlbEZpbGVOb2RlIHJub2RlOwogCUZvcmtOdW1iZXIJZm9ya251bTsKIAlCbG9ja051bWJlciBi bGs7CkBAIC00NjEsMTEgKzQ5MCwxMSBAQCBYTG9nRHVtcERpc3BsYXlSZWNvcmQoWExvZ0R1bXBD b25maWcgKmNvbmZpZywgWExvZ1JlYWRlclN0YXRlICpyZWNvcmQpCiAJWExvZ1JlY1B0cgl4bF9w cmV2ID0gWExvZ1JlY0dldFByZXYocmVjb3JkKTsKIAlTdHJpbmdJbmZvRGF0YSBzOwogCi0JWExv Z0R1bXBSZWNvcmRMZW4ocmVjb3JkLCAmcmVjX2xlbiwgJmZwaV9sZW4pOworCVhMb2dEdW1wUmVj b3JkTGVuKHJlY29yZCwgJnJlY19sZW4sICZmcGlfbGVuLCAmanVua19sZW4pOwogCiAJcHJpbnRm KCJybWdyOiAlLTExcyBsZW4gKHJlYy90b3QpOiAlNnUvJTZ1LCB0eDogJTEwdSwgbHNuOiAlWC8l MDhYLCBwcmV2ICVYLyUwOFgsICIsCiAJCSAgIGRlc2MtPnJtX25hbWUsCi0JCSAgIHJlY19sZW4s IFhMb2dSZWNHZXRUb3RhbExlbihyZWNvcmQpLAorCQkgICByZWNfbGVuLCBYTG9nUmVjR2V0VG90 YWxMZW4ocmVjb3JkKSArIGp1bmtfbGVuLAogCQkgICBYTG9nUmVjR2V0WGlkKHJlY29yZCksCiAJ CSAgICh1aW50MzIpIChyZWNvcmQtPlJlYWRSZWNQdHIgPj4gMzIpLCAodWludDMyKSByZWNvcmQt PlJlYWRSZWNQdHIsCiAJCSAgICh1aW50MzIpICh4bF9wcmV2ID4+IDMyKSwgKHVpbnQzMikgeGxf cHJldik7Cg== ------=_001_NextPart871207167800_=------