Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRmSS-000481-9k for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 01:17:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kRmSR-0004iT-9A for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 01:16:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRmSR-0004iM-2F for pgsql-hackers@lists.postgresql.org; Mon, 12 Oct 2020 01:16:59 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRmSL-0001AN-0A for pgsql-hackers@lists.postgresql.org; Mon, 12 Oct 2020 01:16:58 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3C6D75C017E; Sun, 11 Oct 2020 21:16:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 11 Oct 2020 21:16:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Re7yz4gIl11x+68t8k9garxmyF2 hr9uBq+p4Ck8DEQ4=; b=VbBocBplMXo/gpMNV+W+2vnuiz+CaoYuUhWX92H9Lkj jioYEZEmB8DMcds74+3EC1Y4///2O6bZHqR7m1Kx/rHEO2dEx6JcIuflR8k5IwW7 mV5LceK1Rj29vIPL5kgbH2kHXwJbntoHM8AVnwzKX+sS+ykAbhWHPriIV6nKVHC2 oiS8XPyNOUksdgpAPzuxIs/s59GOjWCcQ/osgGOqFXIdjPBnt0g9o/5hwH7gZyE7 8cyLiIvT5/VSgY7+Y3sdt8xsLL66nvEFOaRaGwjQrAjHG/RNUls5jVt2+BbUhADs ITpcQGnNQPDlUeu4dXm6lw9xlCT4NCRqzeOPwFYSgYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Re7yz4 gIl11x+68t8k9garxmyF2hr9uBq+p4Ck8DEQ4=; b=PrNWoFkXgxoDuIq23p+3rY /RDbcmLvmGdk+v7SLuphf2RWRfkzbcTYcWkS4OwOPX/uv2+Thn0FsgQliRNJ1+Om CELVTmLguVayBzbDWd0nJdRGIelm5oeV88v/WuXdx6SZLi0ihEsxZkecQyzHggXq gr/h5tEvNMA4r1+BSOLz5Yvpcoet2/vyYAxb2djVHRSsFbVmC9ee+eCIf+FIem6N aIseAZcCwTLaO3ScEe87RziuLBbQtklXHTB1MmtErz/9OXi1FMNDBSx8Wj5Zutvh 4KsI303RlEIzVibfU4dE79U0nMzSK5govb+/T7wZV2RIWezbeIZtAHNko0LERiZg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheeigdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecukfhppeduuddurddutddvrddukedtrd dukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 29013306467D; Sun, 11 Oct 2020 21:16:48 -0400 (EDT) Date: Mon, 12 Oct 2020 10:16:46 +0900 From: Michael Paquier To: Christoph Berg Cc: Tom Lane , Noah Misch , pgsql-hackers@lists.postgresql.org Subject: Re: powerpc pg_atomic_compare_exchange_u32_impl: error: comparison of integer expressions of different signedness (Re: pgsql: For all ppc compilers, implement compare_exchange and) fetch_add Message-ID: <20201012011646.GD2346@paquier.xyz> References: <20201009092825.GD889580@msg.df7cb.de> <20201009100117.GA1550390@rfd.leadboat.com> <20201011051043.GA1724101@rfd.leadboat.com> <3006140.1602436360@sss.pgh.pa.us> <20201011183513.GA709789@msg.df7cb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline In-Reply-To: <20201011183513.GA709789@msg.df7cb.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --veXX9dWIonWZEC6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 11, 2020 at 08:35:13PM +0200, Christoph Berg wrote: > Re: Tom Lane >> Hmm, I'd argue for a back-patch. The issue of modern compilers >> warning about the incorrect code will apply to all supported branches. >> Moreover, even if we don't use these code paths today, who's to say >> that someone won't back-patch a bug fix that requires them? I do not >> think it's unreasonable to expect these functions to work well in >> all branches that have them. >=20 > Or remove them. (But fixing seems better.) The patch is not that invasive, so just fixing back-branches sounds like a good idea to me. My 2c. -- Michael --veXX9dWIonWZEC6h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl+Drn4ACgkQnvQgOdby QH0yrQ/+J707I1vaQQZAyobdqPq35mbuYo0KrWAETPS2K8eJITM5OT1Ln+HSE3KX 3SIveWi+2X/KjRnSUsJDBlalmpGmsu4uiaFEic1PQ5EGtUsVQmfyFRkQEGZPvakc p/V3igzAToQ+bPZXg19SI0PTD81iXZpmLloc4htYeqyGqyAgrRJNj60IuRaM39GY tvf1hPe87Z4u/KydALlp9BYrgxNw1d2HXJNxU3d+yp/faxJlGe8QEZ8W18lZs6Hy mFioMYlL5j0ylCAyesXUHCPgx6pX3Tev8eZifqZjOCo7nDbcdXQwgvQCXAmC5TWP MaU/gzevYjy/VTVmabLk2JmmWlW4ZHitCpRtegp+JOo8rqxMk2uGwStKb4HuTt+Q dlKdNQygWuHCEyvFZPWf7P9OIy6j8Yeis+iYF9FBCYUOcowsEfL9uFnSmsIvmc77 8+jzWA5wC6xZd6IK0DSkAEhqmVk+zO2JJ/lUVddx1M3WoyniWz91yYEAmtIDJgGC diq+Y7Hq+qQynlwO6/safXwLV+HrNAGUe5uRDByXJ2fewLx2jORbJc25MJncTDHI kDYWNVh1r1JUDEVF//LmTdXNw//EkUjyRQ94Z6q2alJIURwTQNj3Sz2kauDgot/2 P/5c7yyUUEEPo8v9zArO4a5Lx7ARWeCvFj0UlwbS/jNvX0b7AGs= =vCEo -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h--