Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kRrxK-0006mR-FR
	for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 07:09:14 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kRrxJ-0002SZ-EI
	for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 07:09:13 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <movead.li@highgo.ca>)
	id 1kRmvK-0006nu-9M
	for pgsql-hackers@lists.postgresql.org; Mon, 12 Oct 2020 01:46:50 +0000
Received: from sender4-op-o13.zoho.com ([136.143.188.13])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <movead.li@highgo.ca>)
	id 1kRmvH-0003fl-7t
	for pgsql-hackers@postgresql.org; Mon, 12 Oct 2020 01:46:49 +0000
ARC-Seal: i=1; a=rsa-sha256; t=1602467201; cv=none;
	d=zohomail.com; s=zohoarc;
	b=Lzj09WpbcRIO+PKMSZymHBJpeibwTy6DXxh3wNqrV40JrKpu42GOi0wJnuK3TtJIKiXq3rzlLeFuEtE6LmzFAVnMcturwpZz5y4En/gqXxL5eQ6YMODV+1TXImAOPnzMQhl34ZpqtOmJHhLammNtsSObq1MVUzBHEIycnpOkRl8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc;
	t=1602467201;
 h=Content-Type:Cc:Date:From:MIME-Version:Message-ID:References:Subject:To;
	bh=fSFOrzBKopQPFIKM2MxOtzfdRbFNdC43eSQJ9RnVeUM=;
	b=QsPPdwID9yvu4GXMFh1L0JeTFOCmpzXkjWN2ujTZTdZ1Uu/ZDY3vE611oytuI/3BsJjwAlEWboTeXeuXIQFc6apqmKb9QcxoVEL9tGx87XBTXuVWrGmuovZcZo+rgFoSDlv38Ds0oBglteRtuEvPXQsPOBt2QpiJSkWw3w2/W7Y=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=highgo.ca;
	spf=pass  smtp.mailfrom=movead.li@highgo.ca;
	dmarc=pass header.from=<movead.li@highgo.ca>
 header.from=<movead.li@highgo.ca>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1602467201;
	s=zoho; d=highgo.ca; i=movead.li@highgo.ca;
	h=Date:From:To:Cc:Subject:References:Mime-Version:Message-ID:Content-Type;
	bh=fSFOrzBKopQPFIKM2MxOtzfdRbFNdC43eSQJ9RnVeUM=;
	b=C4pynEOngambQbT15NHaQcP++DdJoasEhyt3RmWuqbPpL1pOuw7GDnkgFOe32cL+
	IOjYN2pEsd+DbJR9/HNVzdN7P1aNDCqzk4ezreraQ6UaXDIfzMRrSwyIe4q5FrD4RpA
	U8datF2Xs6ubFQWGqTJI7fuFxZDwq/BIA6dUPKbg=
Received: from lchch (124.133.18.218 [124.133.18.218]) by mx.zohomail.com
	with SMTPS id 1602467199644135.02601034731606;
 Sun, 11 Oct 2020 18:46:39 -0700 (PDT)
Date: Mon, 12 Oct 2020 09:46:37 +0800
From: "movead.li@highgo.ca" <movead.li@highgo.ca>
To: michael <michael@paquier.xyz>
Cc: Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	ahsan.hadi <ahsan.hadi@highgo.ca>
Subject: Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
References: <2020100913412132258847@highgo.ca>,
	<20201009.174658.2098946247926431018.horikyota.ntt@gmail.com>,
	<2020101009495929215052@highgo.ca>,
	<20201012011212.GC2346@paquier.xyz>
X-Priority: 3
X-GUID: 0E600812-FEEE-4BFE-B9DC-9548DFEA9E3E
X-Has-Attach: no
X-Mailer: Foxmail 7.2.16.188[cn]
Mime-Version: 1.0
Message-ID: <2020101209463463842666@highgo.ca>
Content-Type: multipart/alternative;
	boundary="----=_001_NextPart675531075465_=----"
X-ZohoMailClient: External
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

This is a multi-part message in MIME format.

------=_001_NextPart675531075465_=----
Content-Type: text/plain;
	charset="ISO-8859-1"
Content-Transfer-Encoding: base64

DQpUaGFua3MgZm9yIHJlcGx5Lg0KDQo+SWYgeW91IHdpc2ggdG8gYWRkIG1vcmUgaW5mb3JtYXRp
b24gYWJvdXQgYSBYTE9HX1NXSVRDSCByZWNvcmQsIEkNCj5kb24ndCB0aGluayB0aGF0IGNoYW5n
aW5nIHRoZSBzaWduYXR1cmUgb2YgWExvZ0R1bXBSZWNvcmRMZW4oKSBpcw0KPmFkYXB0ZWQgYmVj
YXVzZSB0aGUgcmVjb3JkIGxlbmd0aCBvZiB0aGlzIHJlY29yZCBpcyBkZWZpbmVkIGFzDQo+SG9y
aWd1Y2hpLXNhbiBtZW50aW9uZWQgdXB0aHJlYWQsIGFuZCB0aGUgbWVhbmluZyBvZiBqdW5rX2xl
biBpcw0KPmNvbmZ1c2luZyBoZXJlLiAgSXQgc2VlbXMgdG8gbWUgdGhhdCBhbnkgZXh0cmEgaW5m
b3JtYXRpb24gc2hvdWxkIGJlDQo+YWRkZWQgdG8geGxvZ19kZXNjKCkgd2hlcmUgdGhlcmUgc2hv
dWxkIGJlIGFuIGV4dHJhIGNvZGUgcGF0aCBmb3INCj4oaW5mbyA9PSBYTE9HX1NXSVRDSCkuICBY
TG9nUmVhZGVyU3RhdGUgc2hvdWxkIGhhdmUgYWxsIHRoZQ0KPmluZm9ybWF0aW9uIHlvdSBhcmUg
bG9va25nIGZvci4NCldlIGhhdmUgdHdvIHBsYWNlcyB0byB1c2UgdGhlICdqdW5rX2xlbicsIG9u
ZSBpcyB3aGVuIHdlIHNob3cgdGhlIA0KZGV0YWlsIHJlY29yZCBpbmZvcm1hdGlvbiwgYW5vdGhl
ciBpcyB3aGVuIHdlIHN0YXRpc3RpY3MgdGhlIHBlcmNlbnQNCm9mIGFsbCBraW5kIG9mIHdhbCBy
ZWNvcmQga2luZHMoYnkgLS1zdGF0PXJlY29yZCkuIFRoZSBzZWNvbmQgcGxhY2UNCndpbGwgbm90
IHJ1biB0aGUgeGxvZ19kZXNjKCksIHNvIGl0J3Mgbm90IGEgZ29vZCBjaGFuY2UgdG8gZG8gdGhl
IHRoaW5nLg0KDQpJIGFtIHN0aWxsIGNhbiBub3QgdW5kZXJzdGFuZCB3aHkgaXQgY2FuJ3QgYWRh
cHRlZCB0byBjaGFuZ2UgdGhlDQpzaWduYXR1cmUgb2YgWExvZ0R1bXBSZWNvcmRMZW4oKSwgbWF5
YmUgd2UgY2FuIGFkZCBhIG5ldyBmdW5jdGlvbg0KdG8gY2FjdWxhdGUgdGhlICdqdW5rX2xlbicg
YW5kIHJlbmFtZSB0aGUgJ2p1bmtfbGVuJyBhcyAnc2tpcGVkX3NpemUnIG9yDQonc3dpdGNoZWRf
c2l6ZSc/DQoNCg0KDQoNClJlZ2FyZHMsDQpIaWdoZ28gU29mdHdhcmUgKENhbmFkYS9DaGluYS9Q
YWtpc3RhbikgDQpVUkwgOiB3d3cuaGlnaGdvLmNhIA0KRU1BSUw6IG1haWx0bzptb3ZlYWQoZG90
KWxpKGF0KWhpZ2hnbyhkb3QpY2ENCg0K

------=_001_NextPart675531075465_=----
Content-Type: text/html;
	charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charse=
t=3DISO-8859-1"><style>body { line-height: 1.5; }blockquote { margin-top: =
0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; fo=
nt-family: 'Microsoft YaHei UI'; color: rgb(0, 0, 0); line-height: 1.5; }<=
/style></head><body>=0A<div><span></span><br></div><div>Thanks for reply.<=
/div><div><br></div>=0A<div><div><span style=3D"font-size: 10.5pt; line-he=
ight: 1.5; background-color: transparent;">&gt;If you wish to add more inf=
ormation about a XLOG_SWITCH record, I</span></div><div><span style=3D"fon=
t-size: 10.5pt; line-height: 1.5; background-color: transparent;">&gt;</sp=
an>don't think that changing the signature of XLogDumpRecordLen() is</div>=
<div><span style=3D"font-size: 10.5pt; line-height: 1.5; background-color:=
 transparent;">&gt;</span>adapted because the record length of this record=
 is defined as</div><div><span style=3D"font-size: 10.5pt; line-height: 1.=
5; background-color: transparent;">&gt;</span>Horiguchi-san mentioned upth=
read, and the meaning of junk_len is</div><div><span style=3D"font-size: 1=
0.5pt; line-height: 1.5; background-color: transparent;">&gt;</span>confus=
ing here.&nbsp; It seems to me that any extra information should be</div><=
div><span style=3D"font-size: 10.5pt; line-height: 1.5; background-color: =
transparent;">&gt;</span>added to xlog_desc() where there should be an ext=
ra code path for</div><div><span style=3D"font-size: 10.5pt; line-height: =
1.5; background-color: transparent;">&gt;</span>(info =3D=3D XLOG_SWITCH).=
&nbsp; XLogReaderState should have all the</div><div><span style=3D"font-s=
ize: 10.5pt; line-height: 1.5; background-color: transparent;">&gt;</span>=
information you are lookng for.</div></div><div>We have two places to use =
the '<span style=3D"font-size: 10.5pt; line-height: 1.5; background-color:=
 transparent;">junk_len', one is when we show the&nbsp;</span></div><div><=
span style=3D"font-size: 10.5pt; line-height: 1.5; background-color: trans=
parent;">detail record information, another is when we&nbsp;</span><span s=
tyle=3D"font-size: 10.5pt; line-height: 1.5; background-color: transparent=
;">statistics the percent</span></div><div><span style=3D"font-size: 10.5p=
t; line-height: 1.5; background-color: transparent;">of all kind of wal re=
cord kinds(by --stat=3Drecord). The second place</span></div><div><span st=
yle=3D"font-size: 10.5pt; line-height: 1.5; background-color: transparent;=
">will not&nbsp;</span><span style=3D"font-size: 10.5pt; line-height: 1.5;=
 background-color: transparent;">run the&nbsp;</span><span style=3D"font-s=
ize: 10.5pt; line-height: 1.5; background-color: transparent;">xlog_desc()=
, so it's not a good chance to do the thing.</span></div><div><span style=
=3D"font-size: 10.5pt; line-height: 1.5; background-color: transparent;"><=
br></span></div><div><span style=3D"font-size: 10.5pt; line-height: 1.5; b=
ackground-color: transparent;">I am still can not understand why it can't&=
nbsp;</span><span style=3D"font-size: 10.5pt; line-height: 1.5; background=
-color: transparent;">adapted</span><span style=3D"font-size: 10.5pt; line=
-height: 1.5; background-color: transparent;">&nbsp;to change&nbsp;</span>=
<span style=3D"font-size: 10.5pt; line-height: 1.5; background-color: tran=
sparent;">the</span></div><div><span style=3D"font-size: 10.5pt; line-heig=
ht: 1.5; background-color: transparent;">signature of XLogDumpRecordLen(),=
 maybe we can add a new function</span></div><div><span style=3D"font-size=
: 10.5pt; line-height: 1.5; background-color: transparent;">to caculate th=
e '</span><span style=3D"font-size: 10.5pt; line-height: 1.5; background-c=
olor: transparent;">junk_len' and rename the '</span><span style=3D"font-s=
ize: 10.5pt; line-height: 1.5; background-color: transparent;">junk_len' a=
s 'skiped_size' or</span></div><div><span style=3D"font-size: 10.5pt; line=
-height: 1.5; background-color: transparent;">'switched_size'?</span></div=
><div><br></div><div><br></div><hr style=3D"width: 210px; height: 1px;" co=
lor=3D"#b5c4df" size=3D"1" align=3D"left">=0A<div><span><div style=3D"MARG=
IN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><span style=3D"color: rgb=
(13, 10, 11); font-family: monospace, monospace; font-size: 10.7333px; fon=
t-variant-ligatures: normal; orphans: 2; white-space: pre-wrap; widows: 2;=
">Regards,</span></div><div style=3D"MARGIN: 10px; FONT-FAMILY: verdana; F=
ONT-SIZE: 10pt"><span style=3D"color: rgb(13, 10, 11); font-family: monosp=
ace, monospace; font-size: 10.7333px; font-variant-ligatures: normal; orph=
ans: 2; white-space: pre-wrap; widows: 2;">Highgo Software (Canada/China/P=
akistan) </span><br style=3D"box-sizing: border-box; color: rgb(13, 10, 11=
); font-family: monospace, monospace; font-size: 10.7333px; font-variant-l=
igatures: normal; orphans: 2; white-space: pre-wrap; widows: 2;"><span sty=
le=3D"color: rgb(13, 10, 11); font-family: monospace, monospace; font-size=
: 10.7333px; font-variant-ligatures: normal; orphans: 2; white-space: pre-=
wrap; widows: 2;">URL : </span><a href=3D"http://www.highgo.ca/" rel=3D"no=
follow" style=3D"box-sizing: border-box; color: rgb(132, 0, 50); text-deco=
ration: none; font-weight: 600; transition: color 0.2s ease-in-out 0s; fon=
t-family: monospace, monospace; font-size: 10.7333px; font-variant-ligatur=
es: normal; orphans: 2; white-space: pre-wrap; widows: 2;">www.highgo.ca</=
a><span style=3D"color: rgb(13, 10, 11); font-family: monospace, monospace=
; font-size: 10.7333px; font-variant-ligatures: normal; orphans: 2; white-=
space: pre-wrap; widows: 2;"> </span><br style=3D"box-sizing: border-box; =
color: rgb(13, 10, 11); font-family: monospace, monospace; font-size: 10.7=
333px; font-variant-ligatures: normal; orphans: 2; white-space: pre-wrap; =
widows: 2;"><span style=3D"color: rgb(13, 10, 11); font-family: monospace,=
 monospace; font-size: 10.7333px; font-variant-ligatures: normal; orphans:=
 2; white-space: pre-wrap; widows: 2;">EMAIL: mailto:movead(dot)li(at)high=
go(dot)ca</span></div></span></div>=0A<blockquote style=3D"margin-Top: 0px=
; margin-Bottom: 0px; margin-Left: 0.5em; margin-Right: inherit"><div><br>=
</div><div>=0A</div></blockquote>=0A</body></html>
------=_001_NextPart675531075465_=------