Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kSmc8-00057E-Fr
	for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Oct 2020 19:39:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kSmc7-0000kC-Ez
	for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Oct 2020 19:39:07 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pryzby@telsasoft.com>)
	id 1kSmc7-0000k4-2f
	for pgsql-hackers@lists.postgresql.org; Wed, 14 Oct 2020 19:39:07 +0000
Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <pryzby@telsasoft.com>)
	id 1kSmc4-0002mW-9s
	for pgsql-hackers@postgresql.org; Wed, 14 Oct 2020 19:39:06 +0000
Received: by mail-io1-xd35.google.com with SMTP id g7so510094iov.13
        for <pgsql-hackers@postgresql.org>;
 Wed, 14 Oct 2020 12:39:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=telsasoft-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :user-agent;
        bh=ANWS17dmHSmQ2IEJPIZfGPyaLOzf5oP0O8ScZb4fQOo=;
        b=TVxpiweCpln4mECg0tZ7SNSjoWkP2tclt0CkEAOD+YP2wkp9iNC0bzSnyR5EEcdC0s
         rNTaDn1TmMoVCCwkryjoWlrmzBRE0Bysyu1BVsFASnKxomRAHdkAS0pkA60qspRzBb8P
         zve0TkH4JTSU2bo3vavirmdHb8yNuYR7x3pTUtQaanzTeKy0M8qq01KvIU4wkUPD8IKT
         cbtw+2WvbO100dxuqsvBfBcw2iowFxQ2vWhiIEphQ9peFgWpzt0ShqRkWIzc/Fi+aCaG
         tXAI75SUzXBdBjdC5SPNWcsFDZDg144EFnfJPF+/Q7IejOkHJtvB+WIHSkakK0HeTdqQ
         +nYA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:user-agent;
        bh=ANWS17dmHSmQ2IEJPIZfGPyaLOzf5oP0O8ScZb4fQOo=;
        b=V2uc0zAO3k54dfSDNNtelMgHBeDiTYIYwfenYk0TpptFpQPqtbmx3v/ZBI/nA8wdnX
         PbfL8uMvBp6/DIyUN9+fMxeCdtkuCAOvfeRJqWWV1w+SsD6/4L5lFxFDDS6vg+lUIa9J
         KGIxdIuU/+P6uFXoSHX2dKk06+p1NozmIozdrU/i9/HpjTK3eXZ69lQG7hxdWPJYFYYy
         UIiKuDDIh02n05R6l2/+wH0iZLmKi2EdBgdQPNxJj8DYvVI56W8qIGW0B/cNZ7y86XmZ
         8GWn33PwQ6p64EoHwDf2XGx5Cxd5i+0PF1dIG8/94piYu0WhyFJ4mZq0uaPrJQvHdPNX
         do5w==
X-Gm-Message-State: AOAM533600TGqHPh5qaa5vkEhWnL9yP/Sa6RHVvbqAY53ULREVEhJ1kR
	XCPu+vvFwUSbySB6pQ+GsjWoDw==
X-Google-Smtp-Source: 
 ABdhPJxgZBtv95rVg3HJDo2L+QJyN9SKZcYj4THDWhFIHv5dzy5Z/JYbhpkHNukIqUyJSXSWy+pbhw==
X-Received: by 2002:a6b:c94f:: with SMTP id z76mr770623iof.88.1602704342260;
        Wed, 14 Oct 2020 12:39:02 -0700 (PDT)
Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1])
        by smtp.gmail.com with ESMTPSA id
 f85sm345045ill.39.2020.10.14.12.39.00
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 14 Oct 2020 12:39:01 -0700 (PDT)
Received: by pryzbyj.telsasoft (Postfix, from userid 1000)
	id 20FE280067E; Wed, 14 Oct 2020 14:39:00 -0500 (CDT)
Date: Wed, 14 Oct 2020 14:39:00 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: pgsql-hackers@postgresql.org
Cc: Andres Freund <andres@anarazel.de>, David Rowley <dgrowleyml@gmail.com>
Subject: jit and explain nontext
Message-ID: <20201014193859.GS9241@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

        /* don't print information if no JITing happened */
        if (!ji || ji->created_functions == 0)
                return;

This applies even when (es->format != EXPLAIN_FORMAT_TEXT), which I think is
wrong.  Jit use can be determined by cost, so I think jit details should be
shown in non-text format whenever ji!=NULL, even if it's zeros.  Arguably, bits
could be omitted if jit_expressions=off or jit_tuple_deforming=off, but I don't
see the point.

-- 
Justin