Date: Thu, 15 Oct 2020 12:56:02 +0800
From: "movead.li@highgo.ca" <movead.li@highgo.ca>
To: Horiguchi <horikyota.ntt@gmail.com>,
	andres <andres@anarazel.de>
Cc: michael <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	ahsan.hadi <ahsan.hadi@highgo.ca>
Subject: Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
References: <20201014.102944.102635524623180309.horikyota.ntt@gmail.com>,
	<20201014065243.GA12403@paquier.xyz>,
	<20201014204613.lxts3w6lc4lsv7zh@alap3.anarazel.de>,
	<20201015.114443.2231235644531652368.horikyota.ntt@gmail.com>
Mime-Version: 1.0
Message-ID: <2020101512560020200319@highgo.ca>
Content-Type: multipart/mixed;
	boundary="----=_001_NextPart658837360467_=----"
Precedence: bulk

This is a multi-part message in MIME format.

------=_001_NextPart658837360467_=----
Content-Type: multipart/alternative;
	boundary="----=_002_NextPart042810413818_=----"


------=_002_NextPart042810413818_=----
Content-Type: text/plain;
	charset="ISO-8859-1"
Content-Transfer-Encoding: base64

VGhhbmtzIGZvciBhbGwgdGhlIHN1Z2dlc3Rpb25zLg0KDQo+WWVhaC4gIEluIGl0cyBjdXJyZW50
IHNoYXBlLCBpdCBtZWFucyB0aGF0IG9ubHkgcGdfd2FsZHVtcCB3b3VsZCBiZQ0KPmFibGUgdG8g
a25vdyB0aGlzIGluZm9ybWF0aW9uLiAgSWYgeW91IG1ha2UgdGhpcyBpbmZvcm1hdGlvbiBwYXJ0
IG9mDQo+eGxvZ2Rlc2MuYywgYW55IGNvbnN1bWVyIG9mIHRoZSBXQUwgcmVjb3JkIGRlc2NyaXB0
aW9ucyB3b3VsZCBiZSBhYmxlDQo+dG8gc2hvdyB0aGlzIGluZm9ybWF0aW9uLCBzbyBpdCB3b3Vs
ZCBwcm92aWRlIGEgY29uc2lzdGVudCBvdXRwdXQgZm9yDQo+YW55IGtpbmQgb2YgdG9vbHMuDQpJ
IGhhdmUgY2hhbmdlIHRoZSBpbXBsZW1lbnQsIG1vdmUgc29tZSBjb2RlIGludG8geGxvZ19kZXNj
KCkuDQoNCj5PbiB0b3Agb2YgdGhhdCwgaXQgc2VlbXMgdG8gbWUgdGhhdCB0aGUgY2FsY3VsYXRp
b24gdXNlZCBpbiB0aGUgcGF0Y2gNCj5pcyB3cm9uZyBpbiB0d28gYXNwZWN0cyBhdCBxdWljayBn
bGFuY2U6DQo+MSkgc3RhcnRTZWdObyBhbmQgZW5kU2VnTm8gcG9pbnQgYWx3YXlzIHRvIHR3byBk
aWZmZXJlbnQgc2VnbWVudHMgd2l0aA0KPmEgWExPR19TV0lUQ0ggcmVjb3JkLCBzbyB5b3Ugc2hv
dWxkIGNoZWNrIHRoYXQgUmVhZFJlY1B0ciBpcyBub3QgYXQgYQ0KPnNlZ21lbnQgYm9yZGVyIGlu
c3RlYWQgYmVmb3JlIGV4dHJhY3RpbmcgU2l6ZU9mWExvZ0xvbmdQSEQsIG5vPw0KWWVzIHlvdSBh
cmUgcmlnaHQsIGFuZCBJIHVzZSAncmVjb3JkLT5FbmRSZWNQdHIgLSAxJyBpbnN0ZWFkLg0KDQo+
MikgVGhpcyBzdHVmZiBzaG91bGQgYWxzbyBjaGVjayBhZnRlciB0aGUgY2FzZSBvZiBhIFdBTCAq
cGFnZSogYm9yZGVyDQo+d2hlcmUgeW91J2QgbmVlZCB0byBhZGp1c3QgYmFzZWQgb24gU2l6ZU9m
WExvZ1Nob3J0UEhEIGluc3RlYWQuDQpUaGUgJ2p1bmtfbGVuIC09IFNpemVPZlhMb2dMb25nUEhE
JyBjb2RlIGlzIGNvbnNpZGVyZWQgZm9yIHdoZW4gdGhlDQpyZW1haW4gc2l6ZSBvZiBhIHdhbCBz
ZWdtZW50IGNhbiBub3QgYWZmb3JkIGEgWExvZ1JlY29yZCBzdHJ1Y3QgZm9yDQpYTE9HX1NXSVRD
SCwgaXQgbmVlZG4ndCBjYXJlICpwYWdlKiBib3JkZXIuDQoNCj5JJ20gbm90IHN1cmUgdGhlIGV4
YWN0IG1vdGl2ZSBvZiB0aGlzIHByb3Bvc2FsLCBidXQgaWYgd2Ugc2hvdyB0aGUNCj53YXN0ZWQg
bGVuZ3RoIGluIHRoZSBzdGF0cyByZXN1bHQsIEkgdGhpbmsgaXQgc2hvdWxkIGJlIG90aGVyIHRo
YW4NCj5leGlzdGluZyByZWNvcmQgdHlwZXMuDQpZZXMgYWdyZWUsIGFuZCBub3cgaXQgbG9va3Mg
bGlrZSBiZWxvdyBhcyBuZXcgcGF0Y2g6DQoNCm1vdmVhZEBtb3ZlYWQtUEM6L2gyL3BnL2JpbiQg
Li9wZ193YWxkdW1wIC1wIC4uL3dhbGJrLyAtcyAwLzMwMDAwMDAgLWUgMC82MDAwMDAwIC16DQpU
eXBlICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE4gICAgICAoJSkg
ICAgICAgICAgUmVjb3JkIHNpemUgICAgICAoJSkgICAgICAgICAgICAgRlBJIHNpemUgICAgICAo
JSkgICAgICAgIENvbWJpbmVkIHNpemUgICAgICAoJSkNCi0tLS0gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgLSAgICAgIC0tLSAgICAgICAgICAtLS0tLS0tLS0tLSAg
ICAgIC0tLSAgICAgICAgICAgICAtLS0tLS0tLSAgICAgIC0tLSAgICAgICAgLS0tLS0tLS0tLS0t
LSAgICAgIC0tLQ0KWExPRyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICA1ICggMzEuMjUpICAgICAgICAgICAgICAgICAgMzAwICggIDAuMDApICAgICAgICAgICAgICAg
ICAgICAwICggIDAuMDApICAgICAgICAgICAgICAgICAgMzAwICggIDAuMDApDQpYTE9HU3dpdGNo
SnVuayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDMgKCAxOC43NSkgICAgICAgICAg
ICAgNTAzMzA1MTIgKDEwMC4wMCkgICAgICAgICAgICAgICAgICAgIDAgKCAgMC4wMCkgICAgICAg
ICAgICAgNTAzMzA1MTIgKDEwMC4wMCkNCg0KDQptb3ZlYWRAbW92ZWFkLVBDOi9oMi9wZy9iaW4k
IC4vcGdfd2FsZHVtcCAtcCAuLi93YWxiay8gLXMgMC8zMDAwMDAwIC1lIDAvNjAwMDAwMCAtLXN0
YXQ9cmVjb3JkDQpYTE9HL1NXSVRDSCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IDMgKCAxOC43NSkgICAgICAgICAgICAgICAgICAgNzIgKCAgMC4wMCkgICAgICAgICAgICAgICAg
ICAgIDAgKCAgMC4wMCkgICAgICAgICAgICAgICAgICAgNzIgKCAgMC4wMCkNClhMT0cvU1dJVENI
X0pVTksgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMyAoIDE4Ljc1KSAgICAgICAgICAg
ICA1MDMzMDUxMiAoMTAwLjAwKSAgICAgICAgICAgICAgICAgICAgMCAoICAwLjAwKSAgICAgICAg
ICAgICA1MDMzMDUxMiAoMTAwLjAwKQ0KDQpUaGUgc2hvcnRjb21pbmcgbm93IGlzIEkgZG8gbm90
IGtub3cgaG93IHRvIGhhbmRsZSB0aGUgJ2NvdW50JyBvZiBTV0lUQ0hfSlVOSw0KaW4gcGdfd2Fs
ZHVtcCByZXN1bHRzLiBDdXJyZW50bHkgSSByZWdhcmQgU1dJVENIX0pVTksgYXMgb25lIGNvdW50
Lg0KDQo+QnkgdGhlIHdheSwgSSBub3RpY2VkIHRoYXQgLS1zdGF0cz1yZWNvcmQgc2hvd3MgdHdv
IGxpbmVzIGZvcg0KPlRyYW5zYWN0aW9uL0NPTU1JVC4gVGhlIGNhdXNlIGlzIHRoYXQgWExvZ0R1
bXBDb3VudFJlY29yZCBhc3N1bWVzIHRoZQ0KPmFsbCBmb3VyIGJpdHMgb2YgeGxfaW5mbyBpcyB1
c2VkIHRvIGlkZW50aWZ5IHJlY29yZCBpZC4NClRoYW5rcyxJIGRpZG4ndCBub3RpY2UgaXQgYmVm
b3JlLCBhbmQgeW91ciBwYXRjaCBhZGRlZCBpbnRvIHYzIHBhdGNoIGF0dGFjaGVkLg0KDQoNCg0K
DQpSZWdhcmRzLA0KSGlnaGdvIFNvZnR3YXJlIChDYW5hZGEvQ2hpbmEvUGFraXN0YW4pIA0KVVJM
IDogd3d3LmhpZ2hnby5jYSANCkVNQUlMOiBtYWlsdG86bW92ZWFkKGRvdClsaShhdCloaWdoZ28o
ZG90KWNhDQo=

------=_002_NextPart042810413818_=----
Content-Type: text/html;
	charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charse=
t=3DISO-8859-1"><style>body { line-height: 1.5; }blockquote { margin-top: =
0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; fo=
nt-family: 'Microsoft YaHei UI'; color: rgb(0, 0, 0); line-height: 1.5; }<=
/style></head><body>=0A<div><span></span>Thanks for all the suggestions.</=
div><div><br></div><div><div style=3D"font-family: 'Microsoft YaHei UI', T=
ahoma; line-height: normal;">&gt;Yeah.&nbsp; In its current shape, it mean=
s that only pg_waldump would be</div><div style=3D"font-family: 'Microsoft=
 YaHei UI', Tahoma; line-height: normal;"><span style=3D"font-size: 10.5pt=
; background-color: transparent;">&gt;</span>able to know this information=
.&nbsp; If you make this information part of</div><div style=3D"font-famil=
y: 'Microsoft YaHei UI', Tahoma; line-height: normal;"><span style=3D"font=
-size: 10.5pt; background-color: transparent;">&gt;</span>xlogdesc.c, any =
consumer of the WAL record descriptions would be able</div><div style=3D"f=
ont-family: 'Microsoft YaHei UI', Tahoma; line-height: normal;"><span styl=
e=3D"font-size: 10.5pt; background-color: transparent;">&gt;</span>to show=
 this information, so it would provide a consistent output for</div><div s=
tyle=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-height: normal;"><=
span style=3D"font-size: 10.5pt; background-color: transparent;">&gt;</spa=
n>any kind of tools.</div><div style=3D"line-height: normal;"><span style=
=3D"font-family: 'Microsoft YaHei UI', Tahoma;">I have change the implemen=
t, move some</span><font face=3D"Microsoft YaHei UI, Tahoma"> code into&nb=
sp;<span style=3D"line-height: 22px; white-space: pre;">xlog_desc().</span=
></font></div><br style=3D"font-family: 'Microsoft YaHei UI', Tahoma; line=
-height: normal;"><div style=3D"font-family: 'Microsoft YaHei UI', Tahoma;=
 line-height: normal;"><span style=3D"font-size: 10.5pt; background-color:=
 transparent;">&gt;</span>On top of that, it seems to me that the calculat=
ion used in the patch</div><div style=3D"font-family: 'Microsoft YaHei UI'=
, Tahoma; line-height: normal;"><span style=3D"font-size: 10.5pt; backgrou=
nd-color: transparent;">&gt;</span>is wrong in two aspects at quick glance=
:</div><div style=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-heigh=
t: normal;"><span style=3D"font-size: 10.5pt; background-color: transparen=
t;">&gt;</span>1) startSegNo and endSegNo point always to two different se=
gments with</div><div style=3D"font-family: 'Microsoft YaHei UI', Tahoma; =
line-height: normal;"><span style=3D"font-size: 10.5pt; background-color: =
transparent;">&gt;</span>a XLOG_SWITCH record, so you should check that Re=
adRecPtr is not at a</div><div style=3D"font-family: 'Microsoft YaHei UI',=
 Tahoma; line-height: normal;"><span style=3D"font-size: 10.5pt; backgroun=
d-color: transparent;">&gt;</span>segment border instead before extracting=
 SizeOfXLogLongPHD, no?</div><div style=3D"line-height: normal;"><span sty=
le=3D"font-family: 'Microsoft YaHei UI', Tahoma;">Yes you are right, and I=
 us</span><font face=3D"Microsoft YaHei UI, Tahoma">e '<span style=3D"line=
-height: 22px; white-space: pre;">record-&gt;EndRecPtr&nbsp;-&nbsp;</span>=
<span style=3D"line-height: 22px; white-space: pre;">1</span>' instead.</f=
ont></div><div style=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-he=
ight: normal;"><br></div><div style=3D"font-family: 'Microsoft YaHei UI', =
Tahoma; line-height: normal;"><span style=3D"font-size: 10.5pt; background=
-color: transparent;">&gt;</span>2) This stuff should also check after the=
 case of a WAL *page* border</div><div style=3D"font-family: 'Microsoft Ya=
Hei UI', Tahoma; line-height: normal;"><span style=3D"font-size: 10.5pt; b=
ackground-color: transparent;">&gt;</span>where you'd need to adjust based=
 on SizeOfXLogShortPHD instead.</div></div><div><font face=3D"Microsoft Ya=
Hei UI, Tahoma">The '<span style=3D"line-height: 22px; white-space: pre;">=
junk_len&nbsp;-=3D&nbsp;</span><span style=3D"line-height: 22px; white-spa=
ce: pre;">SizeOfXLogLongPHD' code is considered for </span></font><span st=
yle=3D"line-height: 22px; white-space: pre;"><font face=3D"Microsoft YaHei=
 UI, Tahoma">when&nbsp;the</font></span></div><div><span style=3D"line-hei=
ght: 22px; white-space: pre;"><font face=3D"Microsoft YaHei UI, Tahoma">re=
main&nbsp;size&nbsp;of&nbsp;a&nbsp;wal&nbsp;segment&nbsp;can&nbsp;not </fo=
nt></span><span style=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-h=
eight: 22px; white-space: pre; font-size: 10.5pt; background-color: transp=
arent;">afford&nbsp;a&nbsp;XLogRecord&nbsp;struct&nbsp;for</span></div><di=
v><span style=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-height: 2=
2px; white-space: pre; font-size: 10.5pt; background-color: transparent;">=
XLOG_SWITCH, it needn't care</span><span style=3D"font-family: 'Microsoft =
YaHei UI', Tahoma; line-height: normal; font-size: 10.5pt; background-colo=
r: transparent;">&nbsp;</span><span style=3D"font-family: 'Microsoft YaHei=
 UI', Tahoma; line-height: normal; font-size: 10.5pt; background-color: tr=
ansparent;">*page* border.</span></div><div><span style=3D"font-family: 'M=
icrosoft YaHei UI', Tahoma; line-height: normal; font-size: 10.5pt; backgr=
ound-color: transparent;"><br></span></div><div><div style=3D"font-family:=
 'Microsoft YaHei UI', Tahoma; line-height: normal;">&gt;I'm not sure the =
exact motive of this proposal, but if we show the</div><div style=3D"font-=
family: 'Microsoft YaHei UI', Tahoma; line-height: normal;">&gt;wasted len=
gth in the stats result, I think it should be other than</div><div style=
=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-height: normal;">&gt;e=
xisting record types.</div></div><div style=3D"font-family: 'Microsoft YaH=
ei UI', Tahoma; line-height: normal;">Yes agree, and now it looks like bel=
ow as new patch:</div><div style=3D"font-family: 'Microsoft YaHei UI', Tah=
oma; line-height: normal;"><br></div><div><font face=3D"Microsoft YaHei UI=
, Tahoma"><span style=3D"line-height: normal;">movead@movead-PC:/h2/pg/bin=
$ ./pg_waldump -p ../walbk/ -s 0/3000000 -e 0/6000000 -z</span></font></di=
v><div><div style=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-heigh=
t: normal;">Type &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &=
nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp=
; &nbsp; &nbsp; N &nbsp; &nbsp; &nbsp;(%) &nbsp; &nbsp; &nbsp; &nbsp; &nbs=
p;Record size &nbsp; &nbsp; &nbsp;(%) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &=
nbsp; FPI size &nbsp; &nbsp; &nbsp;(%) &nbsp; &nbsp; &nbsp; &nbsp;Combined=
 size &nbsp; &nbsp; &nbsp;(%)</div><div style=3D"font-family: 'Microsoft Y=
aHei UI', Tahoma; line-height: normal;">---- &nbsp; &nbsp; &nbsp; &nbsp; &=
nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp=
; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; - &nbsp; &nbsp; &nbsp;--- &nbs=
p; &nbsp; &nbsp; &nbsp; &nbsp;----------- &nbsp; &nbsp; &nbsp;--- &nbsp; &=
nbsp; &nbsp; &nbsp; &nbsp; &nbsp; -------- &nbsp; &nbsp; &nbsp;--- &nbsp; =
&nbsp; &nbsp; &nbsp;------------- &nbsp; &nbsp; &nbsp;---</div><div style=
=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-height: normal;">XLOG =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbs=
p; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 5=
 ( 31.25) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;30=
0 ( &nbsp;0.00) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &n=
bsp; &nbsp;0 ( &nbsp;0.00) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp=
; &nbsp; &nbsp;300 ( &nbsp;0.00)</div><div style=3D"font-family: 'Microsof=
t YaHei UI', Tahoma; line-height: normal;">XLOGSwitchJunk &nbsp; &nbsp; &n=
bsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;=
 &nbsp; &nbsp; &nbsp; 3 ( 18.75) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;=
 50330512 (100.00) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;=
 &nbsp; &nbsp;0 ( &nbsp;0.00) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 50=
330512 (100.00)</div><div style=3D"font-family: 'Microsoft YaHei UI', Taho=
ma; line-height: normal;"><br></div><div style=3D"font-family: 'Microsoft =
YaHei UI', Tahoma; line-height: normal;"><br></div><div><font face=3D"Micr=
osoft YaHei UI, Tahoma"><span style=3D"line-height: normal;">movead@movead=
-PC:/h2/pg/bin$ ./pg_waldump -p ../walbk/ -s 0/3000000 -e 0/6000000 --stat=
=3Drecord</span></font></div><div><div><font face=3D"Microsoft YaHei UI, T=
ahoma"><span style=3D"line-height: normal;">XLOG/SWITCH &nbsp; &nbsp; &nbs=
p; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &=
nbsp; &nbsp; &nbsp; &nbsp; &nbsp;3 ( 18.75) &nbsp; &nbsp; &nbsp; &nbsp; &n=
bsp; &nbsp; &nbsp; &nbsp; &nbsp; 72 ( &nbsp;0.00) &nbsp; &nbsp; &nbsp; &nb=
sp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;0 ( &nbsp;0.00) &nbsp; &nbsp;=
 &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 72 ( &nbsp;0.00)</span><=
/font></div><div><font face=3D"Microsoft YaHei UI, Tahoma"><span style=3D"=
line-height: normal;">XLOG/SWITCH_JUNK &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 3 ( =
18.75) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 50330512 (100.00) &nbsp; =
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;0 ( &nbsp;0.=
00) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 50330512 (100.00)</span></fo=
nt></div></div></div>=0A<div><br></div><div>The&nbsp;shortcoming now is I =
do not know how to handle the 'count' of&nbsp;<span style=3D"font-size: 10=
.5pt; font-family: 'Microsoft YaHei UI', Tahoma; line-height: normal; back=
ground-color: transparent;">SWITCH_JUNK</span></div><div><span style=3D"fo=
nt-size: 10.5pt; font-family: 'Microsoft YaHei UI', Tahoma; line-height: n=
ormal; background-color: transparent;">in pg_waldump results. Currently I =
regard&nbsp;</span><span style=3D"font-size: 10.5pt; font-family: 'Microso=
ft YaHei UI', Tahoma; line-height: normal; background-color: transparent;"=
>SWITCH_JUNK&nbsp;</span><span style=3D"font-family: 'Microsoft YaHei UI',=
 Tahoma; font-size: 10.5pt; line-height: normal; background-color: transpa=
rent;">as one count.</span></div><div><br></div><div><div style=3D"font-fa=
mily: 'Microsoft YaHei UI', Tahoma; line-height: normal;">&gt;By the way, =
I noticed that --stats=3Drecord shows two lines for</div><div style=3D"fon=
t-family: 'Microsoft YaHei UI', Tahoma; line-height: normal;"><span style=
=3D"font-size: 10.5pt; background-color: transparent;">&gt;</span>Transact=
ion/COMMIT. The cause is that XLogDumpCountRecord assumes the</div><div st=
yle=3D"font-family: 'Microsoft YaHei UI', Tahoma; line-height: normal;"><s=
pan style=3D"font-size: 10.5pt; background-color: transparent;">&gt;</span=
>all four bits of xl_info is used to identify record id.</div></div><div>T=
hanks,I didn't notice it before, and your patch added into v3 patch attach=
ed.</div><div><br></div><div><br></div><hr style=3D"width: 210px; height: =
1px;" color=3D"#b5c4df" size=3D"1" align=3D"left">=0A<div><span><div style=
=3D"MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><span style=3D"co=
lor: rgb(13, 10, 11); font-family: monospace, monospace; font-size: 10.733=
3px; font-variant-ligatures: normal; orphans: 2; white-space: pre-wrap; wi=
dows: 2;">Regards,</span></div><div style=3D"MARGIN: 10px; FONT-FAMILY: ve=
rdana; FONT-SIZE: 10pt"><span style=3D"color: rgb(13, 10, 11); font-family=
: monospace, monospace; font-size: 10.7333px; font-variant-ligatures: norm=
al; orphans: 2; white-space: pre-wrap; widows: 2;">Highgo Software (Canada=
/China/Pakistan) </span><br style=3D"box-sizing: border-box; color: rgb(13=
, 10, 11); font-family: monospace, monospace; font-size: 10.7333px; font-v=
ariant-ligatures: normal; orphans: 2; white-space: pre-wrap; widows: 2;"><=
span style=3D"color: rgb(13, 10, 11); font-family: monospace, monospace; f=
ont-size: 10.7333px; font-variant-ligatures: normal; orphans: 2; white-spa=
ce: pre-wrap; widows: 2;">URL : </span><a href=3D"http://www.highgo.ca/" r=
el=3D"nofollow" style=3D"box-sizing: border-box; color: rgb(132, 0, 50); t=
ext-decoration: none; font-weight: 600; transition: color 0.2s ease-in-out=
 0s; font-family: monospace, monospace; font-size: 10.7333px; font-variant=
-ligatures: normal; orphans: 2; white-space: pre-wrap; widows: 2;">www.hig=
hgo.ca</a><span style=3D"color: rgb(13, 10, 11); font-family: monospace, m=
onospace; font-size: 10.7333px; font-variant-ligatures: normal; orphans: 2=
; white-space: pre-wrap; widows: 2;"> </span><br style=3D"box-sizing: bord=
er-box; color: rgb(13, 10, 11); font-family: monospace, monospace; font-si=
ze: 10.7333px; font-variant-ligatures: normal; orphans: 2; white-space: pr=
e-wrap; widows: 2;"><span style=3D"color: rgb(13, 10, 11); font-family: mo=
nospace, monospace; font-size: 10.7333px; font-variant-ligatures: normal; =
orphans: 2; white-space: pre-wrap; widows: 2;">EMAIL: mailto:movead(dot)li=
(at)highgo(dot)ca</span></div></span></div><blockquote style=3D"margin-Top=
: 0px; margin-Bottom: 0px; margin-Left: 0.5em; margin-Right: inherit"><div=
>=0A</div></blockquote>=0A</body></html>
------=_002_NextPart042810413818_=------

------=_001_NextPart658837360467_=----
Content-Type: application/octet-stream;
	name="fix_waldump_size_for_wal_switch_v3.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="fix_waldump_size_for_wal_switch_v3.patch"

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9ybWdyZGVzYy94bG9nZGVzYy5jIGIvc3Jj
L2JhY2tlbmQvYWNjZXNzL3JtZ3JkZXNjL3hsb2dkZXNjLmMKaW5kZXggMzIwMGY3NzdmNS4uOWFl
ZTcyNzlhNCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL3JtZ3JkZXNjL3hsb2dkZXNj
LmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3JtZ3JkZXNjL3hsb2dkZXNjLmMKQEAgLTc0LDYg
Kzc0LDEzIEBAIHhsb2dfZGVzYyhTdHJpbmdJbmZvIGJ1ZiwgWExvZ1JlYWRlclN0YXRlICpyZWNv
cmQpCiAJCW1lbWNweSgmbmV4dE9pZCwgcmVjLCBzaXplb2YoT2lkKSk7CiAJCWFwcGVuZFN0cmlu
Z0luZm8oYnVmLCAiJXUiLCBuZXh0T2lkKTsKIAl9CisJZWxzZSBpZiAoaW5mbyA9PSBYTE9HX1NX
SVRDSCkKKwl7CisJCXVpbnQzMglqdW5rX2xlbjsKKwkJanVua19sZW4gPSB4bG9nX3N3aXRjaF9q
dW5rX2xlbihyZWNvcmQpOworCisJCWFwcGVuZFN0cmluZ0luZm8oYnVmLCAidHJhaWxpbmctYnl0
ZXM6ICV1IiwganVua19sZW4pOworCX0KIAllbHNlIGlmIChpbmZvID09IFhMT0dfUkVTVE9SRV9Q
T0lOVCkKIAl7CiAJCXhsX3Jlc3RvcmVfcG9pbnQgKnhscmVjID0gKHhsX3Jlc3RvcmVfcG9pbnQg
KikgcmVjOwpAQCAtMTQyLDYgKzE0OSwzMCBAQCB4bG9nX2Rlc2MoU3RyaW5nSW5mbyBidWYsIFhM
b2dSZWFkZXJTdGF0ZSAqcmVjb3JkKQogCX0KIH0KIAordWludDMyCit4bG9nX3N3aXRjaF9qdW5r
X2xlbihYTG9nUmVhZGVyU3RhdGUgKnJlY29yZCkKK3sKKwl1aW50MzIgCQlqdW5rX2xlbjsKKwlY
TG9nU2VnTm8Jc3RhcnRTZWdObzsKKwlYTG9nU2VnTm8JZW5kU2VnTm87CisKKwlYTEJ5dGVUb1Nl
ZyhyZWNvcmQtPlJlYWRSZWNQdHIsIHN0YXJ0U2VnTm8sIHJlY29yZC0+c2VnY3h0LndzX3NlZ3Np
emUpOworCVhMQnl0ZVRvU2VnKHJlY29yZC0+RW5kUmVjUHRyIC0gMSwgZW5kU2VnTm8sIHJlY29y
ZC0+c2VnY3h0LndzX3NlZ3NpemUpOworCisJanVua19sZW4gPSByZWNvcmQtPkVuZFJlY1B0ciAt
IHJlY29yZC0+UmVhZFJlY1B0ciAtIFhMb2dSZWNHZXRUb3RhbExlbihyZWNvcmQpOworCS8qCisJ
ICogSWYgdGhlIHdhbCBzd2l0Y2ggcmVjb3JkIHNwcmVhZCBvbiB0d28gc2VnbWVudHMsIHdlIHNo
b3VsZCBleHRyYSBtaW51cyB0aGUKKwkgKiBsb25nIHBhZ2UgaGVhZC4gSSBtZWFuIHRoZSBjYXNl
IHdoZW4gdGhlIHJlbWFpbiBzaXplIG9mIGEgd2FsIHNlZ21lbnQgY2FuIG5vdAorCSAqIGFmZm9y
ZCBhIFhMb2dSZWNvcmQgc3RydWN0IGZvciBYTE9HX1NXSVRDSC4KKwkgKi8KKwlpZihzdGFydFNl
Z05vICE9IGVuZFNlZ05vKQorCQlqdW5rX2xlbiAtPSBTaXplT2ZYTG9nTG9uZ1BIRDsKKworCUFz
c2VydChqdW5rX2xlbiA+PSAwKTsKKworCXJldHVybiBqdW5rX2xlbjsKK30KKwogY29uc3QgY2hh
ciAqCiB4bG9nX2lkZW50aWZ5KHVpbnQ4IGluZm8pCiB7CmRpZmYgLS1naXQgYS9zcmMvYmluL3Bn
X3dhbGR1bXAvcGdfd2FsZHVtcC5jIGIvc3JjL2Jpbi9wZ193YWxkdW1wL3BnX3dhbGR1bXAuYwpp
bmRleCAzMWU5OWMyYTZkLi4wZGY0ZGRjZjcyIDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX3dhbGR1
bXAvcGdfd2FsZHVtcC5jCisrKyBiL3NyYy9iaW4vcGdfd2FsZHVtcC9wZ193YWxkdW1wLmMKQEAg
LTI0LDYgKzI0LDcgQEAKICNpbmNsdWRlICJjb21tb24vbG9nZ2luZy5oIgogI2luY2x1ZGUgImdl
dG9wdF9sb25nLmgiCiAjaW5jbHVkZSAicm1ncmRlc2MuaCIKKyNpbmNsdWRlICJjYXRhbG9nL3Bn
X2NvbnRyb2wuaCIKIAogc3RhdGljIGNvbnN0IGNoYXIgKnByb2duYW1lOwogCkBAIC02Niw2ICs2
Nyw4IEBAIHR5cGVkZWYgc3RydWN0IFN0YXRzCiB0eXBlZGVmIHN0cnVjdCBYTG9nRHVtcFN0YXRz
CiB7CiAJdWludDY0CQljb3VudDsKKwl1aW50NjQJCWNvdW50X3hsb2dfc3dpdGNoOworCXVpbnQz
MgkJanVua19zaXplOwogCVN0YXRzCQlybWdyX3N0YXRzW1JNX05FWFRfSURdOwogCVN0YXRzCQly
ZWNvcmRfc3RhdHNbUk1fTkVYVF9JRF1bTUFYX1hMSU5GT19UWVBFU107CiB9IFhMb2dEdW1wU3Rh
dHM7CkBAIC00MTYsMTIgKzQxOSwyMSBAQCBYTG9nRHVtcENvdW50UmVjb3JkKFhMb2dEdW1wQ29u
ZmlnICpjb25maWcsIFhMb2dEdW1wU3RhdHMgKnN0YXRzLAogCXVpbnQ4CQlyZWNpZDsKIAl1aW50
MzIJCXJlY19sZW47CiAJdWludDMyCQlmcGlfbGVuOworCXVpbnQzMgkJanVua19sZW47CisJdWlu
dDgJCWluZm87CiAKIAlzdGF0cy0+Y291bnQrKzsKIAogCXJtaWQgPSBYTG9nUmVjR2V0Um1pZChy
ZWNvcmQpOworCWluZm8gPSBYTG9nUmVjR2V0SW5mbyhyZWNvcmQpICYgflhMUl9JTkZPX01BU0s7
CiAKIAlYTG9nRHVtcFJlY29yZExlbihyZWNvcmQsICZyZWNfbGVuLCAmZnBpX2xlbik7CisJaWYo
Uk1fWExPR19JRCA9PSBybWlkICYmIFhMT0dfU1dJVENIID09IGluZm8pCisJeworCQlqdW5rX2xl
biA9IHhsb2dfc3dpdGNoX2p1bmtfbGVuKHJlY29yZCk7CisJCXN0YXRzLT5jb3VudF94bG9nX3N3
aXRjaCsrOworCQlzdGF0cy0+anVua19zaXplICs9IGp1bmtfbGVuOworCX0KIAogCS8qIFVwZGF0
ZSBwZXItcm1nciBzdGF0aXN0aWNzICovCiAKQEAgLTQzOCw2ICs0NTAsMTQgQEAgWExvZ0R1bXBD
b3VudFJlY29yZChYTG9nRHVtcENvbmZpZyAqY29uZmlnLCBYTG9nRHVtcFN0YXRzICpzdGF0cywK
IAogCXJlY2lkID0gWExvZ1JlY0dldEluZm8ocmVjb3JkKSA+PiA0OwogCisJLyoKKwkgKiBYWFg6
IFRoZXJlIGlzIGEgc3BlY2lhbCBjYXNlIGZvciBYQUNUIHJlY29yZHMuIFRob3NlIHJlY29yZHMg
dXNlIHRoZSBNU0IKKwkgKiBvZiByZWNpZCBmb3IgYW5vdGhlciBwdXJwb3NlLiBJZ25vcmUgdGhh
dCBiaXQgaW4gdGhhdCBjYXNlLgorCSAqLworCWlmIChybWlkID09IFJNX1hBQ1RfSUQpCisJCXJl
Y2lkICY9IDB4MDc7CisKKwogCXN0YXRzLT5yZWNvcmRfc3RhdHNbcm1pZF1bcmVjaWRdLmNvdW50
Kys7CiAJc3RhdHMtPnJlY29yZF9zdGF0c1tybWlkXVtyZWNpZF0ucmVjX2xlbiArPSByZWNfbGVu
OwogCXN0YXRzLT5yZWNvcmRfc3RhdHNbcm1pZF1bcmVjaWRdLmZwaV9sZW4gKz0gZnBpX2xlbjsK
QEAgLTYxMCw2ICs2MzAsNyBAQCBYTG9nRHVtcERpc3BsYXlTdGF0cyhYTG9nRHVtcENvbmZpZyAq
Y29uZmlnLCBYTG9nRHVtcFN0YXRzICpzdGF0cykKIAl1aW50NjQJCXRvdGFsX2xlbiA9IDA7CiAJ
ZG91YmxlCQlyZWNfbGVuX3BjdCwKIAkJCQlmcGlfbGVuX3BjdDsKKwljb25zdCBjaGFyIAkqc3dp
dGNoX2p1bmtfaWQ7CiAKIAkvKgogCSAqIEVhY2ggcm93IHNob3dzIGl0cyBwZXJjZW50YWdlcyBv
ZiB0aGUgdG90YWwsIHNvIG1ha2UgYSBmaXJzdCBwYXNzIHRvCkBAIC02MjIsNyArNjQzLDkgQEAg
WExvZ0R1bXBEaXNwbGF5U3RhdHMoWExvZ0R1bXBDb25maWcgKmNvbmZpZywgWExvZ0R1bXBTdGF0
cyAqc3RhdHMpCiAJCXRvdGFsX3JlY19sZW4gKz0gc3RhdHMtPnJtZ3Jfc3RhdHNbcmldLnJlY19s
ZW47CiAJCXRvdGFsX2ZwaV9sZW4gKz0gc3RhdHMtPnJtZ3Jfc3RhdHNbcmldLmZwaV9sZW47CiAJ
fQorCXRvdGFsX3JlY19sZW4gKz0gc3RhdHMtPmp1bmtfc2l6ZTsKIAl0b3RhbF9sZW4gPSB0b3Rh
bF9yZWNfbGVuICsgdG90YWxfZnBpX2xlbjsKKwl0b3RhbF9jb3VudCArPSBzdGF0cy0+Y291bnRf
eGxvZ19zd2l0Y2g7CiAKIAkvKgogCSAqIDI3IGlzIHN0cmxlbigiVHJhbnNhY3Rpb24vQ09NTUlU
X1BSRVBBUkVEIiksIDIwIGlzIHN0cmxlbigyXjY0KSwgOCBpcwpAQCAtNjUyLDEyICs2NzUsMjAg
QEAgWExvZ0R1bXBEaXNwbGF5U3RhdHMoWExvZ0R1bXBDb25maWcgKmNvbmZpZywgWExvZ0R1bXBT
dGF0cyAqc3RhdHMpCiAJCQlYTG9nRHVtcFN0YXRzUm93KGRlc2MtPnJtX25hbWUsCiAJCQkJCQkJ
IGNvdW50LCB0b3RhbF9jb3VudCwgcmVjX2xlbiwgdG90YWxfcmVjX2xlbiwKIAkJCQkJCQkgZnBp
X2xlbiwgdG90YWxfZnBpX2xlbiwgdG90X2xlbiwgdG90YWxfbGVuKTsKKwkJCWlmKFJNX1hMT0df
SUQgPT0gcmkpCisJCQl7CisJCQkJc3dpdGNoX2p1bmtfaWQgPSAiWExPR1N3aXRjaEp1bmsiOwor
CQkJCVhMb2dEdW1wU3RhdHNSb3cocHNwcmludGYoIiVzIiwgc3dpdGNoX2p1bmtfaWQpLAorCQkJ
CQkJCQkJc3RhdHMtPmNvdW50X3hsb2dfc3dpdGNoLCB0b3RhbF9jb3VudCwgc3RhdHMtPmp1bmtf
c2l6ZSwgdG90YWxfcmVjX2xlbiwKKwkJCQkJCQkJCTAsIHRvdGFsX2ZwaV9sZW4sIHN0YXRzLT5q
dW5rX3NpemUsIHRvdGFsX2xlbik7CisJCQl9CiAJCX0KIAkJZWxzZQogCQl7CiAJCQlmb3IgKHJq
ID0gMDsgcmogPCBNQVhfWExJTkZPX1RZUEVTOyByaisrKQogCQkJewogCQkJCWNvbnN0IGNoYXIg
KmlkOworCQkJCXVpbnQ4CQlpbmZvOwogCiAJCQkJY291bnQgPSBzdGF0cy0+cmVjb3JkX3N0YXRz
W3JpXVtyal0uY291bnQ7CiAJCQkJcmVjX2xlbiA9IHN0YXRzLT5yZWNvcmRfc3RhdHNbcmldW3Jq
XS5yZWNfbGVuOwpAQCAtNjc2LDYgKzcwNywxMiBAQCBYTG9nRHVtcERpc3BsYXlTdGF0cyhYTG9n
RHVtcENvbmZpZyAqY29uZmlnLCBYTG9nRHVtcFN0YXRzICpzdGF0cykKIAkJCQlYTG9nRHVtcFN0
YXRzUm93KHBzcHJpbnRmKCIlcy8lcyIsIGRlc2MtPnJtX25hbWUsIGlkKSwKIAkJCQkJCQkJIGNv
dW50LCB0b3RhbF9jb3VudCwgcmVjX2xlbiwgdG90YWxfcmVjX2xlbiwKIAkJCQkJCQkJIGZwaV9s
ZW4sIHRvdGFsX2ZwaV9sZW4sIHRvdF9sZW4sIHRvdGFsX2xlbik7CisJCQkJaW5mbyA9IChyaiA8
PCA0KSAmIH5YTFJfSU5GT19NQVNLOworCQkJCXN3aXRjaF9qdW5rX2lkID0gIlhMT0cvU1dJVENI
X0pVTksiOworCQkJCWlmKCBYTE9HX1NXSVRDSCA9PSBpbmZvICYmIHN0YXRzLT5jb3VudF94bG9n
X3N3aXRjaCA+IDApCisJCQkJCVhMb2dEdW1wU3RhdHNSb3cocHNwcmludGYoIiVzIiwgc3dpdGNo
X2p1bmtfaWQpLAorCQkJCQkJCQkJc3RhdHMtPmNvdW50X3hsb2dfc3dpdGNoLCB0b3RhbF9jb3Vu
dCwgc3RhdHMtPmp1bmtfc2l6ZSwgdG90YWxfcmVjX2xlbiwKKwkJCQkJCQkJCTAsIHRvdGFsX2Zw
aV9sZW4sIHN0YXRzLT5qdW5rX3NpemUsIHRvdGFsX2xlbik7CiAJCQl9CiAJCX0KIAl9CmRpZmYg
LS1naXQgYS9zcmMvaW5jbHVkZS9hY2Nlc3MveGxvZ19pbnRlcm5hbC5oIGIvc3JjL2luY2x1ZGUv
YWNjZXNzL3hsb2dfaW50ZXJuYWwuaAppbmRleCA0MTQ2NzUzZDQ3Li44Y2JjMzA5MTA4IDEwMDY0
NAotLS0gYS9zcmMvaW5jbHVkZS9hY2Nlc3MveGxvZ19pbnRlcm5hbC5oCisrKyBiL3NyYy9pbmNs
dWRlL2FjY2Vzcy94bG9nX2ludGVybmFsLmgKQEAgLTMxNSw2ICszMTUsNyBAQCBleHRlcm4gWExv
Z1JlY1B0ciBSZXF1ZXN0WExvZ1N3aXRjaChib29sIG1hcmtfdW5pbXBvcnRhbnQpOwogCiBleHRl
cm4gdm9pZCBHZXRPbGRlc3RSZXN0YXJ0UG9pbnQoWExvZ1JlY1B0ciAqb2xkcmVjcHRyLCBUaW1l
TGluZUlEICpvbGR0bGkpOwogCitleHRlcm4gdWludDMyIHhsb2dfc3dpdGNoX2p1bmtfbGVuKFhM
b2dSZWFkZXJTdGF0ZSAqcmVjb3JkKTsKIC8qCiAgKiBFeHBvcnRlZCBmb3IgdGhlIGZ1bmN0aW9u
cyBpbiB0aW1lbGluZS5jIGFuZCB4bG9nYXJjaGl2ZS5jLiAgT25seSB2YWxpZAogICogaW4gdGhl
IHN0YXJ0dXAgcHJvY2Vzcy4K

------=_001_NextPart658837360467_=------