Date: Thu, 15 Oct 2020 20:37:43 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_upgrade: fail early if a tablespace dir already exists for
 new cluster version
Message-ID: <20201016003743.GI3797@momjian.us>
References: <20200925005531.GJ23631@telsasoft.com>
 <20201009185325.GA24870@momjian.us>
 <20201009192310.GS17626@telsasoft.com>
 <20201009234251.GA8419@momjian.us>
 <20201015233530.GG3797@momjian.us>
 <20201016001959.h24fkywfubkv2pc5@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201016001959.h24fkywfubkv2pc5@alap3.anarazel.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Oct 15, 2020 at 05:19:59PM -0700, Andres Freund wrote:
> Hi,
> 
> On 2020-10-15 19:35:30 -0400, Bruce Momjian wrote:
> > On Fri, Oct  9, 2020 at 07:42:51PM -0400, Bruce Momjian wrote:
> > > On Fri, Oct  9, 2020 at 02:23:10PM -0500, Justin Pryzby wrote:
> > > > In my local branch, I had revised this comment to say:
> > > > 
> > > > + * Note, v8.4 has no tablespace_suffix, which is fine so long as the version we
> > > > + * being upgraded *to* has a suffix, since it's not allowed to pg_upgrade from
> > > > + * a version to the same version if tablespaces are in use.
> > > 
> > > OK, updated patch attached.  Also, from your original patch, I didn't
> > > need to call canonicalize_path() since we are not comparing paths, and I
> > > didn't need to include common/relpath.h.  I also renamed a variable.
> > 
> > Patch applied to all supported versions.  Thanks for the report, and the
> > patch.  While I listed you as reporter, I forgot to list you as the
> > patch author --- Tom, can you remember that for the minor release notes
> > please?  Thanks
> 
> This fails on some animals <= 11, because we didn't yet rely on C99.
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2020-10-15%2023%3A52%3A04
> check.c:503:2: error: \342\200\230for\342\200\231 loop initial declarations are only allowed in C99 mode
>   for (int tblnum = 0; tblnum < os_info.num_old_tablespaces; tblnum++)

Thanks, fixed.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee