Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVbXV-00013Y-Ca for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Oct 2020 14:26:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kVbXU-0000EB-8p for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Oct 2020 14:26:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVbXT-0000Dx-5k for pgsql-hackers@lists.postgresql.org; Thu, 22 Oct 2020 14:26:00 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVbXQ-0002Vu-8S for pgsql-hackers@postgresql.org; Thu, 22 Oct 2020 14:25:58 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2BAD75C0138; Thu, 22 Oct 2020 10:25:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 22 Oct 2020 10:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0Sp7CDyaquxyrXXal 5lxFgAyE1Ky7Tez0g4I2NUaI0s=; b=bpUPb+gBDBtc1idESqji4BXs/YzJkQM1O LxrE2wNcwG/b8N1uYBvI8B5UwrSFh/ktaa9nCABkX8hyqyKsIFmMcrsSsbfJmZew xdNIMikmQvje6YSjwpcZyQ7rjd2g6Y18yfOexVCBEw7W3M+/SmPeLPIOsj2aKOWF Wl3LNAwDJI5/AS/yzKYanwPaFHryIU70HJL3H754SnggD1v++t+JL5ABEd85WrEV 2HBEXcj6UlN08xlrD6/wEYChSScCSOVXhPruvxZjglDYU2uhO4yjdM0pugmU+xpp e7rknO2lHnoFC2jQikAGgEEtLpHsnzSuAF+z6hJJfq8vcrrYYyC8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeejgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtuggjfgesthdtredttdervdenucfhrhhomheptehlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqne cuggftrfgrthhtvghrnhepvefgleevgeeujeeghfegteeghfegheeifeehheelteetiedu ieeihffggfehffetnecukfhppeduledtrdelhedrudelrddugeeknecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhv hhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.148]) by mail.messagingengine.com (Postfix) with ESMTPA id E8BF93064683; Thu, 22 Oct 2020 10:25:51 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id D24EE2A0ADF; Thu, 22 Oct 2020 11:25:48 -0300 (-03) Date: Thu, 22 Oct 2020 11:25:48 -0300 From: Alvaro Herrera To: Amit Langote Cc: Heikki Linnakangas , Daniel Gustafsson , Etsuro Fujita , Andres Freund , PostgreSQL-development Subject: Re: partition routing layering in nodeModifyTable.c Message-ID: <20201022142548.GA8832@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Oct-22, Amit Langote wrote: > 0001 fixes a thinko of the recent commit 1375422c782 that I discovered > when debugging a problem with 0003. Hmm, how hard is it to produce a test case that fails because of this problem?