Date: Wed, 28 Oct 2020 14:08:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Masahiko Sawada <sawada.mshk@gmail.com>
Subject: Re: Online checksums verification in the backend
Message-ID: <20201028050852.GF28445@paquier.xyz>
References: 
 <CAOBaU_Yv9crHtC45AaEwQscvoQEgckEa=F_ttJ4T3x3D6QSB8A@mail.gmail.com>
 <CAOBaU_bsMjyqpwd5H=U9VkiQQAGaiak2ouD-DRO7849Drj5crw@mail.gmail.com>
 <20201019023918.GB9612@paquier.xyz>
 <CAOBaU_YZTowoJJ+NzsBieV0K5OvpOS+dAMD1cmz25hxtVZpQqA@mail.gmail.com>
 <20201019075248.GD9612@paquier.xyz>
 <20201023072832.GE5180@paquier.xyz>
 <CAOBaU_bznSonMWqF+N3A8ZOcXx=G4ovwvfgmyES9rmGh5+rV5Q@mail.gmail.com>
 <20201023090630.GA26347@paquier.xyz>
 <20201027070746.GD28445@paquier.xyz>
 <CAOBaU_bM2tCRAOpQyTSaMLT--=YLKGsyZ-tzWTn25kGbaqrevA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="OpLPJvDmhXTZE4Lg"
Content-Disposition: inline
In-Reply-To: 
 <CAOBaU_bM2tCRAOpQyTSaMLT--=YLKGsyZ-tzWTn25kGbaqrevA@mail.gmail.com>
Precedence: bulk


--OpLPJvDmhXTZE4Lg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Oct 27, 2020 at 07:47:19PM +0800, Julien Rouhaud wrote:
> I think it's also worth noting that the IOLock is now acquired just
> before getting the buffer state, and released after the read (or after
> finding that the buffer is dirty).  This is consistent with how it's
> done elsewhere, so I'm fine.

Consistency is the point.  This API should be safe to use by design.
I have done some extra performance tests similar to what I did
upthread, and this version showed similar numbers.

> Other than that I'm quite happy with the changes you made, thanks a lot!

Thanks for confirming.  I have gone through the whole set today,
splitted the thing into two commits and applied them.  We had
buildfarm member florican complain about a mistake in one of the
GetDatum() calls that I took care of already, and there is nothing
else on my radar.
--
Michael

--OpLPJvDmhXTZE4Lg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl+Y/OQACgkQnvQgOdby
QH38wA/8DMaYV6RHywRYhdHaEHaS4Kg2VLm/6wAwUyPUBOHz9AktSwSolthPnBzQ
s+hqjJqUV0uq6q9k660wXSku+hBv1WXYAnonkciBRWAJkzvgIpSsG0D/+j1PoK7f
s4Ok/FRpws5gHy+V1p8QgcLVXy7f/LBJUjhdutqHHpi2KWnuIUkVLIdZnUs1L+RB
y25zANpjMuaYSCdNYJUB2fneOUeOmqPMXFqUvYcuxxaDvWg56htaiRTZK3ACcZPN
KgNWvCh4KShmUzNz45+/xE/EcCOXHEaeVwPjq4JFKVm/pyHye2Z+rptlTIH6GcSW
IDnGFldwqeUCTsQvCghgEUTvQxazHA4F3w2jDDzeFukXqq0kkGAxMfSJJa1/cCOO
pOvlYUqNnXldP4rJ6svPPhQZTJnJUpS+MNLEgRze//q7FtJZsLiI+ogKNAVRwiA3
1FcxLjTQCxwqCP8tMKasRB4qEd4UWHM38GNb3idqX1oE07T5Mc8RKOGThnqu39O/
niCV9xW7hFOY7kRGMhPwpr0af+7T4ksKgD8TXCTkTqAhkqzWalx6239lq0FZ2Mp/
NwtPIiCmDNltJyUx1Xw04UKyF2cqiu+If/mkSKK0yw8rqioaIClbtTs7jNpkzyB5
8P94Q6h6HlRtuzO3KlT6zWyfsc1JonQpPfynsRr3SLkdRFljfWg=
=/OzA
-----END PGP SIGNATURE-----

--OpLPJvDmhXTZE4Lg--