Date: Wed, 28 Oct 2020 20:06:01 +0100
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Cc: Michael Paquier <michael@paquier.xyz>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: list of extended statistics on psql
Message-ID: <20201028190601.bbshe6dhp32767q7@development>
References: <20200831153053.a343pjgumahiejhw@development>
 <20200831161809.GA31337@alvherre.pgsql>
 <20200831163200.jp6eqbaaupb6hxac@development>
 <CAFj8pRDsiGozdoeqHC6d8disaY62Zihw5hL3dUHeFaDjyZAxNw@mail.gmail.com>
 <d63766ca-19fa-25a6-cb60-e61b6bbc7700@nttcom.co.jp_1>
 <20200917055531.GV2873@paquier.xyz>
 <20200930061947.GD1996@paquier.xyz>
 <2a3173fb-8571-3779-2916-d16a170750f0@nttcom.co.jp_1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <2a3173fb-8571-3779-2916-d16a170750f0@nttcom.co.jp_1>
Precedence: bulk

On Wed, Oct 28, 2020 at 03:07:56PM +0900, Tatsuro Yamada wrote:
>Hi Michael-san and Hackers,
>
>On 2020/09/30 15:19, Michael Paquier wrote:
>>On Thu, Sep 17, 2020 at 02:55:31PM +0900, Michael Paquier wrote:
>>>Could you provide at least a rebased version of the patch?  The CF bot
>>>is complaning here.
>>
>>Not seeing this answered after two weeks, I have marked the patch as
>>RwF for now.
>>--
>>Michael
>
>
>Sorry for the delayed reply.
>
>I re-based the patch on the current head and did some
>refactoring.
>I think the size of extended stats are not useful for DBA.
>Should I remove it?
>

I think it's an interesting / useful information, I'd keep it (in the
\dX+ output only, of course). But I think it needs to print the size
similarly to \d+, i.e. using pg_size_pretty - that'll include the unit
and make it more readable for large stats.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services