Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbZrw-0005xG-87 for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Nov 2020 01:51:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kbZru-0006Hk-S8 for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Nov 2020 01:51:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbZrt-0006Hc-LS for pgsql-hackers@lists.postgresql.org; Sun, 08 Nov 2020 01:51:46 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbZrq-00059U-4x for pgsql-hackers@postgresql.org; Sun, 08 Nov 2020 01:51:44 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E78205C00F5; Sat, 7 Nov 2020 20:51:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 07 Nov 2020 20:51:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fEexjxsrQ1rZ+8IuK rJz+25ae0aV9JRiTK0zyom2gTI=; b=MdXaf0AkIclBxiXYofQnExOVWOfp9dBaN Z1dzbW0+xsbESCwEuVQOQAMsybtvBoAPYLux4GMxljukXE3uP1yPSkBzgSF0O/ch lfPtlIrM4bFXEiKaH07qCH/vqFpN6c5uN0q6v72hxWm9P4M2ZdHFih5LgPWvOFf1 C33aSC7t3VeiuO4Jg4jaoZ51zCNqnf7AqyNbHAo6zRfGiIUq48AkQMwFvHbYnPBF YKCWUo1KOwr080kDL9zo1DDA1IKCe464aqBrvbQul9jAjc2oYYhsU11vwNfkDSMJ mucYBlQBlRrr1gROHvQE3Z+xR9D20+uE0nnrDGgJSYpXJCI3rV/YQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduvddgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggujggfsehttdertddtredvnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeevgfelveegueejgefhgeetgefhgeehieefheehleetteei udeiiefhgffgheffteenucfkphepudeltddrleehrdduledrudegkeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghl vhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: from perhan.alvh.no-ip.org (unknown [190.95.19.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 403783062C78; Sat, 7 Nov 2020 20:51:40 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 4BAD72A1AD7; Sat, 7 Nov 2020 22:51:37 -0300 (-03) Date: Sat, 7 Nov 2020 22:51:37 -0300 From: Alvaro Herrera To: Tomas Vondra Cc: pgsql-hackers Subject: Re: Yet another (minor) fix in BRIN Message-ID: <20201108015137.GA7294@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5eb50c97-9a8e-b691-8c40-1b2a55611c4c@enterprisedb.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Nov-08, Tomas Vondra wrote: > While rebasing some of the BRIN patches, I noticed some of the code in > brin_memtuple_initialize is duplicated. This happened in 8bf74967dab > which moved some of the code from brin_new_memtuple, not removing the > shared pieces. In practice this is benign, of course. > > Barring objections I'll get the attached fix committed and backpatched. LGTM, thanks for noticing.