Date: Thu, 19 Nov 2020 12:13:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	James Coleman <jtc331@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: "as quickly as possible" (was: remove spurious CREATE INDEX
 CONCURRENTLY wait)
Message-ID: <20201119031344.GD26172@paquier.xyz>
References: <20201118190928.vnztes7c2sldu43a@alap3.anarazel.de>
 <20201118214127.GA3179@alvherre.pgsql>
 <20201118224840.g72ptl7tbkdcvyau@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h"
Content-Disposition: inline
In-Reply-To: <20201118224840.g72ptl7tbkdcvyau@alap3.anarazel.de>
Precedence: bulk


--veXX9dWIonWZEC6h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 18, 2020 at 02:48:40PM -0800, Andres Freund wrote:
> On 2020-11-18 18:41:27 -0300, Alvaro Herrera wrote:
>> We could make this more concurrent by copying lock->tag to a local
>> variable, releasing the lock, then doing all the string formatting and
>> printing.  See attached quickly.patch.
>=20
> Sounds like a plan.

+1.

>> Now, when this code was written (d7318d43d, 2012), this was a LOG
>> message; it was demoted to DEBUG1 later (d8f15c95bec, 2015).  I think it
>> would be fair to ... remove the message?  Or go back to Simon's original
>> formulation from commit acac68b2bca, which had this message as DEBUG2
>> without any string formatting.
>=20
> I don't really have an opinion on this.

That still looks useful for debugging, so DEBUG1 sounds fine to me.
--
Michael

--veXX9dWIonWZEC6h
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl+14ugACgkQnvQgOdby
QH0VIw//ZWO3DdqOWJTNWxY7s8QiJrgb6GEz7hC9pVwGXozGvRbYjtTmvyAmslrR
F18yPzDHGQ6Dx+KEw0Rvb2ldrm6wDM9W0IGZW6DtXNFKS3tzJkZsmqqgS+D6ogTk
iShP1ibqOJkqfAe6oWO88XYDtF42Cztvbxn+LTHTmfln/F6rAsD6Kri8mn7DsgZC
SVxq9eqAftG+COreDC1w05E3zXQHnPvh6X3zpt5wAFGeEv5IcywKNDR/bLfksddz
9Ln2LlbyrEFbo5Q0Zc4C1BZd7Mc0OLSyxDwnbfuEgEemEmGvTams1Bs6rDu9wCwd
UUhJggG9PnfJFJVtFSZ1dKSoBSKlTuiHGENbFkXdhnnKwvOvAMATyXtlsfQqwm8O
FgrRkMniJoAhCMeKoeyZsl2ebD+G0VhNnBRpVt78CnhIHA7U837h3j5udlJoQ0Jw
LZ2DppI/+dxh9qmoLDga8gv+iySfq/2MqDY0FbDNZDbrRDNWLU5U7Nrtfncr/bBB
be32VtfIEz1J3Q0kp2wML7L8gHINHD6SGmILUfJxSvcgCWhcR0pGBmi2md/nyqvY
RPr9tW6M8Tr/fAVdC9x1K2KnYb3YVPAxZuRtUWV8KaVHoMk01C25sKBNGy5nzUxv
60ZKhwy/TiniA2X3ctVMvz+aLPMwSIESV3eUtEtuRab2exRsyy8=
=hXmN
-----END PGP SIGNATURE-----

--veXX9dWIonWZEC6h--